Skip to content

Commit 857cb11

Browse files
author
DavidQ
committed
Perform verified JSON cleanup using audit script - PR 11.48
1 parent 9c79fe9 commit 857cb11

5 files changed

Lines changed: 90 additions & 23 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,31 +2,23 @@ MODEL: GPT-5.3-codex
22
REASONING: high
33

44
TASK:
5-
Apply PR 11.47.
5+
Apply PR 11.48.
66

7-
Classify complex JSON files from the audit (especially palette.json and tile-map docs).
7+
Use script output:
8+
scripts/PS/audit-sample-json-js-references.ps1
89

9-
Do NOT change code or JSON in this PR.
10+
Select 1–3 JSON files marked NO.
1011

11-
For each selected JSON:
12-
- determine if it is loaded indirectly (manifest/workspace/tool loader)
13-
- confirm visible effect in UI
14-
- classify as:
15-
INDIRECTLY USED
16-
UNUSED
17-
UNCERTAIN
18-
19-
Focus areas:
20-
- samples/**/sample.*.palette.json
21-
- samples/**/sample-*-tile-map-editor-document.json
12+
For each:
13+
- manually verify usage
14+
- apply ONLY if obvious
2215

2316
Do NOT:
24-
- delete or move files
25-
- modify tools
26-
- run full samples test
17+
- touch palette files
18+
- touch tile-map docs
19+
- touch sample 1902
20+
- run full sample suite
2721

2822
Validation:
29-
No runtime changes expected.
30-
31-
Output:
32-
docs/dev/reports/PR_11_47_complex_json_classification.md
23+
- node --check changed files
24+
- targeted checks only

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Classify complex JSON usage (palette + indirect loaders) - PR 11.47
1+
Perform verified JSON cleanup using audit script - PR 11.48
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
PR 11.48 Validation
2+
3+
Scope
4+
- Used script output from scripts/PS/audit-sample-json-js-references.ps1
5+
- Selected 3 JSON files marked NO (non-palette, non-tile-map-doc, non-1902)
6+
7+
Selected NO files and manual verification
8+
1) samples/phase-05/0510/sample.0510.asset-pipeline-tool.json
9+
- Manual verification: INDIRECTLY USED
10+
- Evidence:
11+
- samples/metadata/samples.index.metadata.json maps sample 0510 roundtrip preset to this path
12+
- samples/shared/sampleDetailPageEnhancement.js forwards roundtrip preset path as samplePresetPath
13+
- tools/Asset Pipeline Tool/main.js loads samplePresetPath via fetch and shows loaded preset status
14+
- Action: no change (already correctly wired)
15+
16+
2) samples/phase-05/0512/sample.0512.performance-profiler.json
17+
- Manual verification: INDIRECTLY USED
18+
- Evidence:
19+
- metadata roundtrip preset mapping exists for sample 0512 -> performance-profiler JSON
20+
- sample detail launcher forwards samplePresetPath
21+
- tools/Performance Profiler/main.js loads samplePresetPath via fetch and sets loaded preset status
22+
- Action: no change (already correctly wired)
23+
24+
3) samples/phase-07/0708/sample.0708.replay-visualizer.json
25+
- Manual verification: INDIRECTLY USED
26+
- Evidence:
27+
- metadata roundtrip preset mapping exists for sample 0708 -> replay-visualizer JSON
28+
- sample detail launcher forwards samplePresetPath
29+
- tools/Replay Visualizer/main.js loads samplePresetPath via fetch and sets loaded preset status
30+
- Action: no change (already correctly wired)
31+
32+
Why no file edits were applied
33+
- PR rule: apply ONLY if obvious.
34+
- For all three selected NO entries, indirect ownership/wiring is already valid; the audit script�s NO result reflects missing direct same-sample JS string references, not missing runtime usage.
35+
36+
Validation
37+
- node --check changed files
38+
- No JavaScript files changed in this PR.
39+
- Result: N/A
40+
41+
- Targeted checks only
42+
1) node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=0510-0510
43+
Result: PASS
44+
2) node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=0512-0512
45+
Result: PASS
46+
3) node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=0708-0708
47+
Result: PASS
48+
49+
Full suite
50+
- Not run (per PR instruction: no full sample suite by default)

docs/dev/reports/launch_smoke_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Launch Smoke Report
22

3-
Generated: 2026-04-29T19:43:36.074Z
3+
Generated: 2026-04-29T20:19:41.376Z
44

55
Filters: games=false, samples=true, tools=false, sampleRange=0708-0708
66

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# PR 11.48 — Script-Assisted JSON Cleanup (Verified Only)
2+
3+
## Purpose
4+
Use audit script results to perform verified cleanup of JSON files.
5+
6+
## Rule
7+
Only fix JSON files after manual confirmation.
8+
9+
## Process
10+
For each JSON flagged as NO:
11+
1. Open sample
12+
2. Confirm:
13+
- indirectly used → KEEP
14+
- wrong sample → MOVE
15+
- unused → DELETE
16+
17+
## Scope
18+
- 1–3 files only
19+
- no palette
20+
- no tile-map
21+
- no 1902
22+
23+
## Acceptance
24+
- only verified fixes applied
25+
- no false-positive cleanup

0 commit comments

Comments
 (0)