|
| 1 | +PR 11.48 Validation |
| 2 | + |
| 3 | +Scope |
| 4 | +- Used script output from scripts/PS/audit-sample-json-js-references.ps1 |
| 5 | +- Selected 3 JSON files marked NO (non-palette, non-tile-map-doc, non-1902) |
| 6 | + |
| 7 | +Selected NO files and manual verification |
| 8 | +1) samples/phase-05/0510/sample.0510.asset-pipeline-tool.json |
| 9 | + - Manual verification: INDIRECTLY USED |
| 10 | + - Evidence: |
| 11 | + - samples/metadata/samples.index.metadata.json maps sample 0510 roundtrip preset to this path |
| 12 | + - samples/shared/sampleDetailPageEnhancement.js forwards roundtrip preset path as samplePresetPath |
| 13 | + - tools/Asset Pipeline Tool/main.js loads samplePresetPath via fetch and shows loaded preset status |
| 14 | + - Action: no change (already correctly wired) |
| 15 | + |
| 16 | +2) samples/phase-05/0512/sample.0512.performance-profiler.json |
| 17 | + - Manual verification: INDIRECTLY USED |
| 18 | + - Evidence: |
| 19 | + - metadata roundtrip preset mapping exists for sample 0512 -> performance-profiler JSON |
| 20 | + - sample detail launcher forwards samplePresetPath |
| 21 | + - tools/Performance Profiler/main.js loads samplePresetPath via fetch and sets loaded preset status |
| 22 | + - Action: no change (already correctly wired) |
| 23 | + |
| 24 | +3) samples/phase-07/0708/sample.0708.replay-visualizer.json |
| 25 | + - Manual verification: INDIRECTLY USED |
| 26 | + - Evidence: |
| 27 | + - metadata roundtrip preset mapping exists for sample 0708 -> replay-visualizer JSON |
| 28 | + - sample detail launcher forwards samplePresetPath |
| 29 | + - tools/Replay Visualizer/main.js loads samplePresetPath via fetch and sets loaded preset status |
| 30 | + - Action: no change (already correctly wired) |
| 31 | + |
| 32 | +Why no file edits were applied |
| 33 | +- PR rule: apply ONLY if obvious. |
| 34 | +- For all three selected NO entries, indirect ownership/wiring is already valid; the audit script�s NO result reflects missing direct same-sample JS string references, not missing runtime usage. |
| 35 | + |
| 36 | +Validation |
| 37 | +- node --check changed files |
| 38 | + - No JavaScript files changed in this PR. |
| 39 | + - Result: N/A |
| 40 | + |
| 41 | +- Targeted checks only |
| 42 | + 1) node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=0510-0510 |
| 43 | + Result: PASS |
| 44 | + 2) node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=0512-0512 |
| 45 | + Result: PASS |
| 46 | + 3) node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=0708-0708 |
| 47 | + Result: PASS |
| 48 | + |
| 49 | +Full suite |
| 50 | +- Not run (per PR instruction: no full sample suite by default) |
0 commit comments