Skip to content

Commit 7edcdf0

Browse files
author
DavidQ
committed
rename runtime execution directory from tests to launch — BUILD_PR_LEVEL_12_14_RUNTIME_LAUNCH_DIRECTORY_RENAME & return 1319 runtime entry points to sample server folder — BUILD_PR_LEVEL_12_15_SAMPLE_1319_RUNTIME_RETURN_TO_SERVER
1 parent acc7bdf commit 7edcdf0

14 files changed

Lines changed: 186 additions & 38 deletions

docs/dev/CODEX_COMMANDS.md

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,26 @@
11
MODEL: GPT-5.4
22
REASONING: high
33
COMMAND:
4-
Implement BUILD_PR_LEVEL_12_13_SAMPLE_1319_ROOT_TESTS_AND_PS_RUNBOOK exactly as defined.
4+
Implement BUILD_PR_LEVEL_12_15_SAMPLE_1319_RUNTIME_RETURN_TO_SERVER exactly as defined.
55

66
Required changes:
7-
1. move executable runtime files:
8-
- tests/network-sample-1319/realNetworkServer.mjs
9-
- tests/network-sample-1319/realNetworkDashboard.mjs
10-
into:
11-
- tests/network-sample-1319/realNetworkServer.mjs
12-
- tests/network-sample-1319/realNetworkDashboard.mjs
7+
1. move:
8+
- samples/phase-13/1319/server/realNetworkServer.mjs
9+
- samples/phase-13/1319/server/realNetworkDashboard.mjs
10+
to:
11+
- samples/phase-13/1319/server/realNetworkServer.mjs
12+
- samples/phase-13/1319/server/realNetworkDashboard.mjs
1313

14-
2. keep samples/phase-13/1319/server/ for config/docs only
15-
3. update all references from sample-local tests path to repo-level tests path
16-
4. add a step-by-step PowerShell runbook for launching and validating sample 1319 from terminal
17-
5. keep docker-compose under samples/phase-13/1319/server/docker-compose.yml
18-
6. do not expand scope beyond relocation + runbook
14+
2. update all references to the corrected sample-local server paths
15+
3. remove samples/phase-13/1319/server/ if empty after the move
16+
4. do not change logic or behavior
1917

2018
Validation required:
21-
- no remaining references to sample-local runtime .mjs paths
22-
- node tests/network-sample-1319/realNetworkServer.mjs boots
23-
- sample 1319 launches from samples/index.html
24-
- dashboard loads and updates
25-
- no regressions to launcher/sample pathing
19+
- no remaining references to samples/phase-13/1319/server/
20+
- node samples/phase-13/1319/server/realNetworkServer.mjs boots
21+
- dashboard endpoint loads
22+
- node tmp/validate_1319.mjs passes
23+
- samples/index.html still launches 1319
2624

2725
Update docs/dev/roadmaps/MASTER_ROADMAP_HIGH_LEVEL.md by changing status markers only.
2826
Do not modify roadmap wording, structure, add content, or delete content.

docs/dev/COMMIT_COMMENT.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
relocate 1319 runtime mjs files to repo-level tests and add PowerShell runbook — BUILD_PR_LEVEL_12_13_SAMPLE_1319_ROOT_TESTS_AND_PS_RUNBOOK
1+
return 1319 runtime entry points to sample server folder — BUILD_PR_LEVEL_12_15_SAMPLE_1319_RUNTIME_RETURN_TO_SERVER
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
- confirmed current 1319 layout
2-
- executable runtime mjs files targeted for repo-level tests relocation
3-
- all old sample-local test references must be removed
4-
- PowerShell runbook required
5-
- launcher and dashboard validation required
1+
- incorrect launch/ location corrected
2+
- 1319 runtime restored to sample-local server folder
3+
- references must be updated to server-local paths
4+
- validation remains execution-backed and testable

docs/pr/BUILD_PR_LEVEL_12_10_REAL_NETWORK_SAMPLE_AND_DASHBOARD.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ This BUILD fixes that properly by requiring:
2727
- `samples/phase-13/1319/game/RealNetworkLaunchScene.js`
2828

2929
### Real Server + Dashboard
30-
- `tests/network-sample-1319/realNetworkServer.mjs`
31-
- `tests/network-sample-1319/realNetworkDashboard.mjs`
30+
- `samples/phase-13/1319/server/realNetworkServer.mjs`
31+
- `samples/phase-13/1319/server/realNetworkDashboard.mjs`
3232
- `samples/phase-13/1319/server/README.md`
3333
- `samples/phase-13/1319/server/docker-compose.yml`
3434

docs/pr/BUILD_PR_LEVEL_12_12_SAMPLE_1319_SERVER_TEST_RELOCATION.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ From:
2020
- samples/phase-13/1319/server/*.mjs
2121

2222
To:
23-
- tests/network-sample-1319/*.mjs
23+
- samples/phase-13/1319/server/*.mjs
2424

2525
### Update References
2626
- Update ALL references to new paths

docs/pr/BUILD_PR_LEVEL_12_13_SAMPLE_1319_ROOT_TESTS_AND_PS_RUNBOOK.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@ samples/phase-13/1319/
2525

2626
### A. Move Executable Runtime Files To Repo-Level tests/
2727
Move:
28-
- `tests/network-sample-1319/realNetworkServer.mjs`
29-
- `tests/network-sample-1319/realNetworkDashboard.mjs`
28+
- `samples/phase-13/1319/server/realNetworkServer.mjs`
29+
- `samples/phase-13/1319/server/realNetworkDashboard.mjs`
3030

3131
To repo-level tests home:
32-
- `tests/network-sample-1319/realNetworkServer.mjs`
33-
- `tests/network-sample-1319/realNetworkDashboard.mjs`
32+
- `samples/phase-13/1319/server/realNetworkServer.mjs`
33+
- `samples/phase-13/1319/server/realNetworkDashboard.mjs`
3434

3535
### B. Keep Sample Folder Clean
3636
After relocation:
@@ -62,7 +62,7 @@ The PowerShell runbook must include:
6262
### 1. Start the real server from repo root
6363
Use repo-level test path, not sample-local tests path.
6464
Example target command shape:
65-
- `node tests/network-sample-1319/realNetworkServer.mjs`
65+
- `node samples/phase-13/1319/server/realNetworkServer.mjs`
6666

6767
### 2. Start a local static file host for samples
6868
From repo root using PowerShell-friendly steps.
@@ -101,7 +101,7 @@ Document terminal commands from repo root for validation checks using the correc
101101

102102
## Important Path Correction
103103
The old command:
104-
- `node tests/network-sample-1319/realNetworkServer.mjs`
104+
- `node samples/phase-13/1319/server/realNetworkServer.mjs`
105105

106106
must be replaced with the new repo-level path.
107107

@@ -119,7 +119,7 @@ must be replaced with the new repo-level path.
119119
- repo-level test paths resolve correctly
120120

121121
### Runtime Validation
122-
- `node tests/network-sample-1319/realNetworkServer.mjs` starts successfully
122+
- `node samples/phase-13/1319/server/realNetworkServer.mjs` starts successfully
123123
- sample 1319 still connects correctly
124124
- dashboard still loads and updates
125125

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
# BUILD_PR_LEVEL_12_14_RUNTIME_LAUNCH_DIRECTORY_RENAME
2+
3+
## Purpose
4+
Rename misleading `tests/` runtime execution folder to a clearer `launch/` directory for real server execution.
5+
6+
## Problem
7+
`tests/` implies validation-only usage, but these `.mjs` files are actual runtime entry points.
8+
9+
## Solution
10+
Rename:
11+
- samples/phase-13/1319/server/
12+
13+
To:
14+
- samples/phase-13/1319/server/
15+
16+
## File Moves
17+
- samples/phase-13/1319/server/realNetworkServer.mjs → samples/phase-13/1319/server/realNetworkServer.mjs
18+
- samples/phase-13/1319/server/realNetworkDashboard.mjs → samples/phase-13/1319/server/realNetworkDashboard.mjs
19+
20+
## Update References
21+
- all docs
22+
- runbook
23+
- commands
24+
- scripts
25+
26+
## New Canonical Command
27+
node samples/phase-13/1319/server/realNetworkServer.mjs
28+
29+
## Rules
30+
- no logic changes
31+
- no behavior changes
32+
- rename + path updates only
33+
34+
## Validation
35+
- server starts from new path
36+
- sample 1319 connects
37+
- dashboard works
38+
- no references to old tests path
39+
40+
## Acceptance
41+
- launch/ used instead of tests/
42+
- commands intuitive and clear
Lines changed: 97 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,97 @@
1+
# BUILD_PR_LEVEL_12_15_SAMPLE_1319_RUNTIME_RETURN_TO_SERVER
2+
3+
## Purpose
4+
Return sample 1319 runtime entry points to the correct sample-local server home:
5+
- `samples/phase-13/1319/server/`
6+
7+
## One PR Purpose Only
8+
Path correction for sample 1319 runtime files only.
9+
10+
## Problem
11+
The prior rename moved executable runtime files to:
12+
- `samples/phase-13/1319/server/`
13+
14+
That is the wrong location for this sample.
15+
Sample 1319 should remain self-contained, with its runtime entry points under:
16+
- `samples/phase-13/1319/server/`
17+
18+
## Required Fix
19+
20+
### Move Files
21+
From:
22+
- `samples/phase-13/1319/server/realNetworkServer.mjs`
23+
- `samples/phase-13/1319/server/realNetworkDashboard.mjs`
24+
25+
To:
26+
- `samples/phase-13/1319/server/realNetworkServer.mjs`
27+
- `samples/phase-13/1319/server/realNetworkDashboard.mjs`
28+
29+
### Remove Wrong Location
30+
After validating the new paths, remove:
31+
- `samples/phase-13/1319/server/`
32+
33+
if it is empty and no longer needed.
34+
35+
## Update References
36+
Update all references to the corrected server-local paths, including:
37+
- `samples/phase-13/1319/server/README.md`
38+
- `samples/phase-13/1319/server/docker-compose.yml`
39+
- `samples/phase-13/1319/index.html`
40+
- `tmp/validate_1319.mjs`
41+
- `docs/pr/NETWORK_SAMPLE_1319_POWERSHELL_RUNBOOK.md`
42+
- any current docs/dev command files or related PR docs that mention `samples/phase-13/1319/server/`
43+
44+
## New Canonical Runtime Commands
45+
From repo root:
46+
- `node samples/phase-13/1319/server/realNetworkServer.mjs`
47+
48+
Dashboard runtime path:
49+
- `samples/phase-13/1319/server/realNetworkDashboard.mjs`
50+
51+
## Rules
52+
- no logic changes
53+
- no behavior changes
54+
- path correction only
55+
- keep sample 1319 self-contained
56+
- keep this PR testable, not commit-only
57+
58+
## Validation
59+
60+
### Path Validation
61+
- no remaining references to `samples/phase-13/1319/server/`
62+
- server-local runtime paths resolve correctly
63+
64+
### Runtime Validation
65+
- `node samples/phase-13/1319/server/realNetworkServer.mjs` starts successfully
66+
- dashboard endpoint still loads
67+
- sample 1319 still connects correctly
68+
- second client can still join
69+
- validate_1319 still passes
70+
71+
### Launcher Validation
72+
- `samples/index.html` still launches sample 1319
73+
- `samples/phase-13/1319/index.html` still loads correctly
74+
75+
### Regression
76+
- no breakage to other sample launcher entries
77+
- no breakage to focused phase-13 networking samples
78+
79+
## Roadmap Rule
80+
Update:
81+
`docs/dev/roadmaps/MASTER_ROADMAP_HIGH_LEVEL.md`
82+
83+
Allowed:
84+
- status markers only: `[ ]` `[.]` `[x]`
85+
86+
Forbidden:
87+
- wording edits
88+
- structure edits
89+
- additions
90+
- deletions
91+
92+
## Acceptance Criteria
93+
- runtime `.mjs` files live under `samples/phase-13/1319/server/`
94+
- all references updated
95+
- `samples/phase-13/1319/server/` removed if no longer needed
96+
- runtime and dashboard still function
97+
- sample 1319 still launches from `samples/index.html`

docs/pr/NETWORK_SAMPLE_1319_POWERSHELL_RUNBOOK.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Launch and validate sample 1319 real-network runtime from PowerShell using repo-
1010
## 1) Start Real Server (Terminal A)
1111
```powershell
1212
cd c:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming
13-
node tests/network-sample-1319/realNetworkServer.mjs
13+
node samples/phase-13/1319/server/realNetworkServer.mjs
1414
```
1515

1616
Expected startup output includes:

samples/phase-13/1319/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ <h1>Sample 1319 - Real Network + Live Dashboard</h1>
7070

7171
<p class="server-links">
7272
For this to work, you need to have the server running locally. You can start the server with<br>
73-
<code>node tests/network-sample-1319/realNetworkServer.mjs</code><br>
73+
<code>node samples/phase-13/1319/server/realNetworkServer.mjs</code><br>
7474
from the root of the repository.<br />
7575
</p>
7676
<p class="network-links">

0 commit comments

Comments
 (0)