Skip to content

Commit 79df154

Browse files
author
DavidQ
committed
Add Asset Manager V2 launch guard and finish keyboard test cleanup - PR_26126_105-asset-manager-v2-launch-guard-and-keyboard-test-cleanup
1 parent 537728a commit 79df154

13 files changed

Lines changed: 710 additions & 477 deletions

‎docs/dev/reports/PR_26126_105_asset_manager_v2_keyboard_cleanup_notes.md‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# PR_26126_105 Keyboard Cleanup Notes
2+
3+
## Removed References
4+
- Removed the remaining asset-navigation key assertions from `tests/playwright/PreviewGeneratorV2Baseline.spec.mjs`.
5+
- Removed references to KeyD, KeyA, KeyS, KeyW, ArrowLeft, ArrowRight, ArrowUp, ArrowDown, Home, End, PageUp, PageDown, and Enter asset-navigation behavior.
6+
- Removed the remaining Asset Manager V2 explicit `keydown` handler so source and touched tests no longer contain keyboard navigation references for Asset Manager V2.
7+
8+
## Preserved Behavior
9+
- Asset selection remains mouse/click/tap driven.
10+
- Clicking an asset tile still updates selected tile styling, Selected Asset Detail, and preview output.
11+
- Accordion click behavior remains covered by the existing workspace-v2 Playwright tests.
12+
13+
## Verification
14+
- `rg` search for the listed key names and keyboard navigation terms returned no matches in `tools/asset-manager-v2` or `tests/playwright/PreviewGeneratorV2Baseline.spec.mjs`.
15+
- No sample JSON was modified.

‎docs/dev/reports/PR_26126_105_asset_manager_v2_launch_guard_notes.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# PR_26126_105 Launch Guard Notes
2+
3+
## Guarded Launches
4+
- Direct Asset Manager V2 launch without Workspace Manager context now shows the launch guard overlay before controls are mounted.
5+
- Workspace Manager launch without an active palette now shows the same guard overlay.
6+
- The temporary UAT-only `?palette=sample` context remains allowed and supplies the sample Asteroids game root for preview/path testing.
7+
8+
## Overlay Message
9+
- The guard message states: `Asset Manager V2 is only available through Workspace Manager with a game workspace and palette.`
10+
- The overlay also shows a reason line so direct launch, missing game context, invalid workspace payload, and missing palette cases can be distinguished during UAT.
11+
12+
## Path Field
13+
- Asset Controls Path is now disabled and visibly grayed out like ID.
14+
- Path remains generated from picker/import state and is not user-editable.
15+
16+
## Scope
17+
- No sample JSON was modified.

‎docs/dev/reports/PR_26126_105_asset_manager_v2_manual_validation_notes.md‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# PR_26126_105 Manual Validation Notes
2+
3+
## Commands
4+
- `node --check tools/asset-manager-v2/js/AssetManagerV2App.js`
5+
- `node --check tools/asset-manager-v2/js/bootstrap.js`
6+
- `node --check tools/asset-manager-v2/js/controls/AccordionSection.js`
7+
- `node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs`
8+
- `rg -n "KeyD|KeyA|KeyS|KeyW|ArrowLeft|ArrowRight|ArrowUp|ArrowDown|PageUp|PageDown|Home|End|Enter|keyboard|WASD|wasd|keydown|data-asset-tile-id" tools\asset-manager-v2 tests\playwright\PreviewGeneratorV2Baseline.spec.mjs`
9+
- `npm run test:workspace-v2`
10+
- `git diff --check`
11+
12+
## Results
13+
- `npm run test:workspace-v2` passed 13/13 Playwright tests.
14+
- Playwright validates direct Asset Manager V2 launch shows the launch guard overlay.
15+
- Playwright validates Workspace launch without an active palette shows the launch guard overlay.
16+
- Playwright validates `?palette=sample` remains a valid temporary UAT context.
17+
- Playwright validates Path is disabled and visually matches the disabled ID field.
18+
- Playwright validates click/tap asset selection continues to update selected tile styling, Selected Asset Detail, and preview.
19+
- The keyboard cleanup `rg` search returned no matches in Asset Manager V2 source or the touched Playwright spec.
20+
- No sample JSON was modified.

‎docs/dev/reports/codex_changed_files.txt‎

Lines changed: 21 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,28 @@
11
# git status --short
2-
D docs/dev/reports/PR_26126_101_asset_manager_v2_keyboard_navigation_notes.md
3-
M docs/dev/reports/PR_26126_101_asset_manager_v2_manual_validation_notes.md
4-
D docs/dev/reports/PR_26126_102_asset_manager_v2_keyboard_navigation_notes.md
5-
M docs/dev/reports/PR_26126_102_asset_manager_v2_manual_validation_notes.md
6-
M docs/dev/reports/PR_26126_103_asset_manager_v2_manual_validation_notes.md
7-
M docs/dev/reports/PR_26126_103_asset_manager_v2_scope_cleanup_notes.md
8-
D docs/dev/reports/PR_26126_103_asset_manager_v2_wasd_navigation_notes.md
9-
M docs/dev/reports/coverage_changed_js_guardrail.txt
2+
M docs/dev/reports/coverage_changed_js_guardrail.txt
103
M docs/dev/reports/playwright_v8_coverage_report.txt
114
M tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
12-
M tools/asset-manager-v2/js/controls/AssetCatalogControl.js
13-
?? docs/dev/reports/PR_26126_104_asset_manager_v2_keyboard_removal_notes.md
14-
?? docs/dev/reports/PR_26126_104_asset_manager_v2_manual_validation_notes.md
5+
M tools/asset-manager-v2/index.html
6+
M tools/asset-manager-v2/js/AssetManagerV2App.js
7+
M tools/asset-manager-v2/js/bootstrap.js
8+
M tools/asset-manager-v2/js/controls/AccordionSection.js
9+
M tools/asset-manager-v2/styles/assetManager.css
10+
?? docs/dev/reports/PR_26126_105_asset_manager_v2_keyboard_cleanup_notes.md
11+
?? docs/dev/reports/PR_26126_105_asset_manager_v2_launch_guard_notes.md
12+
?? docs/dev/reports/PR_26126_105_asset_manager_v2_manual_validation_notes.md
1513

1614
# git ls-files --others --exclude-standard
17-
docs/dev/reports/PR_26126_104_asset_manager_v2_keyboard_removal_notes.md
18-
docs/dev/reports/PR_26126_104_asset_manager_v2_manual_validation_notes.md
15+
docs/dev/reports/PR_26126_105_asset_manager_v2_keyboard_cleanup_notes.md
16+
docs/dev/reports/PR_26126_105_asset_manager_v2_launch_guard_notes.md
17+
docs/dev/reports/PR_26126_105_asset_manager_v2_manual_validation_notes.md
1918

2019
# git diff --stat
21-
...1_asset_manager_v2_keyboard_navigation_notes.md | 17 ----
22-
...101_asset_manager_v2_manual_validation_notes.md | 2 +-
23-
...2_asset_manager_v2_keyboard_navigation_notes.md | 26 ------
24-
...102_asset_manager_v2_manual_validation_notes.md | 4 +-
25-
...103_asset_manager_v2_manual_validation_notes.md | 6 +-
26-
...126_103_asset_manager_v2_scope_cleanup_notes.md | 6 +-
27-
...6_103_asset_manager_v2_wasd_navigation_notes.md | 17 ----
28-
docs/dev/reports/coverage_changed_js_guardrail.txt | 3 +-
29-
docs/dev/reports/playwright_v8_coverage_report.txt | 8 +-
30-
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 57 ++++-------
31-
.../js/controls/AssetCatalogControl.js | 104 ++-------------------
32-
11 files changed, 36 insertions(+), 214 deletions(-)
20+
docs/dev/reports/coverage_changed_js_guardrail.txt | 3 +
21+
docs/dev/reports/playwright_v8_coverage_report.txt | 14 +++-
22+
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 90 +++++++++++-----------
23+
tools/asset-manager-v2/index.html | 10 ++-
24+
tools/asset-manager-v2/js/AssetManagerV2App.js | 61 +++++++++++++++
25+
tools/asset-manager-v2/js/bootstrap.js | 1 +
26+
.../js/controls/AccordionSection.js | 7 --
27+
tools/asset-manager-v2/styles/assetManager.css | 45 ++++++++++-
28+
8 files changed, 170 insertions(+), 61 deletions(-)

0 commit comments

Comments
 (0)