Skip to content

Commit 721d952

Browse files
author
DavidQ
committed
Add Validation Viewer clear history and consolidate duplicate error messages - PR_26124_059-validation-viewer-clear-and-error-consolidation
1 parent d4252b7 commit 721d952

12 files changed

Lines changed: 450 additions & 2426 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,26 @@
1-
# Codex Commands - PR_26124_058-palette-manager-baseline-restore-and-hardening
1+
# Codex Commands - PR_26124_059-validation-viewer-clear-and-error-consolidation
22

33
## Workflow
44
- Read `docs/dev/PROJECT_INSTRUCTIONS.md`.
55
- Used `.codex/skills/repo-build/SKILL.md`.
6-
- Created `docs/pr/PR_26124_058-palette-manager-baseline-restore-and-hardening/PLAN_PR.md`.
7-
- Created `docs/pr/PR_26124_058-palette-manager-baseline-restore-and-hardening/BUILD_PR.md`.
8-
- Created `docs/dev/reports/PR_26124_058-palette-manager-restore-point/` before runtime edits.
6+
- Created `docs/pr/PR_26124_059-validation-viewer-clear-and-error-consolidation/PLAN_PR.md`.
7+
- Created `docs/pr/PR_26124_059-validation-viewer-clear-and-error-consolidation/BUILD_PR.md`.
98
- Updated Palette Manager V2 only.
10-
- Created `docs/pr/PR_26124_058-palette-manager-baseline-restore-and-hardening/APPLY_PR.md`.
9+
- Created `docs/pr/PR_26124_059-validation-viewer-clear-and-error-consolidation/APPLY_PR.md`.
1110

1211
## Validation Commands
1312
- `node --check tools/palette-manager-v2/modules/PaletteManagerApp.js`
14-
- `node --check tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js`
15-
- Targeted served-browser Palette Manager V2 hardening validation using Playwright from Node.
13+
- `node --check tools/palette-manager-v2/controls/PaletteValidationErrorControl.js`
14+
- Targeted served-browser Palette Manager V2 validation viewer and duplicate consolidation validation using Playwright from Node.
1615
- `git diff --check`
1716
- `npm run test:workspace-v2`
1817
- `git diff --cached --check`
1918
- `npm run codex:review-artifacts`
20-
- Python `zipfile` packaging for `tmp/PR_26124_058-palette-manager-baseline-restore-and-hardening_delta.zip`
19+
- Python `zipfile` packaging for `tmp/PR_26124_059-validation-viewer-clear-and-error-consolidation_delta.zip`
2120

2221
## Validation Outcome
2322
- JavaScript syntax checks: PASS.
24-
- Targeted served-browser Palette Manager V2 hardening check: PASS.
23+
- Targeted served-browser Palette Manager V2 validation viewer and duplicate consolidation check: PASS.
2524
- `git diff --check`: PASS with Git LF-to-CRLF warnings for changed Palette Manager files.
2625
- `git diff --cached --check`: PASS.
2726
- `npm run test:workspace-v2`: FAILED because the script is missing from `package.json`.

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Harden Palette Manager baseline with restore point - PR_26124_058-palette-manager-baseline-restore-and-hardening
1+
Add Palette Manager validation viewer clear and consolidate duplicate errors - PR_26124_059-validation-viewer-clear-and-error-consolidation
Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
# PR_26124_059-validation-viewer-clear-and-error-consolidation Report
2+
3+
## Summary
4+
Palette Manager V2 Validation/Error Viewer now has a display-only Clear action, and duplicate user swatch validation messages are consolidated into a single line.
5+
6+
## Files Changed
7+
- `docs/pr/PR_26124_059-validation-viewer-clear-and-error-consolidation/PLAN_PR.md`
8+
- `docs/pr/PR_26124_059-validation-viewer-clear-and-error-consolidation/BUILD_PR.md`
9+
- `docs/pr/PR_26124_059-validation-viewer-clear-and-error-consolidation/APPLY_PR.md`
10+
- `docs/dev/codex_commands.md`
11+
- `docs/dev/commit_comment.txt`
12+
- `docs/dev/reports/PR_26124_059_report.md`
13+
- `tools/palette-manager-v2/index.html`
14+
- `tools/palette-manager-v2/modules/PaletteManagerApp.js`
15+
- `tools/palette-manager-v2/controls/PaletteValidationErrorControl.js`
16+
- `tools/palette-manager-v2/paletteManagerV2.css`
17+
18+
## Validation
19+
- JavaScript syntax checks: PASS.
20+
- Targeted served-browser Palette Manager V2 validation viewer and duplicate consolidation validation: PASS.
21+
- `git diff --check`: PASS with Git LF-to-CRLF warnings for changed Palette Manager files.
22+
- `npm run test:workspace-v2`: FAIL because the script is missing from `package.json`.
23+
- Full samples smoke test: skipped by instruction.
24+
25+
## Targeted Browser Coverage
26+
- Duplicate symbol/name/RGB-hex failures render as one consolidated line.
27+
- Name-only duplicate failures render as one line with only the failed field.
28+
- Clear empties the displayed viewer status and error list.
29+
- Clear does not remove or mutate User Palette data.
30+
- Repeating the same validation after Clear renders the message again.
31+
32+
## Manual Test
33+
1. Open Palette Manager V2 through a local server.
34+
2. Add a user swatch.
35+
3. Attempt to add another swatch with duplicate symbol, name, and RGB/hex.
36+
4. Confirm the viewer shows one consolidated duplicate message.
37+
5. Click `Clear` and confirm the viewer output is empty.
38+
6. Repeat the duplicate action and confirm the message appears again.

docs/dev/reports/codex_changed_files.txt

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,11 @@
11
# git status --short
22
M docs/dev/codex_commands.md
33
M docs/dev/commit_comment.txt
4-
A docs/dev/reports/PR_26124_058-palette-manager-restore-point/README.md
5-
A docs/dev/reports/PR_26124_058-palette-manager-restore-point/tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js
6-
A docs/dev/reports/PR_26124_058-palette-manager-restore-point/tools/palette-manager-v2/index.html
7-
A docs/dev/reports/PR_26124_058-palette-manager-restore-point/tools/palette-manager-v2/modules/PaletteManagerApp.js
8-
A docs/dev/reports/PR_26124_058-palette-manager-restore-point/tools/palette-manager-v2/paletteManagerV2.css
9-
A docs/dev/reports/PR_26124_058_report.md
10-
A docs/pr/PR_26124_058-palette-manager-baseline-restore-and-hardening/APPLY_PR.md
11-
A docs/pr/PR_26124_058-palette-manager-baseline-restore-and-hardening/BUILD_PR.md
12-
A docs/pr/PR_26124_058-palette-manager-baseline-restore-and-hardening/PLAN_PR.md
13-
M tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js
4+
A docs/dev/reports/PR_26124_059_report.md
5+
A docs/pr/PR_26124_059-validation-viewer-clear-and-error-consolidation/APPLY_PR.md
6+
A docs/pr/PR_26124_059-validation-viewer-clear-and-error-consolidation/BUILD_PR.md
7+
A docs/pr/PR_26124_059-validation-viewer-clear-and-error-consolidation/PLAN_PR.md
8+
M tools/palette-manager-v2/controls/PaletteValidationErrorControl.js
149
M tools/palette-manager-v2/index.html
1510
M tools/palette-manager-v2/modules/PaletteManagerApp.js
1611
M tools/palette-manager-v2/paletteManagerV2.css

0 commit comments

Comments
 (0)