Implement Object Vector Studio V2 transform editing, viewport controls, and selection synchronization - PR_26132_007-object-vector-studio-v2-transform-editing

Author: DavidQ

docs/dev/reports/playwright_v8_coverage.txt

@@ -20,10 +20,9 @@ Exercised tool entry points detected:
 (0%) Workspace Manager - not exercised by this Playwright run
 
 Changed runtime JS files covered:
-(57%) tools/object-vector-studio-v2/js/controls/StatusLogControl.js - executed lines 24/24; executed functions 4/7
-(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 820/820; executed functions 91/101
-(93%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 178/178; executed functions 14/15
-(100%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 59/59; executed functions 4/4
+(88%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 1476/1476; executed functions 159/181
+(94%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 196/196; executed functions 15/16
+(100%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 68/68; executed functions 4/4
 
 Files with executed line/function counts where available:
 (2%) src/engine/input/ActionInputService.js - executed lines 397/397; executed functions 1/51
@@ -190,13 +189,13 @@ Files with executed line/function counts where available:
 (86%) tools/workspace-manager-v2/js/controls/RepoDestinationControl.js - executed lines 25/25; executed functions 6/7
 (86%) tools/workspace-manager-v2/js/WorkspaceManagerV2App.js - executed lines 945/945; executed functions 42/49
 (88%) games/Pong/game/PongInputController.js - executed lines 77/77; executed functions 7/8
+(88%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 1476/1476; executed functions 159/181
 (88%) tools/preview-generator-v2/PreviewGeneratorV2App.js - executed lines 1498/1498; executed functions 107/121
 (88%) tools/shared/toolLaunchSSoTData.js - executed lines 112/112; executed functions 14/16
 (88%) tools/text2speech-V2/js/controls/TextInputControl.js - executed lines 24/24; executed functions 7/8
 (88%) tools/world-vector-studio-v2/js/controls/SourceInputControl.js - executed lines 33/33; executed functions 7/8
 (89%) tools/asset-manager-v2/js/services/AssetSchemaValidator.js - executed lines 295/295; executed functions 25/28
 (89%) tools/preview-generator-v2/controls/StatusLogControl.js - executed lines 32/32; executed functions 8/9
-(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 820/820; executed functions 91/101
 (90%) tools/palette-manager-v2/modules/PaletteValidationService.js - executed lines 88/88; executed functions 9/10
 (90%) tools/text2speech-V2/js/controls/ActionNavControl.js - executed lines 117/117; executed functions 19/21
 (90%) tools/text2speech-V2/js/TextToSpeechToolApp.js - executed lines 807/807; executed functions 62/69
@@ -206,13 +205,13 @@ Files with executed line/function counts where available:
 (91%) tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js - executed lines 1583/1583; executed functions 145/159
 (92%) tools/object-vector-studio-v2/js/controls/ToolStarterShellControl.js - executed lines 112/112; executed functions 11/12
 (93%) tools/asset-manager-v2/js/services/WorkspaceBridge.js - executed lines 305/305; executed functions 25/27
-(93%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 178/178; executed functions 14/15
 (93%) tools/session-inspector-v2/js/SessionInspectorV2App.js - executed lines 337/337; executed functions 42/45
 (93%) tools/text2speech-V2/js/controls/QueueControl.js - executed lines 122/122; executed functions 26/28
 (93%) tools/workspace-manager-v2/js/controls/GameSelectorControl.js - executed lines 59/59; executed functions 13/14
 (93%) tools/workspace-manager-v2/js/controls/ToolTilesControl.js - executed lines 130/130; executed functions 14/15
 (94%) games/shared/workspaceGameMetadataHydrator.js - executed lines 106/106; executed functions 16/17
 (94%) tools/common/PaletteSortService.js - executed lines 103/103; executed functions 17/18
+(94%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 196/196; executed functions 15/16
 (95%) tools/session-inspector-v2/js/services/SessionInspectorV2StorageService.js - executed lines 142/142; executed functions 18/19
 (100%) games/Asteroids/flow/attract.js - executed lines 17/17; executed functions 1/1
 (100%) games/Asteroids/flow/highscore.js - executed lines 16/16; executed functions 1/1
@@ -254,7 +253,7 @@ Files with executed line/function counts where available:
 (100%) src/shared/utils/textWrapUtils.js - executed lines 34/34; executed functions 4/4
 (100%) tools/asset-manager-v2/js/bootstrap.js - executed lines 70/70; executed functions 4/4
 (100%) tools/asset-manager-v2/js/controls/InspectorControl.js - executed lines 8/8; executed functions 3/3
-(100%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 59/59; executed functions 4/4
+(100%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 68/68; executed functions 4/4
 (100%) tools/object-vector-studio-v2/js/controls/AccordionSection.js - executed lines 27/27; executed functions 5/5
 (100%) tools/preview-generator-v2/controls/AssetFolderControl.js - executed lines 20/20; executed functions 6/6
 (100%) tools/preview-generator-v2/controls/CaptureModeControl.js - executed lines 25/25; executed functions 9/9
@@ -295,7 +294,6 @@ Uncovered or low-coverage changed JS files:
 Changed JS files considered:
 (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tools/object-vector-studio-v2/tests/playwright/FirstClassToolStarter.spec.mjs - changed JS file not collected as browser runtime coverage
-(57%) tools/object-vector-studio-v2/js/controls/StatusLogControl.js - changed JS file with browser V8 coverage
-(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
-(93%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - changed JS file with browser V8 coverage
+(88%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed JS file with browser V8 coverage
+(94%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - changed JS file with browser V8 coverage
 (100%) tools/object-vector-studio-v2/js/bootstrap.js - changed JS file with browser V8 coverage

docs/pr/PR_26132_007-object-vector-studio-v2-transform-editing.md

@@ -0,0 +1,116 @@
+# PR_26132_007-object-vector-studio-v2-transform-editing
+
+## Purpose
+
+Add the Object Vector Studio V2 transform and editing foundation on top of the existing shape runtime.
+
+## Scope
+
+- Added selected-shape move, rotate, scale, resize, duplicate, delete, and z-order controls.
+- Added optional shape transform validation with explicit rejection for invalid transform values.
+- Added selection bounding box, resize handle markers, and pivot/origin visualization on the SVG work surface.
+- Added multi-select foundation using shift-click canvas selection.
+- Added keyboard Delete/Backspace support for selected shapes.
+- Added grid snap and angle snap controls with session persistence.
+- Added viewport zoom, pan, reset, and coordinate display controls.
+- Added dynamic shape geometry edit controls in Object Details by selected shape type.
+- Kept selection synchronized across canvas, object tiles, JSON Details, and Object Details.
+- Preserved schema-gated render behavior with no partial mutation on invalid operations.
+- Kept the change scoped to Object Vector Studio V2 runtime, layout, CSS, and targeted Playwright coverage.
+
+## Validation
+
+Playwright impacted: Yes.
+
+Command run:
+
+```powershell
+npm run test:workspace-v2
+```
+
+Result:
+
+```text
+39 passed
+```
+
+Additional checks:
+
+```powershell
+node --check tools/object-vector-studio-v2/js/ToolStarterApp.js
+node --check tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js
+node --check tools/object-vector-studio-v2/js/bootstrap.js
+node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs
+```
+
+All checks passed.
+
+## Playwright Coverage
+
+The Workspace Manager V2 suite now validates:
+
+- Selection synchronization from canvas to Object Details and JSON Details.
+- Multi-select shift-click foundation.
+- Move with grid snap, rotate with angle snap, scale, and resize operations.
+- Invalid transform rejection without partial mutation.
+- Z-order changes through forward/back/front/back controls.
+- Duplicate and keyboard delete for shapes.
+- Duplicate object behavior.
+- Viewport zoom, pan, and reset.
+- Selection bounding box, resize handles, and pivot/origin visualization.
+- Existing invalid shape payload rejection before render.
+
+Expected pass behavior:
+
+- Valid transform and edit operations mutate only the selected shape/object and log `OK` entries.
+- Canvas selection updates Object Details and JSON Details.
+- Viewport controls update the SVG viewBox and coordinate/zoom display.
+
+Expected fail behavior:
+
+- Invalid transform values log `FAIL` and leave the prior shape payload unchanged.
+- Locked or missing selections log `WARN` and do not mutate payloads.
+
+## V8 Coverage
+
+Required V8 coverage reports:
+
+```text
+docs/dev/reports/playwright_v8_coverage_report.txt
+docs/dev/reports/playwright_v8_coverage.txt
+docs/dev/reports/coverage_changed_js_guardrail.txt
+```
+
+Changed runtime JavaScript coverage includes:
+
+```text
+(88%) tools/object-vector-studio-v2/js/ToolStarterApp.js
+(94%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js
+(100%) tools/object-vector-studio-v2/js/bootstrap.js
+```
+
+The coverage guardrail reported no changed-runtime-JS warnings.
+
+## Full Samples Smoke Test
+
+Skipped. This PR is limited to Object Vector Studio V2 transform/editing runtime behavior and targeted Workspace Manager V2 Playwright coverage. It does not change shared sample loading or broad sample runtime behavior.
+
+## Manual Test Steps
+
+1. Open `tools/object-vector-studio-v2/index.html`.
+2. Import a valid payload with `palette.swatches` and `objects[]`.
+3. Select an object, create rectangle and circle shapes, and confirm the canvas selection box/handles/pivot appear.
+4. Shift-click another shape and confirm multi-select count appears.
+5. Move, rotate, scale, resize, and z-order the selected shape and confirm JSON Details updates.
+6. Try scale `0` and confirm Status Log shows `FAIL` and the previous transform remains.
+7. Duplicate and delete a selected shape, including Delete/Backspace from the canvas.
+8. Use zoom, pan, and reset view and confirm the coordinate/zoom display updates.
+
+## Out Of Scope
+
+- Drag-based direct manipulation.
+- Full path editing.
+- Persistent workspace manifest write-back for Object Vector Studio V2.
+- Palette editing.
+- World Vector Studio V2 runtime behavior.
+- Full samples smoke test.

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -1305,6 +1305,74 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await page.locator("#objectVectorStudioV2ShapeLockButton").click();
       await expect(page.locator("#objectVectorStudioV2JsonDetails")).toContainText('"locked": true');
       await expect(page.locator("#statusLog")).toHaveValue(/OK Shape rectangle-1 lock set to locked\./);
+      await page.locator("#objectVectorStudioV2ShapeLockButton").click();
+      await expect(page.locator("#objectVectorStudioV2JsonDetails")).toContainText('"locked": false');
+      await expect(page.locator("#objectVectorStudioV2RenderSurface [data-selection-bounds='rectangle-1']")).toHaveCount(1);
+      await expect(page.locator("#objectVectorStudioV2RenderSurface [data-resize-handle]")).toHaveCount(4);
+      await expect(page.locator("#objectVectorStudioV2RenderSurface [data-pivot-origin='rectangle-1']")).toHaveCount(1);
+
+      await page.locator("#objectVectorStudioV2RenderSurface [data-shape-id='circle-2']").click({ modifiers: ["Shift"] });
+      await expect(page.locator("#objectVectorStudioV2RenderSurface [data-shape-id='rectangle-1']")).toHaveClass(/is-selected/);
+      await expect(page.locator("#objectVectorStudioV2RenderSurface [data-shape-id='circle-2']")).toHaveClass(/is-selected/);
+      await expect(page.locator("#objectVectorStudioV2SelectedItemVisibility")).toContainText("2 shape selection");
+      await expect(page.locator("#objectVectorStudioV2JsonDetails")).toContainText('"selectedShapeIds"');
+      await page.locator("#objectVectorStudioV2RenderSurface [data-shape-id='rectangle-1']").click();
+      await expect(page.locator("#objectVectorStudioV2ObjectDetails")).toContainText("Rectangle Geometry");
+
+      await page.locator("#objectVectorStudioV2GridSnapButton").click();
+      await expect(page.locator("#objectVectorStudioV2GridSnapButton")).toHaveAttribute("aria-pressed", "true");
+      await page.locator("#objectVectorStudioV2MoveXInput").fill("13");
+      await page.locator("#objectVectorStudioV2MoveYInput").fill("7");
+      await page.locator("#objectVectorStudioV2MoveShapeButton").click();
+      await expect(page.locator("#objectVectorStudioV2JsonDetails")).toContainText('"x": 10');
+      await expect(page.locator("#objectVectorStudioV2JsonDetails")).toContainText('"y": 10');
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Moved shape rectangle-1 by 10, 10\./);
+
+      await page.locator("#objectVectorStudioV2AngleSnapButton").click();
+      await page.locator("#objectVectorStudioV2RotateInput").fill("22");
+      await page.locator("#objectVectorStudioV2RotateShapeButton").click();
+      await expect(page.locator("#objectVectorStudioV2JsonDetails")).toContainText('"rotation": 15');
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Rotated shape rectangle-1 by 15 degrees\./);
+
+      await page.locator("#objectVectorStudioV2ScaleInput").fill("0");
+      await page.locator("#objectVectorStudioV2ScaleShapeButton").click();
+      await expect(page.locator("#statusLog")).toHaveValue(/FAIL Invalid transform rejected for shape rectangle-1: scale must be greater than 0\./);
+      await expect(page.locator("#objectVectorStudioV2JsonDetails")).not.toContainText('"scaleX": 0');
+      await page.locator("#objectVectorStudioV2ScaleInput").fill("1.2");
+      await page.locator("#objectVectorStudioV2ScaleShapeButton").click();
+      await expect(page.locator("#objectVectorStudioV2JsonDetails")).toContainText('"scaleX": 1.2');
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Scaled shape rectangle-1 by 1\.2\./);
+
+      await page.locator("#objectVectorStudioV2ResizeInput").fill("5");
+      await page.locator("#objectVectorStudioV2ResizeShapeButton").click();
+      await expect(page.locator("#objectVectorStudioV2JsonDetails")).toContainText('"width": 91');
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Resized shape rectangle-1 by 5\./);
+
+      await page.locator("#objectVectorStudioV2BringForwardButton").click();
+      await expect(page.locator("#objectVectorStudioV2JsonDetails")).toContainText('"order": 2');
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Shape rectangle-1 z-order forward\./);
+      await page.locator("#objectVectorStudioV2SendToBackButton").click();
+      await expect(page.locator("#objectVectorStudioV2JsonDetails")).toContainText('"order": 1');
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Shape rectangle-1 z-order back\./);
+
+      await page.locator("#objectVectorStudioV2DuplicateShapeButton").click();
+      await expect(page.locator("#objectVectorStudioV2ShapeCount")).toHaveValue("3 shapes");
+      await expect(page.locator("#objectVectorStudioV2RenderSurface [data-shape-id='rectangle-3']")).toHaveClass(/is-selected/);
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Duplicated shape rectangle-1 as rectangle-3\./);
+      await page.locator("#objectVectorStudioV2RenderSurface").focus();
+      await page.keyboard.press("Delete");
+      await expect(page.locator("#objectVectorStudioV2ShapeCount")).toHaveValue("2 shapes");
+      await expect(page.locator("#objectVectorStudioV2RenderSurface [data-shape-id='rectangle-3']")).toHaveCount(0);
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Deleted shape rectangle-3 from keyboard\./);
+
+      await page.locator("#objectVectorStudioV2ZoomInButton").click();
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toContainText("Zoom 125%");
+      await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "0 0 256 176");
+      await page.locator("#objectVectorStudioV2PanRightButton").click();
+      await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "20 0 256 176");
+      await page.locator("#objectVectorStudioV2ResetViewButton").click();
+      await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "0 0 320 220");
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Viewport reset to 100% at origin\./);
 
       await page.locator('[data-object-id="object-2"]').click();
       await expect(page.locator('[data-object-id="object-2"]')).toHaveAttribute("aria-pressed", "true");
@@ -1318,6 +1386,14 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#objectVectorStudioV2JsonDetails")).toContainText('"name": "Object 2 Renamed"');
       await expect(page.locator("#statusLog")).toHaveValue(/OK Renamed object object-2 to Object 2 Renamed\./);
 
+      await page.locator("#objectVectorStudioV2DuplicateObjectButton").click();
+      await expect(page.locator("#objectVectorStudioV2ObjectCount")).toHaveValue("19 objects");
+      await expect(page.locator('[data-object-id="object-2-renamed-copy"]')).toHaveAttribute("aria-pressed", "true");
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Duplicated object Object 2 Renamed as Object 2 Renamed Copy\./);
+      await page.locator("#objectVectorStudioV2DeleteObjectButton").click();
+      await expect(page.locator("#objectVectorStudioV2ObjectCount")).toHaveValue("18 objects");
+      await expect(page.locator('[data-object-id="object-2-renamed-copy"]')).toHaveCount(0);
+
       await page.locator("#objectVectorStudioV2ObjectNameInput").fill("Shield Pickup");
       await page.locator("#objectVectorStudioV2AddObjectButton").click();
       await expect(page.locator("#objectVectorStudioV2ObjectCount")).toHaveValue("19 objects");