Skip to content

Commit 6f2893f

Browse files
author
DavidQ
committed
Deduplicate test commands, standardize on run-node-tests
BUILD_PR_LEVEL_19_14_TEST_COMMAND_DEDUP
1 parent f1492b2 commit 6f2893f

8 files changed

Lines changed: 51 additions & 64 deletions

docs/dev/CODEX_COMMANDS.md

Lines changed: 7 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -1,52 +1,10 @@
11
MODEL: GPT-5.4-codex
2-
REASONING: high
2+
REASONING: low
33

44
COMMAND:
5-
1. Open the roadmap at:
6-
docs/dev/roadmaps/MASTER_ROADMAP_HIGH_LEVEL.md
7-
8-
2. Execute the smallest real PR needed to complete Level 19 Track B:
9-
- validate boot -> run -> shutdown lifecycle
10-
- validate hot reload / reset flows
11-
- validate error handling paths
12-
- validate long-running stability
13-
14-
3. Search only where needed to find the existing lifecycle/runtime validation surfaces:
15-
- tests/
16-
- scripts/
17-
- launch smoke / runtime smoke helpers
18-
- engine runtime boot/reset/shutdown entry points actually used by samples/games/tools
19-
20-
4. Implement the minimum validation-backed changes required:
21-
- add/fix focused tests or validation harnesses
22-
- add tiny runtime lifecycle fixes only if required to make validation deterministic
23-
- do not create new features
24-
- do not perform broad repo cleanup
25-
26-
5. Produce reports:
27-
- docs/dev/reports/BUILD_PR_LEVEL_19_13_RUNTIME_LIFECYCLE_VALIDATION_summary.md
28-
- docs/dev/reports/BUILD_PR_LEVEL_19_13_RUNTIME_LIFECYCLE_VALIDATION_coverage.md
29-
- docs/dev/reports/BUILD_PR_LEVEL_19_13_RUNTIME_LIFECYCLE_VALIDATION_results.md
30-
31-
6. In the reports, explicitly record:
32-
- which lifecycle paths were exercised
33-
- which commands were run
34-
- pass/fail results
35-
- any remaining bounded caveats
36-
37-
7. Update the roadmap only for Track B items proven by this PR:
38-
- [x] validate boot -> run -> shutdown lifecycle
39-
- [x] validate hot reload / reset flows
40-
- [x] validate error handling paths
41-
- [x] validate long-running stability
42-
Only set to [x] if actually validated by execution in this PR.
43-
44-
8. Package the repo-structured ZIP to:
45-
<project folder>/tmp/BUILD_PR_LEVEL_19_13_RUNTIME_LIFECYCLE_VALIDATION.zip
46-
47-
CONSTRAINTS:
48-
- one PR purpose only
49-
- smallest scoped valid change
50-
- no vague wording
51-
- no repo-wide scanning unless required
52-
- no roadmap-only promotion without executed validation
5+
1. Inspect npm test vs run-node-tests.mjs
6+
2. Confirm overlap
7+
3. Update scripts/docs to use ONLY:
8+
node ./scripts/run-node-tests.mjs
9+
4. Remove redundant references to npm test where duplicate
10+
5. Package ZIP

docs/dev/COMMIT_COMMENT.txt

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
1-
Execute runtime lifecycle validation for Level 19 Track B.
1+
Deduplicate test commands, standardize on run-node-tests
22

3-
BUILD_PR_LEVEL_19_13_RUNTIME_LIFECYCLE_VALIDATION
4-
- validate boot/run/shutdown lifecycle
5-
- validate hot reload/reset flows
6-
- validate error handling paths
7-
- validate long-running stability
8-
- update roadmap only for execution-backed results
3+
BUILD_PR_LEVEL_19_14_TEST_COMMAND_DEDUP
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Test Command Deduplication
2+
3+
## Result
4+
Removed redundant test execution path.
5+
6+
## Standard
7+
node ./scripts/run-node-tests.mjs is now canonical.
8+
9+
## Overlap Confirmed
10+
- `npm test` resolves to `node ./scripts/run-node-tests.mjs` via `package.json`.
11+
- Canonical guidance was normalized in active Level 19 BUILD/PLAN docs to avoid duplicate command instructions.

docs/pr/BUILD_PR_LEVEL_19_11_FULL_VALIDATION_AND_PROMOTION.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,8 @@ Promote roadmap items to [x] if validation is clean.
1515

1616
## Steps
1717
1. Run:
18-
npm test
19-
2. Run:
2018
node ./scripts/run-node-tests.mjs
21-
3. Run:
19+
2. Run:
2220
npm run test:launch-smoke
2321

2422
4. If ALL PASS:

docs/pr/BUILD_PR_LEVEL_19_12_REVALIDATE_AND_PROMOTE.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,8 @@ Re-run full validation after Level 18 completion and prior fixes; promote remain
99
- No feature work
1010

1111
## Steps
12-
1. npm test
13-
2. node ./scripts/run-node-tests.mjs
14-
3. npm run test:launch-smoke
12+
1. node ./scripts/run-node-tests.mjs
13+
2. npm run test:launch-smoke
1514

1615
## Acceptance
1716
- If ALL PASS → set all remaining Level 19 items to [x]

docs/pr/BUILD_PR_LEVEL_19_13_RUNTIME_LIFECYCLE_VALIDATION.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ Avoid:
4343

4444
## Validation
4545
Run as applicable:
46-
- `npm test`
4746
- `node ./scripts/run-node-tests.mjs`
4847
- `npm run test:launch-smoke`
4948

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# BUILD_PR_LEVEL_19_14_TEST_COMMAND_DEDUP
2+
3+
## Purpose
4+
Remove duplicate test execution paths to streamline validation.
5+
6+
## Scope
7+
- Single purpose PR
8+
- Deduplicate test commands
9+
- No functional changes
10+
11+
## Change
12+
Standardize on:
13+
- node ./scripts/run-node-tests.mjs
14+
15+
Remove redundant use of:
16+
- npm test (when it executes same suite)
17+
18+
## Overlap Confirmation
19+
- `package.json` defines `"test": "node ./scripts/run-node-tests.mjs"`.
20+
- Therefore `npm test` and `node ./scripts/run-node-tests.mjs` execute the same node test suite path, with `npm test` adding npm lifecycle wrapper behavior.
21+
22+
## Validation
23+
- Ensure selected command covers full suite
24+
- Ensure no loss in coverage
25+
26+
## Acceptance
27+
- One canonical test command
28+
- No duplicate execution paths

docs/pr/PLAN_PR_LEVEL_19_12_COMPLETE_REMAINING_18_19.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ Close the active Level 18 overlay hardening lane by finishing the last in-scope
3434
- Smallest scoped valid tests only.
3535

3636
## Validation Targets (for BUILD)
37-
- `npm test`
3837
- `node ./scripts/run-node-tests.mjs`
3938
- `npm run test:launch-smoke`
4039
- Any focused overlay/runtime tests touched by the Level 18 closure item

0 commit comments

Comments
 (0)