Skip to content

Commit 6dbbd6e

Browse files
author
DavidQ
committed
Refine Palette Manager V2 tag entry and user-defined swatch visibility - PR_26124_050-palette-manager-tag-entry-and-user-defined-visibility
1 parent 90db475 commit 6dbbd6e

14 files changed

Lines changed: 1074 additions & 474 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,27 @@
1-
# Codex Commands - PR_26124_049-palette-manager-swatch-tags-and-selected-layout
1+
# Codex Commands - PR_26124_050-palette-manager-tag-entry-and-user-defined-visibility
22

33
## Workflow
44
- Read `docs/dev/PROJECT_INSTRUCTIONS.md`.
55
- Used `.codex/skills/repo-build/SKILL.md`.
6-
- Created `docs/pr/PR_26124_049-palette-manager-swatch-tags-and-selected-layout/PLAN_PR.md`.
7-
- Created `docs/pr/PR_26124_049-palette-manager-swatch-tags-and-selected-layout/BUILD_PR.md`.
8-
- Updated Palette Manager V2 and the palette swatch schema only.
9-
- Created `docs/pr/PR_26124_049-palette-manager-swatch-tags-and-selected-layout/APPLY_PR.md`.
6+
- Created `docs/pr/PR_26124_050-palette-manager-tag-entry-and-user-defined-visibility/PLAN_PR.md`.
7+
- Created `docs/pr/PR_26124_050-palette-manager-tag-entry-and-user-defined-visibility/BUILD_PR.md`.
8+
- Updated Palette Manager V2 only.
9+
- Created `docs/pr/PR_26124_050-palette-manager-tag-entry-and-user-defined-visibility/APPLY_PR.md`.
1010

1111
## Validation Commands
1212
- `node --check tools/palette-manager-v2/controls/PaletteEditorControl.js`
1313
- `node --check tools/palette-manager-v2/modules/PaletteManagerApp.js`
14-
- `node --check tools/palette-manager-v2/modules/PaletteValidationService.js`
15-
- `node --check tools/palette-manager-v2/modules/paletteUtils.js`
16-
- `node --check tools/palette-manager-v2/modules/SwatchRow.js`
17-
- Palette schema/import validation with positive and negative tag/hex samples using Node.
18-
- Targeted served-browser Palette Manager V2 selected/user-defined/tag/source check using Playwright from Node.
14+
- Targeted served-browser Palette Manager V2 tag-entry/user-defined visibility check using Playwright from Node.
1915
- `git diff --check`
2016
- `git diff --cached --check`
2117
- `npm run test:workspace-v2`
2218
- `npm run codex:review-artifacts`
23-
- Python `zipfile` packaging for `tmp/PR_26124_049-palette-manager-swatch-tags-and-selected-layout_delta.zip`
19+
- Python `zipfile` packaging for `tmp/PR_26124_050-palette-manager-tag-entry-and-user-defined-visibility_delta.zip`
2420

2521
## Validation Outcome
2622
- JavaScript syntax checks: PASS.
27-
- Palette schema/import validation: PASS.
2823
- Targeted served-browser Palette Manager V2 behavior check: PASS.
29-
- `git diff --check`: PASS with Git LF-to-CRLF warnings for changed HTML/schema files.
24+
- `git diff --check`: PASS with Git LF-to-CRLF warnings for changed HTML/CSS files.
3025
- `git diff --cached --check`: PASS.
3126
- `npm run test:workspace-v2`: FAILED because the script is missing from `package.json`.
3227
- Review artifacts: generated.

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Add Palette Manager swatch tags and selected layout split - PR_26124_049-palette-manager-swatch-tags-and-selected-layout
1+
Refine Palette Manager tag entry and user-defined visibility - PR_26124_050-palette-manager-tag-entry-and-user-defined-visibility
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
# PR_26124_050 Report - Palette Manager Tag Entry And User Defined Visibility
2+
3+
## Summary
4+
- Replaced direct tag editing with Add Tag entry controls and read-only tag displays.
5+
- Added tag suggestions from existing User Palette tags with Enter-to-accept behavior.
6+
- Prevented duplicate tags on the same swatch/form.
7+
- Cleared User Defined Swatch form data for source-palette and non-user-defined selections.
8+
9+
## Scope Check
10+
- Runtime code changed only under `tools/palette-manager-v2`.
11+
- No schema changes.
12+
- No `tools/shared` changes.
13+
- No sample JSON changes.
14+
- No workspace/toolState/session changes.
15+
- No dependency changes.
16+
17+
## Validation
18+
- `node --check tools/palette-manager-v2/controls/PaletteEditorControl.js`: PASS.
19+
- `node --check tools/palette-manager-v2/modules/PaletteManagerApp.js`: PASS.
20+
- Targeted served-browser Palette Manager V2 tag-entry/user-defined visibility check: PASS.
21+
- `git diff --check`: PASS with Git LF-to-CRLF warnings for changed HTML/CSS files.
22+
- `git diff --cached --check`: PASS.
23+
- `npm run test:workspace-v2`: FAILED because the script is missing from `package.json`.
24+
- Full samples smoke test: skipped by instruction.
25+
26+
## Review Artifacts
27+
- `docs/dev/reports/codex_review.diff`
28+
- `docs/dev/reports/codex_changed_files.txt`
29+
- `tmp/PR_26124_050-palette-manager-tag-entry-and-user-defined-visibility_delta.zip`

docs/dev/reports/codex_changed_files.txt

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -6,23 +6,17 @@ M docs/dev/codex_commands.md
66
M tools/palette-manager-v2/how_to_use.html
77
M tools/palette-manager-v2/index.html
88
M tools/palette-manager-v2/modules/PaletteManagerApp.js
9-
M tools/palette-manager-v2/modules/PaletteValidationService.js
10-
M tools/palette-manager-v2/modules/SwatchRow.js
11-
M tools/palette-manager-v2/modules/paletteUtils.js
12-
M tools/schemas/tools/palette-browser.schema.json
13-
?? docs/dev/reports/PR_26124_049_report.md
14-
?? docs/pr/PR_26124_049-palette-manager-swatch-tags-and-selected-layout/
9+
M tools/palette-manager-v2/paletteManagerV2.css
10+
?? docs/dev/reports/PR_26124_050_report.md
11+
?? docs/pr/PR_26124_050-palette-manager-tag-entry-and-user-defined-visibility/
1512

1613
# git diff --stat
17-
docs/dev/codex_commands.md | 31 +++++++----
18-
docs/dev/commit_comment.txt | 2 +-
19-
tools/palette-manager-v2/README.md | 8 ++-
20-
.../controls/PaletteEditorControl.js | 57 ++++++++++++++++---
21-
tools/palette-manager-v2/how_to_use.html | 8 ++-
22-
tools/palette-manager-v2/index.html | 39 ++++++++++++-
23-
.../modules/PaletteManagerApp.js | 64 +++++++++++++++++++---
24-
.../modules/PaletteValidationService.js | 14 ++++-
25-
tools/palette-manager-v2/modules/SwatchRow.js | 6 +-
26-
tools/palette-manager-v2/modules/paletteUtils.js | 17 +++++-
27-
tools/schemas/tools/palette-browser.schema.json | 11 ++++
28-
11 files changed, 220 insertions(+), 37 deletions(-)
14+
docs/dev/codex_commands.md | 21 +-
15+
docs/dev/commit_comment.txt | 2 +-
16+
tools/palette-manager-v2/README.md | 6 +-
17+
.../controls/PaletteEditorControl.js | 240 +++++++++++++++++++--
18+
tools/palette-manager-v2/how_to_use.html | 8 +-
19+
tools/palette-manager-v2/index.html | 34 ++-
20+
.../modules/PaletteManagerApp.js | 66 ++++--
21+
tools/palette-manager-v2/paletteManagerV2.css | 61 ++++++
22+
8 files changed, 373 insertions(+), 65 deletions(-)

0 commit comments

Comments
 (0)