Reorder examples so Games appears above Samples in Preview Generator V2 - PR_26126_024-preview-generator-v2-examples-order

Author: DavidQ

docs/dev/codex_commands.md

@@ -1,7 +1,7 @@
-# Codex Commands - PR_26126_023-preview-generator-v2-label-consistency
+# Codex Commands - PR_26126_024-preview-generator-v2-examples-order
 
 ```bash
-codex run "Create PR_26126_023-preview-generator-v2-label-consistency. Fix Preview Generator V2 UI labels only. Preserve existing generation behavior. Make the header/title consistent: replace \"Preview SVG Generator > Preview Generator V2\" with \"Preview Generator V2\" and keep \"First-Class Tools Surface\" as the subtitle/context line. Remove duplicate labels inside the Asset folder section so \"Asset folder\" appears only once with value \"assets/images\". Remove duplicate labels inside Capture mode so \"Capture mode\" appears only once. Move \"Canvas Only\" above \"Full Screen (1600x900 HTML Page)\". Do not modify samples. Do not add schema. Produce review artifacts."
+codex run "Create PR_26126_024-preview-generator-v2-examples-order. Fix Preview Generator V2 UI text ordering only. Preserve existing generation behavior. Move the \"Games examples\" section (games\\<gamename>\\index.html and <gamename>) so it appears above the \"Samples examples\" section (samples/phase-01/0102/index.html). Do not modify samples. Do not add schema. Produce review artifacts."
 ```
 
 ## Validation Commands
@@ -31,47 +31,28 @@ await page.route('https://cdn.jsdelivr.net/**', async (route) => {
   await route.fulfill({ status: 200, contentType: 'text/javascript', body: 'window.html2canvas = window.html2canvas || undefined;' });
 });
 await page.goto(`${server.baseUrl}/tools/preview-generator-v2/index.html`, { waitUntil: 'domcontentloaded' });
-await page.waitForSelector('#shared-theme-header');
-await page.waitForFunction(() => Array.from(document.querySelectorAll('.preview-generator-v2 .accordion-v2__header')).every((header) => header.dataset.accordionV2Bound === 'true'));
-
-const title = await page.title();
-if (title !== 'Preview Generator V2') throw new Error(`Unexpected title: ${title}`);
-const h1 = await page.locator('.tools-platform-frame__title[data-tool-id="preview-generator-v2"]').innerText();
-if (h1.trim() !== 'Preview Generator V2') throw new Error(`Unexpected h1: ${h1}`);
-const eyebrow = await page.locator('.tools-platform-frame__eyebrow').innerText();
-if (eyebrow.trim() !== 'First-Class Tools Surface') throw new Error(`Unexpected context line: ${eyebrow}`);
-const bodyText = await page.locator('body').innerText();
-if (bodyText.includes('Preview SVG Generator')) throw new Error('Old Preview SVG Generator label is still visible.');
-
-const assetLabelCount = await page.evaluate(() => (document.body.innerText.match(/Asset folder/g) || []).length);
-if (assetLabelCount !== 1) throw new Error(`Expected one visible Asset folder label, got ${assetLabelCount}`);
-const assetFolderValue = await page.locator('#assetFolder').inputValue();
-if (assetFolderValue !== 'assets/images') throw new Error(`Unexpected asset folder value: ${assetFolderValue}`);
-const assetAria = await page.locator('#assetFolder').getAttribute('aria-label');
-if (assetAria !== 'Asset folder') throw new Error(`Expected Asset folder aria label, got ${assetAria}`);
-
-const captureLabelCount = await page.evaluate(() => (document.body.innerText.match(/Capture mode/g) || []).length);
-if (captureLabelCount !== 1) throw new Error(`Expected one visible Capture mode label, got ${captureLabelCount}`);
-const captureTexts = await page.locator('#captureModeContent .preview-generator-v2__radio-option span').evaluateAll((nodes) => nodes.map((node) => node.textContent.trim()));
-const expectedCaptureTexts = ['Canvas Only', 'Full Screen (1600x900 HTML Page)'];
-if (JSON.stringify(captureTexts) !== JSON.stringify(expectedCaptureTexts)) throw new Error(`Unexpected capture order: ${captureTexts.join(' | ')}`);
-if (!(await page.locator('#captureModeCanvasOnly').isChecked())) throw new Error('Canvas Only should remain selected by default.');
-if (await page.locator('legend', { hasText: 'Capture mode' }).count()) throw new Error('Capture mode legend should not render as duplicate label.');
-
-const generateButton = page.locator('#executeBtn');
-if (!(await generateButton.isVisible())) throw new Error('Generate Preview button should remain visible.');
-if (!(await generateButton.isDisabled())) throw new Error('Generate Preview should remain disabled until required fields are provided.');
+await page.waitForSelector('#sampleList');
+const placeholder = await page.locator('#sampleList').getAttribute('placeholder');
+if (!placeholder) throw new Error('Paths or IDs placeholder is missing.');
+const gamesIndex = placeholder.indexOf('Games examples:');
+const samplesIndex = placeholder.indexOf('Samples examples:');
+const toolsIndex = placeholder.indexOf('Tools examples:');
+if (gamesIndex !== 0) throw new Error(`Games examples should be first, got index ${gamesIndex}.`);
+if (samplesIndex <= gamesIndex) throw new Error('Samples examples should appear after Games examples.');
+if (toolsIndex <= samplesIndex) throw new Error('Tools examples should remain after Samples examples.');
+if (!placeholder.includes('games\\<gamename>\\index.html')) throw new Error('Games path example is missing.');
+if (!placeholder.includes('samples/phase-01/0102/index.html')) throw new Error('Samples path example is missing.');
 if (errors.length || consoleErrors.length) throw new Error([...errors, ...consoleErrors].join(' | '));
 await browser.close();
 await server.close();
-console.log('preview-generator-v2 label consistency smoke valid');
+console.log('preview-generator-v2 examples order smoke valid');
 '@ | node --input-type=module -
 ```
 
 ## Notes
 
-The targeted Playwright smoke validates the updated title/header labels, confirms the old `Preview SVG Generator` label is not visible, verifies Asset folder and Capture mode each render one visible label, confirms `Canvas Only` is listed before `Full Screen (1600x900 HTML Page)`, and checks the Generate Preview gate remains visible/disabled before required fields are provided.
+The targeted Playwright smoke validates that the `Paths or IDs` placeholder now renders `Games examples` first, then `Samples examples`, then `Tools examples`, while preserving the expected games and samples example text.
 
 `npm run test:workspace-v2` was attempted, but the script is not defined in this checkout.
 
-Full samples smoke test was skipped because this PR is scoped to Preview Generator V2 labels only.
+Full samples smoke test was skipped because this PR is scoped to Preview Generator V2 UI text ordering only.

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Normalize Preview Generator V2 labels - PR_26126_023-preview-generator-v2-label-consistency
+Reorder Preview Generator V2 examples - PR_26126_024-preview-generator-v2-examples-order