Skip to content

Commit 5d8c0c8

Browse files
author
DavidQ
committed
PR 8.19: Sample payload audit and alignment
- Enforced sample payload = workspace tools[] structure - Advanced roadmap status & BUILD_PR_LEVEL_8_20_WORKSPACE_SCHEMA_AUDIT_AND_CLEANUP - Audited workspace schema boundary - Advanced Level 8 roadmap status - Confirmed sample concepts do not belong in workspace schema PR Details: - No runtime changes - No validators added - No start_of_day changes
1 parent 377e323 commit 5d8c0c8

11 files changed

Lines changed: 219 additions & 70 deletions

‎docs/dev/reports/level_8_19_sample_payload_audit_report.md‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# Level 8.19 Sample Payload Audit Report
2+
3+
## Checks
4+
- sample payload structure matches workspace tools[] entries
5+
- no palette or shared data embedded
6+
- naming consistent
7+
8+
## Result
9+
Ready for Codex execution and validation.

‎docs/dev/reports/level_8_20_workspace_schema_audit_report.md‎

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
# Level 8.20 Workspace Schema Audit Report
2+
3+
## Scope
4+
- Audited `tools/schemas/workspace.schema.json` for sample-only concepts.
5+
- Re-validated Level 8 status prerequisites:
6+
- 17/17 first-class tool schema coverage.
7+
- sample tool payload shape alignment from PR 8.19.
8+
- Updated roadmap status markers only.
9+
10+
## Files Changed
11+
- `tools/schemas/workspace.schema.json`
12+
- `docs/dev/roadmaps/MASTER_ROADMAP_ENGINE.md`
13+
- `docs/dev/reports/level_8_20_workspace_schema_audit_report.md`
14+
15+
## Workspace Schema Audit
16+
Target: `tools/schemas/workspace.schema.json`
17+
18+
Removed sample-only concepts:
19+
- removed root `samples` collection
20+
- removed `type` enum containing `sample`
21+
- removed sample-only `phase` field
22+
- removed sample/game conditional branch requirements in `allOf`
23+
24+
Current schema focus:
25+
- root contract uses `games`
26+
- game item requires `id`, `level`, `tool`
27+
- optional game item fields remain `tools`, `palette`
28+
- no sample launch/file semantics
29+
30+
Audit result:
31+
- `workspace_schema_sample_concepts=0`
32+
33+
## Verification Evidence
34+
### 1) First-class tool schema coverage
35+
Command result:
36+
- `active_count=17`
37+
- `schema_count=17`
38+
- `missing=[]`
39+
- `extra=[]`
40+
41+
Conclusion:
42+
- 17/17 first-class tools have exactly one schema file.
43+
44+
### 2) Sample payload shape alignment (PR 8.19 validity recheck)
45+
Command result:
46+
- `tool_payload_count=59`
47+
- `shape_issues=0`
48+
49+
Enforced shape:
50+
- exact top-level keys: `$schema`, `tool`, `version`, `config`
51+
52+
Conclusion:
53+
- PR 8.19 audit remains valid.
54+
55+
## Roadmap Status Updates (Status-Only)
56+
Updated in `docs/dev/roadmaps/MASTER_ROADMAP_ENGINE.md`:
57+
- `Verify all 17 tools have exactly one schema.` -> `[x]`
58+
- `Verify sample tool payload files match workspace/game tools[] item shape.` -> `[x]`
59+
- `Verify workspace schema has no sample-only concepts.` -> `[.]`
60+
61+
No roadmap prose was rewritten.
62+
63+
## Constraint Check
64+
- no runtime files changed
65+
- no validator utilities added
66+
- no `start_of_day` files changed

‎docs/dev/roadmaps/MASTER_ROADMAP_ENGINE.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -875,7 +875,7 @@
875875
- [x] Explicit schema paths recorded for all 17 first-class tools.
876876
- [x] Close first-class schema gap by adding `tools/schemas/tools/skin-editor.schema.json`.
877877
- [x] Define launcher pairing contract: pass tool payload object plus shared data objects.
878-
- [ ] Verify all 17 tools have exactly one schema.
879-
- [ ] Verify sample tool payload files match workspace/game `tools[]` item shape.
878+
- [x] Verify all 17 tools have exactly one schema.
879+
- [x] Verify sample tool payload files match workspace/game `tools[]` item shape.
880880
- [ ] Verify palette/shared data never embeds inside tool payload files.
881-
- [ ] Verify workspace schema has no sample-only concepts.
881+
- [.] Verify workspace schema has no sample-only concepts.

‎docs/dev/roadmaps/MASTER_ROADMAP_ENGINE_LEVEL_8_UPDATE_8_19.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
## Level 8 — Schema-Driven First-Class Tool Normalization
2+
3+
- [x] Canonical 17 first-class tool inventory documented.
4+
- [x] Tool folder paths verified for all 17 first-class tools.
5+
- [x] Explicit schema paths recorded for all 17 first-class tools.
6+
- [x] Close first-class schema gap by adding `skin-editor.schema.json`.
7+
- [x] Define launcher pairing contract.
8+
- [.] Verify all 17 tools have exactly one schema.
9+
- [.] Verify sample tool payload files match workspace/game `tools[]` item shape.
10+
- [ ] Verify palette/shared data never embeds inside tool payload files.
11+
- [ ] Verify workspace schema has no sample-only concepts.

‎docs/operations/dev/codex_commands.md‎

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,27 @@
11
MODEL: GPT-5.3-codex
2+
REASONING: medium
3+
24
TASK:
3-
- Append/update roadmap Level 8 status only
4-
- Add launcher contract docs
5-
- No runtime changes
5+
Apply BUILD_PR_LEVEL_8_20_WORKSPACE_SCHEMA_AUDIT_AND_CLEANUP.
6+
7+
STEPS:
8+
1. Audit tools/schemas/workspace.schema.json.
9+
2. Confirm it has no sample-only concepts:
10+
- samples
11+
- sampleId
12+
- sample-only phase requirement
13+
- sample launch semantics
14+
3. If violations exist, remove only the sample-only schema fields/concepts.
15+
4. Do not modify runtime files.
16+
5. Do not add validators.
17+
6. Do not modify start_of_day.
18+
7. Update docs/dev/roadmaps/MASTER_ROADMAP_ENGINE.md status only:
19+
- [.] -> [x] for 17/17 schema coverage if confirmed.
20+
- [.] -> [x] for sample payload shape if PR 8.19 audit remains valid.
21+
- [ ] -> [.] for workspace schema no sample-only concepts.
22+
8. Write validation findings to docs/dev/reports/level_8_20_workspace_schema_audit_report.md.
23+
24+
ACCEPTANCE:
25+
- workspace_schema_sample_concepts=0
26+
- roadmap status movement only
27+
- runtime/start_of_day unchanged

‎docs/operations/dev/commit_comment.txt‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
1-
PR 8.18: Launcher pairing contract
1+
BUILD_PR_LEVEL_8_20_WORKSPACE_SCHEMA_AUDIT_AND_CLEANUP
22

3-
- Defined openTool(toolPayload, dataObjects)
4-
- Advanced roadmap status
3+
- Audited workspace schema boundary
4+
- Advanced Level 8 roadmap status
5+
- Confirmed sample concepts do not belong in workspace schema
6+
7+
PR Details:
8+
- No runtime changes
9+
- No validators added
10+
- No start_of_day changes

‎docs/pr/BUILD_PR_LEVEL_8_19_SAMPLE_PAYLOAD_AUDIT_AND_ALIGNMENT.md‎

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
# BUILD_PR_LEVEL_8_19_SAMPLE_PAYLOAD_AUDIT_AND_ALIGNMENT
2+
3+
## Objective
4+
Ensure all sample.<id>.<tool>.json files:
5+
6+
- match workspace tools[] payload structure
7+
- contain ONLY:
8+
- $schema
9+
- tool
10+
- version
11+
- config
12+
13+
## Audit Rules
14+
15+
FOR EACH FILE:
16+
samples/**/sample.*.*.json
17+
18+
VERIFY:
19+
- no palette
20+
- no paletteRef
21+
- no assetRefs.paletteId
22+
- no wrapper fields
23+
- schema path valid
24+
- tool matches filename
25+
26+
## Alignment Rule
27+
28+
Sample payload MUST be identical to:
29+
30+
workspace.manifest.json → tools[]
31+
32+
## Acceptance
33+
- all sample payloads clean
34+
- no embedded shared data

‎docs/pr/BUILD_PR_LEVEL_8_20_WORKSPACE_SCHEMA_AUDIT_AND_CLEANUP.md‎

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
# BUILD_PR_LEVEL_8_20_WORKSPACE_SCHEMA_AUDIT_AND_CLEANUP
2+
3+
## Objective
4+
Verify workspace schema is workspace/game focused and does not contain sample-only concepts.
5+
6+
## Audit Targets
7+
- `tools/schemas/workspace.schema.json`
8+
- workspace/game manifest files, if present
9+
- roadmap status section
10+
11+
## Forbidden in workspace.schema.json
12+
- `samples`
13+
- `sampleId`
14+
- sample-only `phase` requirement
15+
- sample launch semantics
16+
- sample tool payload file naming rules
17+
18+
## Allowed in workspace.schema.json
19+
- `documentKind`
20+
- `schema`
21+
- `version`
22+
- `games`
23+
- `level`
24+
- `tools`
25+
- workspace/game shared data references
26+
27+
## Required Roadmap Movement
28+
In `docs/dev/roadmaps/MASTER_ROADMAP_ENGINE.md`:
29+
- Advance `Verify all 17 tools have exactly one schema` from `[.]` to `[x]` if 17/17 schema coverage is confirmed.
30+
- Advance `Verify sample tool payload files match workspace/game tools[] item shape` from `[.]` to `[x]` based on PR 8.19 audit result.
31+
- Advance `Verify workspace schema has no sample-only concepts` from `[ ]` to `[.]`.
32+
33+
## Acceptance
34+
- Workspace schema contains no sample-only concepts.
35+
- Roadmap updates are status-only.
36+
- Report documents findings.
37+
- No runtime/start_of_day changes.

‎docs/pr/PLAN_PR_LEVEL_8_19_SAMPLE_PAYLOAD_AUDIT_AND_ALIGNMENT.md‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# PLAN_PR_LEVEL_8_19_SAMPLE_PAYLOAD_AUDIT_AND_ALIGNMENT
2+
3+
## Purpose
4+
Audit and enforce that all sample tool payload files exactly match workspace tools[] payload shape.
5+
6+
## Scope
7+
- Docs + audit instructions
8+
- Roadmap advancement
9+
- No runtime changes

‎docs/pr/PLAN_PR_LEVEL_8_20_WORKSPACE_SCHEMA_AUDIT_AND_CLEANUP.md‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# PLAN_PR_LEVEL_8_20_WORKSPACE_SCHEMA_AUDIT_AND_CLEANUP
2+
3+
## Purpose
4+
Audit workspace schema boundaries and ensure workspace/game schemas do not contain sample-only concepts.
5+
6+
## Scope
7+
- Roadmap status advancement
8+
- Workspace schema audit
9+
- Docs/report only unless Codex finds schema boundary violations
10+
- No runtime changes
11+
- No validators
12+
- No start_of_day changes

0 commit comments

Comments
 (0)