Skip to content

Commit 5a427d7

Browse files
author
DavidQ
committed
Standardize Asteroids bezel to canonical bezel.png manifest asset - PR 11.91
1 parent 79b3c94 commit 5a427d7

6 files changed

Lines changed: 78 additions & 10 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,8 @@
1-
# Codex Commands — PR 11.90
1+
# Codex Commands — PR 11.91
22

33
Model: GPT-5.4
44
Reasoning: high
55

6-
Run Codex with this task:
7-
86
```text
9-
Apply PR 11.90 from docs/pr/PR_11_90_ASTEROIDS_ENGINE_OWNERSHIP_AND_FONT_MANIFEST.md.
10-
11-
Use the uploaded Asteroids.zip inspection findings as evidence. Finish Asteroids engine ownership correctness: remove remaining game-level background/clear/bezel ownership, keep gameplay-only rendering in Asteroids, make game.manifest.json the only source for bezel/background/font assets, add font.asteroids.vector-battle under asset-browser.assets, set image.asteroids.bezel to bezel1.png with stretchOverride.uniformEdgeStretchPx=10, set image.asteroids.background to deluxe.png, and verify no guessed chrome asset paths remain.
12-
13-
Return a repo-structured ZIP at <project folder>/tmp/PR_11_90_ASTEROIDS_ENGINE_OWNERSHIP_AND_FONT_MANIFEST.zip with changed files and a short validation report.
7+
Apply PR 11.91. Standardize Asteroids bezel asset naming so bezel.png is the only valid bezel file. Update games/Asteroids/game.manifest.json image.asteroids.bezel.path to /games/Asteroids/assets/images/bezel.png, preserve stretchOverride.uniformEdgeStretchPx = 10 on image.asteroids.bezel only, remove any bezel1.png references, do not add fallback guessed paths, and do not place bezel stretch configuration under asset-browser.assets.bezel. Run targeted validation and write findings to docs/dev/reports/PR_11_91_validation.md.
148
```

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Finish Asteroids engine-owned chrome and add font manifest asset - PR 11.90
1+
Standardize Asteroids bezel to canonical bezel.png manifest asset - PR 11.91
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# PR 11.91 Validation
2+
3+
## Scope
4+
Standardized Asteroids bezel naming so `bezel.png` is the only valid bezel file and manifest reference.
5+
6+
## Changes Made
7+
- Updated `games/Asteroids/game.manifest.json`:
8+
- `image.asteroids.bezel.path` -> `/games/Asteroids/assets/images/bezel.png`
9+
- Preserved `image.asteroids.bezel.stretchOverride.uniformEdgeStretchPx = 10`
10+
- Removed duplicate file:
11+
- deleted `games/Asteroids/assets/images/bezel1.png`
12+
13+
## Contract Checks
14+
- `image.asteroids.bezel` exists and points to `bezel.png`.
15+
- `stretchOverride.uniformEdgeStretchPx` remains under `image.asteroids.bezel` only.
16+
- No `asset-browser.assets.bezel` duplicate stretch contract introduced.
17+
18+
## Reference/Path Checks
19+
- `bezel1.png` reference search:
20+
- `rg -n "bezel1\\.png" games/Asteroids src games tools -g "*.json" -g "*.js" -g "*.mjs" -g "*.html"`
21+
- Result: no matches.
22+
- Forbidden guessed chrome paths (runtime/source scope):
23+
- `rg -n "/games/.*/assets/images/bezel\\.png|/games/.*/assets/images/background\\.png" src games tools -g "*.js" -g "*.mjs" -g "*.json" -g "*.html"`
24+
- Result: only manifest declaration hit in `games/Asteroids/game.manifest.json`; no guessed/fallback loader logic added.
25+
26+
## Targeted Validation
27+
- Command: `npm run test:launch-smoke:games`
28+
- Result: PASS (12/12), including Asteroids and SolarSystem.
29+
30+
## Notes
31+
- This PR is manifest/asset naming normalization only; full samples suite was not run.
Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
# PR 11.91 — Standardize Asteroids Bezel Filename
2+
3+
## Purpose
4+
Lock Asteroids bezel asset naming to the canonical `bezel.png` filename.
5+
6+
## Required Changes
7+
- Update `games/Asteroids/game.manifest.json` so `image.asteroids.bezel.path` is `/games/Asteroids/assets/images/bezel.png`.
8+
- Remove every reference to `bezel1.png` from code, manifests, metadata, reports, and docs generated by prior PRs where relevant.
9+
- Keep bezel stretch configuration only on the manifest image asset entry:
10+
11+
```json
12+
"image.asteroids.bezel": {
13+
"path": "/games/Asteroids/assets/images/bezel.png",
14+
"kind": "image",
15+
"source": "workspace-manager",
16+
"stretchOverride": {
17+
"uniformEdgeStretchPx": 10
18+
}
19+
}
20+
```
21+
22+
## Do Not
23+
- Do not rename `bezel.png`.
24+
- Do not introduce `bezel1.png`, `bezel_alt.png`, or any other bezel variant.
25+
- Do not place bezel stretch settings under `asset-browser.assets.bezel`.
26+
- Do not add fallback or guessed bezel paths.
27+
28+
## Validation
29+
Run targeted checks only:
30+
31+
```powershell
32+
Select-String -Path .\* -Recurse -Pattern "bezel1.png"
33+
Select-String -Path .\games\Asteroids\game.manifest.json -Pattern "bezel.png"
34+
```
35+
36+
Expected:
37+
- `bezel1.png` returns zero active references.
38+
- `game.manifest.json` contains `/games/Asteroids/assets/images/bezel.png`.
39+
- Asteroids loads without bezel 404s.
40+
- Bezel renders with `uniformEdgeStretchPx = 10`.
41+
42+
## Test Scope
43+
Targeted validation only. Do not run full samples smoke test.
-389 KB
Binary file not shown.

games/Asteroids/game.manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@
187187
"source": "workspace-manager"
188188
},
189189
"image.asteroids.bezel": {
190-
"path": "/games/Asteroids/assets/images/bezel1.png",
190+
"path": "/games/Asteroids/assets/images/bezel.png",
191191
"kind": "image",
192192
"source": "workspace-manager",
193193
"stretchOverride": {

0 commit comments

Comments
 (0)