You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Replace stale Level 17 test inputs that still simulate `Tab`for debug overlay cycling so the automated checks validate the current non-Tab interaction contract.
4
+
Align overlay stacks for samples 1709 and 1711 (movement-focused) with correct order, bottom-right placement, and non-Tab cycle behavior.
5
5
6
6
## Scope
7
-
This PR is limited to Level 17 test coverage and test helpers that still encode the old cycle key.
8
-
9
-
Included:
10
-
- Update Level 17 tests that currently use `makeInput(['Tab'])`
11
-
- Align those tests to the active non-Tab overlay cycle key already established by the runtime-facing PRs
12
-
- Verify no Level 17 debug overlay tests continue to require browser-reserved Tab behavior
13
-
14
-
Excluded:
15
-
- Runtime keybinding changes
16
-
- Overlay layout changes
17
-
- Sample stack mapping changes
18
-
- Non-Level-17 test cleanup
19
-
20
-
## Implementation Notes
21
-
- Use the already-approved replacement cycle key from the current Level 17 overlay work
22
-
- Prefer shared test constants/helpers if they already exist; otherwise introduce the smallest local test-safe normalization needed
23
-
- Do not broaden this into a repo-wide input cleanup
24
-
- Do not modify `start_of_day` content
7
+
- Samples: 1709, 1711
8
+
- Stack:
9
+
- Movement Runtime
10
+
- Movement Lab HUD
11
+
- Bottom-right anchor
12
+
- Non-Tab cycle key validation
25
13
26
14
## Test Steps
27
-
1. Search Level 17 tests for `makeInput(['Tab'])`
28
-
2. Replace each stale input with the approved non-Tab cycle key
29
-
3. Run the affected Level 17 test files
30
-
4. Confirm overlay cycle assertions still pass under the new input
31
-
5. Confirm no remaining Level 17 tests reference `Tab` for overlay cycling
15
+
1. Load samples 1709 and 1711
16
+
2. Verify bottom-right placement
17
+
3. Cycle overlays and confirm order
18
+
4. Confirm Movement Runtime and HUD render correctly
32
19
33
-
## Expected Result
34
-
-Level 17 tests validate the current non-Tab overlay cycle behavior
35
-
-No stale `makeInput(['Tab'])` calls remain in the affected Level 17 test surface
36
-
-The change stays test-only and does not alter runtime behavior
0 commit comments