Fix next failing tool from audit to enforce strict Workspace V2 contract - PR_11_326

Author: DavidQ

docs/dev/codex_commands.md

@@ -251,6 +251,13 @@ PR_11_325
 npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_325: Fix the highest-impact failing Workspace V2 tool interaction from tool_completion_audit.md."
 ```
 
+---
+PR_11_326
+
+```bash
+npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_326: Fix the next failing tool from tool_completion_audit.md."
+```
+
 ---
 PR_11_321
 

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Fix Workspace V2 palette-manager launch/session contract handling and clear the top audit failure - PR 11.325
+Scope Asset Manager V2 persistence to explicit add/remove actions and remove passive render-time mutation writes - PR 11.326

docs/dev/reports/PR_11_326_report.md

@@ -0,0 +1,32 @@
+# PR_11_326 Report
+
+## Scope
+- Single-tool fix only:
+  - `tools/asset-manager-v2/index.js`
+- No schema changes.
+- No other tool changes.
+
+## Targeted Audit Failure Addressed
+- Prior audit failure for `asset-manager-v2`:
+  - Workspace integration/no payload mutation failed because persistence happened during normal render flow.
+- Fix applied:
+  - passive load/render now does not persist
+  - persistence occurs only on explicit add/remove actions
+
+## Files Changed
+- `tools/asset-manager-v2/index.js`
+- `docs/pr/PR_11_326_ASSET_MANAGER_MUTATION_SCOPE_FIX/PLAN_PR.md`
+- `docs/pr/PR_11_326_ASSET_MANAGER_MUTATION_SCOPE_FIX/BUILD_PR.md`
+- `docs/dev/reports/PR_11_326_report.md`
+- `docs/dev/codex_commands.md`
+- `docs/dev/commit_comment.txt`
+
+## Validation Run
+- `node --check tools/asset-manager-v2/index.js` -> PASS
+- `node tests/runtime/V2AssetManagerWorkspacePersistence.test.mjs` -> PASS
+- `npm run test:workspace-v2` -> PASS (`1 passed`, `failed=0`)
+
+## Notes
+- This PR intentionally keeps launch behavior unchanged (sample/workspace paths remain intact).
+- No fallback/default data paths were added.
+- No schema or cross-tool contract changes were introduced.

docs/pr/PR_11_326_ASSET_MANAGER_MUTATION_SCOPE_FIX/BUILD_PR.md

@@ -0,0 +1,18 @@
+# BUILD_PR_11_326
+
+## Implementation
+- Updated `tools/asset-manager-v2/index.js` only.
+- Scoped session persistence to explicit mutation paths:
+  - `addAssetEntry` -> `loadContract(nextSessionContext, true)`
+  - `removeAssetEntryById` -> `loadContract(nextSessionContext, true)`
+- Updated passive load path to avoid implicit persistence:
+  - `readSession` -> `loadContract(parsedSession, false)`
+- Updated contract/render pipeline:
+  - `loadContract(sessionContext, persistToWorkspace = false)`
+  - `renderCatalog(assetCatalog, sessionContext, persistToWorkspace = false)`
+  - persistence readout now reflects passive load vs explicit mutation persistence.
+
+## Validation
+- `node --check tools/asset-manager-v2/index.js`
+- `node tests/runtime/V2AssetManagerWorkspacePersistence.test.mjs`
+- `npm run test:workspace-v2`

docs/pr/PR_11_326_ASSET_MANAGER_MUTATION_SCOPE_FIX/PLAN_PR.md

@@ -0,0 +1,21 @@
+# PLAN_PR_11_326
+
+## Purpose
+Fix the next failing tool from the audit (`asset-manager-v2`) by removing unintended passive payload mutation while preserving launch and explicit add/remove behavior.
+
+## Scope
+- `tools/asset-manager-v2/index.js`
+- `docs/pr/PR_11_326_ASSET_MANAGER_MUTATION_SCOPE_FIX/PLAN_PR.md`
+- `docs/pr/PR_11_326_ASSET_MANAGER_MUTATION_SCOPE_FIX/BUILD_PR.md`
+- `docs/dev/reports/PR_11_326_report.md`
+- `docs/dev/codex_commands.md`
+- `docs/dev/commit_comment.txt`
+
+## Steps
+1. Keep valid/invalid JSON contract handling unchanged.
+2. Ensure workspace persistence is not performed during passive render/load.
+3. Keep persistence tied to explicit asset modification actions.
+4. Validate:
+   - syntax check for changed tool file
+   - target tool persistence behavior check
+   - Workspace V2 Playwright gate

tools/asset-manager-v2/index.js

@@ -211,7 +211,7 @@ class AssetBrowserV2 {
     }
     const nextSessionContext = this.cloneSessionValue(this.currentSessionContext);
     nextSessionContext.payloadJson.assetCatalog.entries.push(newEntry.entry);
-    this.loadContract(nextSessionContext);
+    this.loadContract(nextSessionContext, true);
     this.clearAddAssetForm();
     this.setActionStatus(`Asset '${newEntry.entry.id}' added.`);
   }
@@ -245,7 +245,7 @@ class AssetBrowserV2 {
       this.setActionStatus(`Remove blocked. Asset id '${normalizedId}' was not found.`);
       return;
     }
-    this.loadContract(nextSessionContext);
+    this.loadContract(nextSessionContext, true);
     this.setActionStatus(`Asset '${normalizedId}' removed.`);
   }
 
@@ -279,7 +279,8 @@ class AssetBrowserV2 {
         return;
       }
       this.loadContract(
-        JSON.parse(serializedSession)
+        JSON.parse(serializedSession),
+        false
       );
     } catch (error) {
       const runtimeMessage = `Unable to read Asset Manager V2 session context: ${error instanceof Error ? error.message : "unknown error"}`;
@@ -288,7 +289,7 @@ class AssetBrowserV2 {
     }
   }
 
-  loadContract(sessionContext) {
+  loadContract(sessionContext, persistToWorkspace = false) {
     console.log("[ASSET_BROWSER_V2_CONTRACT_LOADED]");
     if (!sessionContext || typeof sessionContext !== "object" || Array.isArray(sessionContext)) {
       this.renderError("Session context is invalid. Expected an object containing payloadJson.assetCatalog.");
@@ -315,7 +316,7 @@ class AssetBrowserV2 {
       this.renderError("Asset Manager V2 session data is invalid. Remove payloadJson.importName/importDestination. Load assets from payloadJson.assetCatalog only.");
       return;
     }
-    this.renderCatalog(versionCheck.payload.payloadJson.assetCatalog, versionCheck.payload);
+    this.renderCatalog(versionCheck.payload.payloadJson.assetCatalog, versionCheck.payload, persistToWorkspace);
   }
 
   persistValidSessionForWorkspace(sessionContext, assetCatalog) {
@@ -355,7 +356,7 @@ class AssetBrowserV2 {
     return { ok: true, message: "" };
   }
 
-  renderCatalog(assetCatalog, sessionContext) {
+  renderCatalog(assetCatalog, sessionContext, persistToWorkspace = false) {
     if (typeof assetCatalog.name !== "string" || !assetCatalog.name.trim()) {
       this.renderError("Asset Manager V2 session data is invalid. Expected assetCatalog.name.");
       return;
@@ -386,10 +387,14 @@ class AssetBrowserV2 {
 
     document.getElementById("assetBrowserV2SessionReadout").textContent = `Session: loaded\nContext: ${this.urlState.hostContextId}\nTool: ${typeof sessionContext.toolId === "string" && sessionContext.toolId.trim() ? sessionContext.toolId.trim() : "not provided"}${this.optionalUrlStateSummary() ? `\nURL State: ${this.optionalUrlStateSummary()}` : ""}`;
     document.getElementById("assetBrowserV2ContractReadout").textContent = "payloadJson loaded\npayloadJson.assetCatalog valid\nentries[] valid";
-    const persistence = this.persistValidSessionForWorkspace(sessionContext, assetCatalog);
-    document.getElementById("assetBrowserV2WorkspaceReadout").textContent = persistence.ok
-      ? "Workspace session context was read and persisted for Workspace V2 export."
-      : `Workspace session context was read but could not be persisted: ${persistence.message}`;
+    if (persistToWorkspace) {
+      const persistence = this.persistValidSessionForWorkspace(sessionContext, assetCatalog);
+      document.getElementById("assetBrowserV2WorkspaceReadout").textContent = persistence.ok
+        ? "Workspace session context was read and persisted for Workspace V2 export."
+        : `Workspace session context was read but could not be persisted: ${persistence.message}`;
+    } else {
+      document.getElementById("assetBrowserV2WorkspaceReadout").textContent = "Workspace session context loaded. Changes persist only after Add or Remove actions.";
+    }
     document.getElementById("assetBrowserV2Title").textContent = assetCatalog.name.trim();
     document.getElementById("assetBrowserV2Count").textContent = `${assetCatalog.entries.length} asset${assetCatalog.entries.length === 1 ? "" : "s"}`;
     document.getElementById("assetBrowserV2State").textContent = assetCatalog.entries.length === 0