Skip to content

Commit 4e54eec

Browse files
author
DavidQ
committed
Add Color usage ID segment and adjust Asset Manager V2 detail height - PR_26126_100-asset-manager-v2-color-usage-and-detail-height
1 parent a174d26 commit 4e54eec

28 files changed

Lines changed: 696 additions & 240 deletions
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# PR_26126_100 Asset Manager V2 Color Usage ID Notes
2+
3+
## Usage Field
4+
- Color assets now expose a required `Usage` textbox directly under `Role`.
5+
- `Usage` is hidden and disabled for non-Color asset types.
6+
- The typed Usage value remains editable as entered; normalization is applied only when generating the asset ID segment.
7+
8+
## Color ID Shape
9+
- Color IDs now use `assets.<type>.<role>.<usage>.<colorName>`.
10+
- Example: Usage `Primary HUD` plus swatch `Sky Blue` becomes `assets.color.hud.primary-hud.sky-blue`.
11+
- The original palette swatch name is not altered in color metadata.
12+
- Color path generation is unchanged; swatch `Sky Blue` still resolves to `palette://workspace/sky-blue`.
13+
14+
## Validation
15+
- Selecting a Color swatch without Usage leaves the generated ID empty and keeps `Add Asset` disabled.
16+
- Missing Usage validation is routed to Status only: `Selected color validation failed: Color usage is required for color assets.`
17+
- Schema validation rejects Color asset IDs that do not include both Usage and color name segments.
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# PR_26126_100 Asset Manager V2 Manual Validation Notes
2+
3+
## Commands
4+
- `node --check tools/asset-manager-v2/js/controls/AssetFormControl.js`
5+
- `node --check tools/asset-manager-v2/js/assetManagerMetadata.js`
6+
- `node --check tools/asset-manager-v2/js/services/AssetSchemaValidator.js`
7+
- `node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs`
8+
- `git diff --check`
9+
- `npm run test:workspace-v2`
10+
11+
## Results
12+
- JavaScript syntax checks passed for changed runtime and Playwright files.
13+
- Required workspace-v2 Playwright gate passed: 12 tests passed.
14+
- `git diff --check` passed with no whitespace errors.
15+
- `docs/dev/reports/playwright_v8_coverage_report.txt` was regenerated by the required workspace-v2 validation run.
16+
17+
## Manual Checks Covered By Tests
18+
- Selected Asset Detail is 20px taller through the embedded preview area while retaining the PR_26126_099 bottom-spacing guard.
19+
- Usage appears directly under Role only for Color assets.
20+
- Usage is hidden and disabled for non-Color assets.
21+
- Color swatch selection without Usage writes validation failure to Status only and keeps Add Asset disabled.
22+
- Color IDs include normalized Usage and normalized swatch name: `assets.<type>.<role>.<usage>.<colorName>`.
23+
- Color paths and original swatch names are preserved.
24+
- Workspace V2 insertion uses the new Color ID structure.
25+
- Sample JSON files were not modified.
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# PR_26126_100 Asset Manager V2 Selected Detail Height Notes
2+
3+
## Height Adjustment
4+
- Selected Asset Detail remains content-controlled; no fixed `300px` height was restored.
5+
- The embedded preview area min-height increased from `104px` to `124px`, raising the selected detail area by 20px through real content.
6+
7+
## Spacing Guard
8+
- The PR_26126_099 trailing whitespace checks remain in workspace-v2 coverage.
9+
- Asset Controls, Assets, and Selected Asset Detail still validate with no extra trailing body gap after their final visible content.
10+
11+
## Validation
12+
- Playwright verifies the Selected Asset Detail preview min-height is `124px`.
13+
- Playwright verifies the Selected Asset Detail section height remains content-driven and not fixed at `300px`.

docs/dev/reports/codex_changed_files.txt

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,28 @@ M docs/dev/reports/coverage_changed_js_guardrail.txt
33
M docs/dev/reports/playwright_v8_coverage_report.txt
44
M tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
55
M tools/asset-manager-v2/index.html
6+
M tools/asset-manager-v2/js/assetManagerMetadata.js
7+
M tools/asset-manager-v2/js/bootstrap.js
8+
M tools/asset-manager-v2/js/controls/AssetFormControl.js
9+
M tools/asset-manager-v2/js/services/AssetSchemaValidator.js
610
M tools/asset-manager-v2/styles/assetManager.css
7-
?? docs/dev/reports/PR_26126_099_asset_manager_v2_accordion_spacing_notes.md
8-
?? docs/dev/reports/PR_26126_099_asset_manager_v2_manual_validation_notes.md
11+
?? docs/dev/reports/PR_26126_100_asset_manager_v2_color_usage_id_notes.md
12+
?? docs/dev/reports/PR_26126_100_asset_manager_v2_manual_validation_notes.md
13+
?? docs/dev/reports/PR_26126_100_asset_manager_v2_selected_detail_height_notes.md
914

1015
# git ls-files --others --exclude-standard
11-
docs/dev/reports/PR_26126_099_asset_manager_v2_accordion_spacing_notes.md
12-
docs/dev/reports/PR_26126_099_asset_manager_v2_manual_validation_notes.md
16+
docs/dev/reports/PR_26126_100_asset_manager_v2_color_usage_id_notes.md
17+
docs/dev/reports/PR_26126_100_asset_manager_v2_manual_validation_notes.md
18+
docs/dev/reports/PR_26126_100_asset_manager_v2_selected_detail_height_notes.md
1319

1420
# git diff --stat
15-
docs/dev/reports/coverage_changed_js_guardrail.txt | 2 --
16-
docs/dev/reports/playwright_v8_coverage_report.txt | 4 ---
17-
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 38 +++++++++++++++++++---
18-
tools/asset-manager-v2/index.html | 17 +++++++---
19-
tools/asset-manager-v2/styles/assetManager.css | 18 ++++++----
20-
5 files changed, 57 insertions(+), 22 deletions(-)
21+
docs/dev/reports/coverage_changed_js_guardrail.txt | 8 ++--
22+
docs/dev/reports/playwright_v8_coverage_report.txt | 22 ++++-----
23+
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 53 ++++++++++++++++++----
24+
tools/asset-manager-v2/index.html | 4 ++
25+
tools/asset-manager-v2/js/assetManagerMetadata.js | 11 +++++
26+
tools/asset-manager-v2/js/bootstrap.js | 2 +
27+
.../js/controls/AssetFormControl.js | 44 ++++++++++++++++--
28+
.../js/services/AssetSchemaValidator.js | 11 ++++-
29+
tools/asset-manager-v2/styles/assetManager.css | 4 +-
30+
9 files changed, 128 insertions(+), 31 deletions(-)

0 commit comments

Comments
 (0)