BUILD PR: centralize network debug serialization helpers across exact network debug batch. V2

Author: DavidQ

games/network_sample_a/debug/networkSampleADebug.js

@@ -8,6 +8,7 @@ networkSampleADebug.js
 import { createNetworkDebugPluginDefinition } from "../../../engine/debug/network/index.js";
 import { asArray, asObject } from "../../../src/engine/debug/inspectors/shared/inspectorUtils.js";
 import {
+  asNumber,
   commandLinesForTrace,
   getCommandSnapshot,
   toNetworkSnapshot
@@ -19,10 +20,6 @@ function sanitizeText(value) {
   return typeof value === "string" ? value.trim() : "";
 }
 
-function asNumber(value, fallback = 0) {
-  return Number.isFinite(value) ? Number(value) : fallback;
-}
-
 function toConnectionLines(snapshot) {
   const network = toNetworkSnapshot(snapshot, NETWORK_SAMPLE_KEY);
   const connection = asObject(network.connection);

games/network_sample_b/debug/networkSampleBDebug.js

@@ -7,19 +7,14 @@ networkSampleBDebug.js
 
 import { createNetworkDebugPluginDefinition } from "../../../engine/debug/network/index.js";
 import { asArray, asObject } from "../../../src/engine/debug/inspectors/shared/inspectorUtils.js";
-import { toNetworkSnapshot } from "../../../src/shared/utils/networkDebugUtils.js";
+import { asNumber, toNetworkSnapshot } from "../../../src/shared/utils/networkDebugUtils.js";
 
 const NETWORK_SAMPLE_KEY = "networkSampleB";
 
 function sanitizeText(value) {
   return typeof value === "string" ? value.trim() : "";
 }
 
-function asNumber(value, fallback = 0) {
-  const numeric = Number(value);
-  return Number.isFinite(numeric) ? numeric : fallback;
-}
-
 function toHostStatusLines(snapshot) {
   const network = toNetworkSnapshot(snapshot, NETWORK_SAMPLE_KEY);
   const summary = asObject(network.summary);

games/network_sample_c/debug/networkSampleCDebug.js

@@ -8,6 +8,7 @@ networkSampleCDebug.js
 import { createNetworkDebugPluginDefinition } from "../../../engine/debug/network/index.js";
 import { asArray, asObject } from "../../../src/engine/debug/inspectors/shared/inspectorUtils.js";
 import {
+  asNumber,
   commandLinesForTrace,
   getCommandSnapshot,
   toNetworkSnapshot
@@ -19,11 +20,6 @@ function sanitizeText(value) {
   return typeof value === "string" ? value.trim() : "";
 }
 
-function asNumber(value, fallback = 0) {
-  const numeric = Number(value);
-  return Number.isFinite(numeric) ? numeric : fallback;
-}
-
 function formatEntityLine(entity, options = {}) {
   const source = asObject(entity);
   const limit = Number.isFinite(Number(options.labelLimit))

src/shared/utils/networkDebugUtils.js

@@ -14,30 +14,35 @@ function toSafeKey(value) {
   return sanitizeText(value);
 }
 
-export function toNetworkSnapshot(snapshot, sampleKey) {
+export function asNumber(value, fallback = 0) {
+  const numeric = Number(value);
+  return Number.isFinite(numeric) ? numeric : fallback;
+}
+
+export function toNetworkSnapshot(snapshot) {
+  const sampleKey = arguments[1];
   const key = toSafeKey(sampleKey);
   if (!key) {
     return {};
   }
   return asObject(snapshot?.assets?.[key]);
 }
 
-export function getCommandSnapshot(context, sampleKey) {
+export function getCommandSnapshot(context) {
+  const sampleKey = arguments[1];
   const key = toSafeKey(sampleKey);
   if (!key) {
     return {};
   }
   return asObject(context?.assets?.[key]);
 }
 
-export function commandLinesForTrace(context, args = [], options = {}) {
+export function commandLinesForTrace(context, args = []) {
+  const options = asObject(arguments[2]);
   const sanitize = typeof options?.sanitizeText === "function" ? options.sanitizeText : sanitizeText;
   const formatNumber = typeof options?.formatNumber === "function"
     ? options.formatNumber
-    : (value, fallback = 0) => {
-      const numeric = Number(value);
-      return Number.isFinite(numeric) ? numeric : fallback;
-    };
+    : asNumber;
 
   const snapshot = getCommandSnapshot(context, options?.sampleKey);
   const trace = asObject(snapshot.trace);