Write back updated workspace manifests and load Asteroids assets from manifest - PR_26126_118-workspace-manifest-session-writeback-and-vector-map

Author: DavidQ

docs/dev/reports/PR_26126_118_asteroids_asset_loading_notes.txt

@@ -0,0 +1,14 @@
+PR_26126_118 Asteroids Asset Loading Notes
+
+Scope:
+- Asteroids managed assets are loaded from games/Asteroids/game.manifest.json.
+- No Asteroids asset registry entries are constructed or injected by Workspace Manager V2 or Asset Manager V2 runtime code in this PR.
+
+Behavior:
+- Workspace Manager V2 reports the manifest asset count from tools.asset-manager-v2.assets.
+- If the Asteroids manifest asset map is empty, Workspace Manager V2 logs a visible Status warning and keeps the asset count at 0.
+- Empty Asteroids assets do not silently fall back to hardcoded asset entries.
+
+Validation:
+- npm run test:workspace-v2 passed.
+- Workspace Manager V2 Playwright coverage intercepts games/Asteroids/game.manifest.json with an empty assets map and validates the Status warning plus 0 managed assets.

docs/dev/reports/PR_26126_118_manifest_writeback_notes.txt

@@ -0,0 +1,15 @@
+PR_26126_118 Manifest Writeback Notes
+
+Scope:
+- Workspace Manager V2 now tracks the active session hostContextId after launching or restoring a workspace session.
+- Workspace Manager V2 Save/export refreshes from that active session before validating and downloading the workspace manifest.
+- Asset Manager V2 writes validated asset add, update, delete, undo, redo, import, and return-to-workspace state back into the Workspace Manager V2 session manifest.
+
+Behavior:
+- Save/export uses the latest session manifest when Asset Manager V2 has changed tools.asset-manager-v2.assets.
+- Manual game selection without an active session still saves the loaded game manifest.
+- Session writeback preserves the existing workspace manifest wrapper and only replaces tools.asset-manager-v2.assets.
+
+Validation:
+- npm run test:workspace-v2 passed.
+- Asset Manager V2 Playwright coverage validates a tool-updated session manifest returns to Workspace Manager V2 and Save/export includes the new session assets.

docs/dev/reports/PR_26126_118_manual_validation_notes.txt

@@ -0,0 +1,15 @@
+PR_26126_118 Manual Validation Notes
+
+Validation command:
+- npm run test:workspace-v2
+
+Result:
+- PASS: 21 Playwright tests passed in the workspace-v2 gate.
+- PASS: git diff --check completed without whitespace errors.
+
+Manual review checklist:
+- Confirmed games/Asteroids/game.manifest.json remains valid JSON after adding tools.vector-map-editor.
+- Confirmed deprecated tools/workspace-v2 was not modified.
+- Confirmed sample JSON files were not modified.
+- Confirmed no mp4 or mkv files were modified or added.
+- Confirmed Asset Manager V2 direct ?workspace=prod remains blocked by launch guard coverage.

docs/dev/reports/PR_26126_118_vector_map_manifest_notes.txt

@@ -0,0 +1,16 @@
+PR_26126_118 Vector Map Manifest Notes
+
+Scope:
+- The Asteroids vector map reference now lives in games/Asteroids/game.manifest.json under tools.vector-map-editor.
+- The payload uses the existing tools/schemas/tools/vector-map-editor.schema.json structure with a vectorMapDocument root.
+- Workspace Manager V2 loads the vector map entry as part of the game manifest context.
+
+Manifest entry:
+- tools.vector-map-editor.vectorMapDocument.schema = html-js-gaming.vector-map
+- tools.vector-map-editor.vectorMapDocument.source = manifest
+- tools.vector-map-editor.vectorMapDocument.assetsPath = games/Asteroids/assets
+- Included vector IDs: vector.asteroids.ship, vector.asteroids.asteroid.large, vector.asteroids.asteroid.medium, vector.asteroids.asteroid.small, vector.asteroids.ui.title.
+
+Validation:
+- npm run test:workspace-v2 passed.
+- Workspace Manager V2 Playwright coverage validates vector-map-editor is present in the manifest context, saved export, and session context.

games/Asteroids/game.manifest.json

@@ -175,6 +175,69 @@
           }
         }
       }
+    },
+    "vector-map-editor": {
+      "vectorMapDocument": {
+        "schema": "html-js-gaming.vector-map",
+        "version": 1,
+        "name": "Asteroids Vector Map",
+        "source": "manifest",
+        "assetsPath": "games/Asteroids/assets",
+        "vectors": [
+          {
+            "id": "vector.asteroids.ship",
+            "label": "Ship",
+            "viewBox": "-24 -24 48 48",
+            "paths": [
+              "M 0 -18 L 14 16 L 0 8 L -14 16 Z",
+              "M -6 14 L 0 6 L 6 14"
+            ],
+            "stroke": true,
+            "fill": false
+          },
+          {
+            "id": "vector.asteroids.asteroid.large",
+            "label": "Large Asteroid",
+            "viewBox": "-40 -40 80 80",
+            "paths": [
+              "M -28 -12 L -10 -30 L 20 -26 L 32 -8 L 26 18 L 6 32 L -22 24 L -34 2 Z"
+            ],
+            "stroke": true,
+            "fill": false
+          },
+          {
+            "id": "vector.asteroids.asteroid.medium",
+            "label": "Medium Asteroid",
+            "viewBox": "-28 -28 56 56",
+            "paths": [
+              "M -16 -10 L -2 -18 L 16 -14 L 20 2 L 8 18 L -10 16 L -20 4 Z"
+            ],
+            "stroke": true,
+            "fill": false
+          },
+          {
+            "id": "vector.asteroids.asteroid.small",
+            "label": "Small Asteroid",
+            "viewBox": "-18 -18 36 36",
+            "paths": [
+              "M -10 -6 L 0 -12 L 10 -6 L 8 8 L -6 10 L -12 0 Z"
+            ],
+            "stroke": true,
+            "fill": false
+          },
+          {
+            "id": "vector.asteroids.ui.title",
+            "label": "Asteroids Title",
+            "viewBox": "0 0 220 48",
+            "paths": [
+              "M 6 40 L 24 6 L 42 40 Z",
+              "M 58 40 L 58 8 L 88 8 L 88 18 L 70 18 L 70 22 L 86 22 L 86 32 L 70 32 L 70 40 Z"
+            ],
+            "stroke": true,
+            "fill": false
+          }
+        ]
+      }
     }
   }
 }

tests/playwright/tools/AssetManagerV2.spec.mjs

@@ -1282,6 +1282,8 @@ test.describe("Asset Manager V2", () => {
       await expect(page.locator("#workspaceContextOutput")).toContainText('"gameRoot": "games/Asteroids/"');
       await expect(page.locator("#workspaceContextOutput")).toContainText('"assetsPath": "games/Asteroids/assets"');
       await expect(page.locator("#workspaceContextOutput")).toContainText('"asset-manager-v2"');
+      await expect(page.locator("#workspaceContextOutput")).toContainText('"vector-map-editor"');
+      await expect(page.locator("#workspaceContextOutput")).toContainText('"vector.asteroids.ship"');
       await expect(page.locator("#workspaceContextOutput")).not.toContainText('"activePalette"');
       await expect(page.locator("#workspaceContextOutput")).not.toContainText('"workspaceManifest"');
       await expect(page.locator("#launchAssetManagerV2Button")).toBeEnabled();
@@ -1401,6 +1403,7 @@ test.describe("Asset Manager V2", () => {
       await expect(page.locator("#inspectorOutput")).toContainText("\"type\": \"color\"");
       await expect(page.locator("#inspectorOutput")).toContainText("\"kind\": \"hex\"");
       await expect(page.locator("#inspectorOutput")).toContainText("\"name\": \"HUD Blue\"");
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Workspace Manager V2 session manifest now has 17 validated assets\./);
 
       const storedContext = await page.evaluate((id) => JSON.parse(sessionStorage.getItem(id)), hostContextId);
       expect(storedContext.documentKind).toBe("workspace-manifest");
@@ -1409,24 +1412,67 @@ test.describe("Asset Manager V2", () => {
       expect(storedContext.workspaceManifest).toBeUndefined();
       expect(storedContext.tools["asset-browser"]).toBeUndefined();
       expect(storedContext.tools["palette-browser"]).toBeUndefined();
-      expect(Object.keys(storedContext.tools["asset-manager-v2"].assets)).toHaveLength(13);
+      expect(Object.keys(storedContext.tools["asset-manager-v2"].assets)).toHaveLength(17);
       expect(storedContext.tools["asset-manager-v2"].assets["assets.audio.sound.fire"]).toEqual({
         path: "assets/audio/fire.wav",
         type: "audio",
         kind: "wav",
         role: "sound",
         source: "manifest"
       });
-      expect(storedContext.tools["asset-manager-v2"].assets["assets.audio.sound.laser"]).toBeUndefined();
+      expect(storedContext.tools["asset-manager-v2"].assets["assets.audio.sound.laser"]).toEqual({
+        path: "assets/audio/laser.wav",
+        type: "audio",
+        kind: "wav",
+        role: "sound",
+        source: "asset-manager-v2"
+      });
+      expect(storedContext.tools["asset-manager-v2"].assets["assets.font.ui.score"]).toEqual({
+        path: "assets/fonts/score.ttf",
+        type: "font",
+        kind: "ttf",
+        role: "ui",
+        source: "asset-manager-v2"
+      });
+      expect(storedContext.tools["asset-manager-v2"].assets["assets.image.sprite.preview"]).toEqual({
+        path: "assets/images/preview.png",
+        type: "image",
+        kind: "png",
+        role: "sprite",
+        source: "asset-manager-v2"
+      });
+      expect(storedContext.tools["asset-manager-v2"].assets["assets.color.hud.primary-hud.hud-blue"]).toEqual({
+        path: "palette://workspace/hud-blue",
+        type: "color",
+        kind: "hex",
+        role: "hud",
+        source: "asset-manager-v2",
+        color: {
+          hex: "#78B7FF",
+          name: "HUD Blue",
+          symbol: "*"
+        }
+      });
       expect(storedContext.tools["palette-manager-v2"].source).toBe("manifest");
       expect(storedContext.tools["palette-manager-v2"].swatches.length).toBeGreaterThan(0);
+      expect(storedContext.tools["vector-map-editor"].vectorMapDocument.vectors.map((vector) => vector.id)).toContain("vector.asteroids.ship");
       expect(storedContext.tools["workspace-v2"]).toBeUndefined();
-      expect(Object.keys(storedContext.tools).sort()).toEqual(["asset-manager-v2", "palette-manager-v2"]);
+      expect(Object.keys(storedContext.tools).sort()).toEqual(["asset-manager-v2", "palette-manager-v2", "vector-map-editor"]);
       await page.locator("#returnToWorkspaceButton").click();
       await expect(page).toHaveURL(/workspace-manager-v2\/index\.html\?hostContextId=workspace-manager-v2-/);
       await expect(page.locator("#activeGameSelect")).toHaveValue("Asteroids");
-      await expect(page.locator("#activeAssetRegistrySummary")).toHaveText("Schema-ready Asset Manager V2 manifest payload contains 13 managed assets.");
+      await expect(page.locator("#activeAssetRegistrySummary")).toHaveText("Schema-ready Asset Manager V2 manifest payload contains 17 managed assets.");
       await expect(page.locator("#launchAssetManagerV2Button")).toBeEnabled();
+      await expect(page.locator("#saveWorkspaceManifestButton")).toBeEnabled();
+      const downloadPromise = page.waitForEvent("download");
+      await page.locator("#saveWorkspaceManifestButton").click();
+      const download = await downloadPromise;
+      expect(download.suggestedFilename()).toBe("workspace-manager-v2-Asteroids.workspace.manifest.json");
+      const savedManifest = JSON.parse(await readFile(await download.path(), "utf8"));
+      expect(Object.keys(savedManifest.tools["asset-manager-v2"].assets)).toHaveLength(17);
+      expect(savedManifest.tools["asset-manager-v2"].assets["assets.audio.sound.laser"]).toEqual(storedContext.tools["asset-manager-v2"].assets["assets.audio.sound.laser"]);
+      expect(savedManifest.tools["asset-manager-v2"].assets["assets.color.hud.primary-hud.hud-blue"]).toEqual(storedContext.tools["asset-manager-v2"].assets["assets.color.hud.primary-hud.hud-blue"]);
+      expect(savedManifest.tools["vector-map-editor"].vectorMapDocument.vectors.map((vector) => vector.id)).toContain("vector.asteroids.ship");
 
       expect(pageErrors).toEqual([]);
     } finally {

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -155,6 +155,8 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#workspaceContextOutput")).toContainText('"source": "manifest"');
       await expect(page.locator("#workspaceContextOutput")).toContainText('"asset-manager-v2"');
       await expect(page.locator("#workspaceContextOutput")).toContainText('"palette-manager-v2"');
+      await expect(page.locator("#workspaceContextOutput")).toContainText('"vector-map-editor"');
+      await expect(page.locator("#workspaceContextOutput")).toContainText('"vector.asteroids.ship"');
       await expect(page.locator("#workspaceContextOutput")).not.toContainText('"palette-browser"');
       await expect(page.locator("#workspaceContextOutput")).not.toContainText('"asset-browser"');
       await expect(page.locator("#workspaceContextOutput")).not.toContainText('"activePalette"');
@@ -174,11 +176,12 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       const asteroidsManifest = await page.evaluate(async () => await fetch("/games/Asteroids/game.manifest.json", { cache: "no-store" }).then((response) => response.json()));
       expect(savedManifest).toEqual(asteroidsManifest);
       expect(savedManifest.documentKind).toBe("workspace-manifest");
-      expect(Object.keys(savedManifest.tools).sort()).toEqual(["asset-manager-v2", "palette-manager-v2"]);
+      expect(Object.keys(savedManifest.tools).sort()).toEqual(["asset-manager-v2", "palette-manager-v2", "vector-map-editor"]);
       expect(savedManifest.tools["palette-manager-v2"].swatches.length).toBeGreaterThan(0);
       expect(Object.keys(savedManifest.tools["asset-manager-v2"].assets)).toHaveLength(13);
       expect(savedManifest.tools["asset-manager-v2"].source).toBe("manifest");
       expect(savedManifest.tools["asset-manager-v2"].schema).toBe("html-js-gaming.asset-manager-v2");
+      expect(savedManifest.tools["vector-map-editor"].vectorMapDocument.vectors.map((vector) => vector.id)).toContain("vector.asteroids.ship");
       await expect(page.locator("#statusLog")).toHaveValue(/OK Saved schema-valid Workspace Manager V2 manifest workspace-manager-v2-Asteroids\./);
 
       await page.locator("#launchAssetManagerV2Button").click();
@@ -221,6 +224,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       expect(storedContext.assetsPath).toBe("games/Asteroids/assets");
       expect(storedContext.tools["palette-manager-v2"].swatches.length).toBeGreaterThan(0);
       expect(Object.keys(storedContext.tools["asset-manager-v2"].assets)).toHaveLength(13);
+      expect(storedContext.tools["vector-map-editor"].vectorMapDocument.vectors.map((vector) => vector.id)).toContain("vector.asteroids.ship");
       expect(storedContext.tools["asset-manager-v2"].assets["assets.font.ui.vector-battle"]).toEqual({
         path: "assets/fonts/vector_battle.ttf",
         type: "font",
@@ -233,15 +237,17 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       expect(storedContext.tools["palette-browser"]).toBeUndefined();
       expect(storedContext.tools["asset-manager-v2"].schema).toBe("html-js-gaming.asset-manager-v2");
       const schemaValidation = await page.evaluate(async () => {
-        const [workspaceSchema, paletteSchema, assetSchema] = await Promise.all([
+        const [workspaceSchema, paletteSchema, assetSchema, vectorMapSchema] = await Promise.all([
           fetch("/tools/schemas/workspace.manifest.schema.json", { cache: "no-store" }).then((response) => response.json()),
           fetch("/tools/schemas/tools/palette-manager-v2.schema.json", { cache: "no-store" }).then((response) => response.json()),
-          fetch("/tools/schemas/tools/asset-manager-v2.schema.json", { cache: "no-store" }).then((response) => response.json())
+          fetch("/tools/schemas/tools/asset-manager-v2.schema.json", { cache: "no-store" }).then((response) => response.json()),
+          fetch("/tools/schemas/tools/vector-map-editor.schema.json", { cache: "no-store" }).then((response) => response.json())
         ]);
         const url = new URL(window.location.href);
         const manifest = JSON.parse(sessionStorage.getItem(url.searchParams.get("hostContextId")));
         const palettePayload = manifest.tools["palette-manager-v2"];
         const assetPayload = manifest.tools["asset-manager-v2"];
+        const vectorPayload = manifest.tools["vector-map-editor"];
         const extraKeys = (value, schema) => Object.keys(value).filter((key) => !Object.hasOwn(schema.properties || {}, key));
         const missingKeys = (value, schema) => (schema.required || []).filter((key) => !Object.hasOwn(value, key));
         const swatchExtraKeys = palettePayload.swatches.flatMap((swatch, index) => (
@@ -260,7 +266,10 @@ test.describe("Workspace Manager V2 bootstrap", () => {
           swatchExtraKeys,
           swatchMissingKeys,
           toolKeys: Object.keys(manifest.tools).sort(),
-          unsupportedToolKeys: Object.keys(manifest.tools).filter((key) => !Object.hasOwn(workspaceSchema.properties.tools.properties, key))
+          unsupportedToolKeys: Object.keys(manifest.tools).filter((key) => !Object.hasOwn(workspaceSchema.properties.tools.properties, key)),
+          vectorExtraKeys: extraKeys(vectorPayload, vectorMapSchema),
+          vectorMissingKeys: missingKeys(vectorPayload, vectorMapSchema),
+          vectorIds: vectorPayload.vectorMapDocument.vectors.map((vector) => vector.id)
         };
       });
       expect(schemaValidation).toEqual({
@@ -272,8 +281,17 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         paletteMissingKeys: [],
         swatchExtraKeys: [],
         swatchMissingKeys: [],
-        toolKeys: ["asset-manager-v2", "palette-manager-v2"],
-        unsupportedToolKeys: []
+        toolKeys: ["asset-manager-v2", "palette-manager-v2", "vector-map-editor"],
+        unsupportedToolKeys: [],
+        vectorExtraKeys: [],
+        vectorIds: [
+          "vector.asteroids.ship",
+          "vector.asteroids.asteroid.large",
+          "vector.asteroids.asteroid.medium",
+          "vector.asteroids.asteroid.small",
+          "vector.asteroids.ui.title"
+        ],
+        vectorMissingKeys: []
       });
       expect(JSON.stringify(storedContext)).not.toMatch(/samples\//i);
       await page.locator("#returnToWorkspaceButton").click();
@@ -313,6 +331,40 @@ test.describe("Workspace Manager V2 bootstrap", () => {
     }
   });
 
+  test("warns instead of injecting hardcoded Asteroids assets when manifest assets are empty", async ({ page }) => {
+    const server = await startRepoServer();
+    const pageErrors = [];
+    const asteroidsManifest = JSON.parse(await readFile("games/Asteroids/game.manifest.json", "utf8"));
+    asteroidsManifest.tools["asset-manager-v2"].assets = {};
+
+    page.on("pageerror", (error) => {
+      pageErrors.push(error.message);
+    });
+
+    await page.route("**/games/Asteroids/game.manifest.json", async (route) => {
+      await route.fulfill({
+        body: JSON.stringify(asteroidsManifest),
+        contentType: "application/json",
+        status: 200
+      });
+    });
+    await coverageReporter.start(page);
+    await page.goto(`${server.baseUrl}/tools/workspace-manager-v2/index.html`, { waitUntil: "networkidle" });
+
+    try {
+      await page.locator("#activeGameSelect").selectOption("Asteroids");
+      await expect(page.locator("#activeAssetRegistrySummary")).toHaveText("Schema-ready Asset Manager V2 manifest payload contains 0 managed assets.");
+      await expect(page.locator("#workspaceContextOutput")).toContainText('"assets": {}');
+      await expect(page.locator("#workspaceContextOutput")).toContainText('"vector-map-editor"');
+      await expect(page.locator("#statusLog")).toHaveValue(/INFO Warning: \/games\/Asteroids\/game\.manifest\.json has no Asteroids Asset Manager V2 assets; Workspace Manager V2 did not inject hardcoded assets\./);
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Loaded Asteroids from \/games\/Asteroids\/game\.manifest\.json with 11 active palette colors and 0 managed assets\./);
+      expect(pageErrors).toEqual([]);
+    } finally {
+      await coverageReporter.stop(page);
+      await server.close();
+    }
+  });
+
   test("keeps direct Asset Manager V2 workspace prod launch blocked", async ({ page }) => {
     const server = await openAssetManagerV2(page, "?workspace=prod");
     const pageErrors = [];