Remove deprecated Workspace V2 and fix Workspace Manager status clear behavior - PR_26127_011-workspace-v2-cleanup-and-status-clear-fix

Author: DavidQ

docs/dev/reports/PR_26127_011-workspace-v2-cleanup-and-status-clear-fix.md

@@ -0,0 +1,22 @@
+# PR_26127_011-workspace-v2-cleanup-and-status-clear-fix
+
+## Summary
+- Deleted deprecated `tools/workspace-v2` files and removed the empty directory from the working tree.
+- Updated the Workspace V2 validation gate to run Workspace Manager V2 coverage only.
+- Removed legacy Workspace V2 coverage/report registration.
+- Removed the Workspace Manager V2 `Load Asteroids` menu control and action wiring.
+- Fixed Status `Clear` so it clears only log content and does not toggle the accordion.
+- Kept Workspace JSON copy button label as `copy`.
+- Preserved Pong and Gravity Well manifest cleanup; `assets.image.background.preview` was not re-added.
+
+## Validation
+- PASS: `npm run test:workspace-v2`
+- PASS: Confirmed `tools/workspace-v2` no longer exists.
+- PASS: Confirmed no Playwright/package/tool references launch or validate deprecated `tools/workspace-v2`.
+- PASS: Confirmed sample JSON files were not modified.
+- SKIPPED: Full samples smoke test, per Workspace V2 cleanup scope.
+
+## Notes
+- `test:workspace-v2` now targets `tests/playwright/tools/WorkspaceManagerV2.spec.mjs` as the Workspace Manager V2 gate.
+- Gravity Well and Pong manifest tests now assert the current single preview asset state and explicitly verify `assets.image.background.preview` remains absent.
+- Status `Clear` now stops event propagation before clearing the log textarea, keeping the accordion expanded/collapsed state unchanged.

docs/dev/workspace_v2_playwright_gate.md

@@ -1,12 +1,12 @@
-# Workspace V2 Playwright Validation Gate
+# Workspace Manager V2 Playwright Validation Gate
 
-Use this gate for repeatable local validation of Workspace V2 UI behavior.
+Use this gate for repeatable local validation of Workspace Manager V2 UI behavior.
 
 ## Command
 - `npm run test:workspace-v2`
 
 ## What It Runs
-- Executes the installed Playwright UI regression command for Workspace V2.
+- Executes the installed Playwright UI regression command for Workspace Manager V2.
 - Fails fast and returns a non-zero exit code on any test failure.
 
 ## Output Paths
@@ -26,5 +26,5 @@ Use this gate for repeatable local validation of Workspace V2 UI behavior.
   - CI/local gate should treat this as a hard failure
 
 ## Smoke Test Policy
-- For Workspace V2 gate-only PRs, full samples smoke test should be skipped.
+- For Workspace Manager V2 gate-only PRs, full samples smoke test should be skipped.
 - Run full samples smoke only when shared sample framework/runtime is changed.

package.json

@@ -14,7 +14,7 @@
     "codex:review-artifacts": "node ./scripts/write-codex-review-artifacts.mjs",
     "test:asset-manager-v2": "playwright test tests/playwright/tools/AssetManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list",
     "test:preview-generator-v2": "playwright test tests/playwright/tools/PreviewGeneratorV2Baseline.spec.mjs --project=playwright --workers=1 --reporter=list",
-    "test:workspace-v2": "playwright test tests/playwright/tools/AssetManagerV2.spec.mjs tests/playwright/tools/PreviewGeneratorV2Baseline.spec.mjs tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list",
+    "test:workspace-v2": "playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list",
     "test:launch-smoke": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs",
     "test:launch-smoke:games": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --games",
     "test:workspace-manager:games": "node ./tests/runtime/GamesIndexWorkspaceManagerOpen.test.mjs",

tests/helpers/playwrightV8CoverageReporter.mjs

@@ -326,7 +326,6 @@ export class PlaywrightV8CoverageReporter {
       { name: "Asset Manager V2", prefix: "tools/asset-manager-v2/" },
       { name: "Palette Manager V2", prefix: "tools/palette-manager-v2/" },
       { name: "Tool Template V2", prefix: "tools/templates-v2/" },
-      { name: "Workspace V2", prefix: "tools/workspace-v2/" },
       { name: "Workspace Manager V2", prefix: "tools/workspace-manager-v2/" },
       { name: "Workspace Manager", prefix: "tools/workspace-manager/" }
     ];

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -166,18 +166,26 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#importManifestButton")).toHaveText("Import Manifest");
       await expect(page.locator("#exportManifestButton")).toBeDisabled();
       await expect(page.locator("#seedUatManifestButton")).toBeHidden();
-      await expect(page.locator("#loadAsteroidsButton")).toHaveText("Load Asteroids");
+      await expect(page.locator("#loadAsteroidsButton")).toHaveCount(0);
       await expect(page.locator("#launchAssetManagerV2Button")).toHaveCount(0);
       await expect(page.locator("#workspaceToolsContent #workspaceToolTiles")).toBeVisible();
       await expect(page.locator("#workspaceContextContent")).toHaveCount(0);
       await expect(page.locator("#workspaceJsonContent #workspaceContextOutput")).toBeVisible();
-      await expect(page.locator("#copyWorkspaceJsonButton")).toHaveText("[copy]");
+      await expect(page.locator("#copyWorkspaceJsonButton")).toHaveText("copy");
       const centerControlLabels = await page.locator(".workspace-manager-v2__panel--center > .accordion-v2 > .accordion-v2__header > span:first-child")
         .evaluateAll((labels) => labels.map((label) => label.textContent.trim()));
       expect(centerControlLabels).toEqual(["Tools", "Workspace JSON"]);
       await expect(page.locator(".workspace-manager-v2__status-accordion-header")).toContainText("Status");
       const statusHeaderOrder = await page.locator(".workspace-manager-v2__status-accordion-header").evaluate((header) => Array.from(header.querySelectorAll(":scope > span, :scope > div > span, :scope > div > button"), (element) => element.textContent.trim()));
       expect(statusHeaderOrder).toEqual(["Status", "+", "Clear"]);
+      const statusHeader = page.locator('.workspace-manager-v2__status-accordion-header[aria-controls="statusLogContent"]');
+      const statusContent = page.locator("#statusLogContent");
+      await expect(statusHeader).toHaveAttribute("aria-expanded", "true");
+      await expect(statusContent).toBeVisible();
+      await page.locator("#clearStatusButton").click();
+      await expect(page.locator("#statusLog")).toHaveValue("");
+      await expect(statusHeader).toHaveAttribute("aria-expanded", "true");
+      await expect(statusContent).toBeVisible();
       await expect(page.locator(".workspace-manager-v2__tool-group-title")).toHaveText(["Editors", "Utilities", "Viewers"]);
       await expect(page.locator("#workspaceToolTiles [data-workspace-tool-id]")).toHaveCount(4);
       await expect(page.locator('[data-workspace-tool-id="workspace-manager-v2"]')).toHaveCount(0);
@@ -607,10 +615,10 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#activeGameSummary")).toContainText("games/GravityWell/");
       await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"gameRoot": "games\/GravityWell\/"/);
       await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"assetsPath": "games\/GravityWell\/assets"/);
-      await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"assets.image.background.preview"/);
       await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"assets.image.preview.preview"/);
+      await expect(page.locator("#workspaceContextOutput")).not.toHaveValue(/"assets.image.background.preview"/);
       await expect(page.locator("#workspaceContextOutput")).not.toHaveValue(/"asset-browser"|"palette-browser"|"vector-map-editor"/);
-      await expect(page.locator('[data-workspace-tool-id="asset-manager-v2"]')).toContainText("2 managed assets");
+      await expect(page.locator('[data-workspace-tool-id="asset-manager-v2"]')).toContainText("1 managed assets");
       await expect(page.locator('[data-workspace-tool-id="palette-manager-v2"]')).toContainText("10 palette swatches");
       const gravityManifest = JSON.parse(await page.locator("#workspaceContextOutput").inputValue());
       expect(Object.keys(gravityManifest.tools).sort()).toEqual(["asset-manager-v2", "palette-manager-v2"]);
@@ -621,25 +629,16 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         role: "preview",
         source: "manifest"
       });
-      expect(gravityManifest.tools["asset-manager-v2"].assets["assets.image.background.preview"]).toEqual({
-        path: "assets/images/preview.svg",
-        type: "image",
-        kind: "svg",
-        role: "background",
-        source: "manifest",
-        stretchOverride: {
-          uniformEdgeStretchPx: 0
-        }
-      });
+      expect(gravityManifest.tools["asset-manager-v2"].assets["assets.image.background.preview"]).toBeUndefined();
 
       await page.locator("#activeGameSelect").selectOption("Pong");
       await expect(page.locator("#activeGameSummary")).toContainText("games/Pong/");
       await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"gameRoot": "games\/Pong\/"/);
       await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"assetsPath": "games\/Pong\/assets"/);
-      await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"assets.image.background.preview"/);
       await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"assets.image.preview.preview"/);
+      await expect(page.locator("#workspaceContextOutput")).not.toHaveValue(/"assets.image.background.preview"/);
       await expect(page.locator("#workspaceContextOutput")).not.toHaveValue(/"asset-browser"|"palette-browser"|"vector-map-editor"/);
-      await expect(page.locator('[data-workspace-tool-id="asset-manager-v2"]')).toContainText("2 managed assets");
+      await expect(page.locator('[data-workspace-tool-id="asset-manager-v2"]')).toContainText("1 managed assets");
       await expect(page.locator('[data-workspace-tool-id="palette-manager-v2"]')).toContainText("8 palette swatches");
       const pongManifest = JSON.parse(await page.locator("#workspaceContextOutput").inputValue());
       expect(Object.keys(pongManifest.tools).sort()).toEqual(["asset-manager-v2", "palette-manager-v2"]);
@@ -650,16 +649,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         role: "preview",
         source: "manifest"
       });
-      expect(pongManifest.tools["asset-manager-v2"].assets["assets.image.background.preview"]).toEqual({
-        path: "assets/images/preview.svg",
-        type: "image",
-        kind: "svg",
-        role: "background",
-        source: "manifest",
-        stretchOverride: {
-          uniformEdgeStretchPx: 0
-        }
-      });
+      expect(pongManifest.tools["asset-manager-v2"].assets["assets.image.background.preview"]).toBeUndefined();
 
       expect(pageErrors).toEqual([]);
     } finally {

tools/workspace-manager-v2/index.html

@@ -38,7 +38,6 @@ <h2 class="tools-platform-frame__eyebrow">Games-only launch context</h2>
       <input id="importManifestInput" type="file" accept=".json,application/json" hidden>
       <button id="exportManifestButton" type="button" disabled>Export Manifest</button>
       <button id="seedUatManifestButton" type="button" hidden>UAT</button>
-      <button id="loadAsteroidsButton" type="button">Load Asteroids</button>
     </nav>
 
     <main class="workspace-manager-v2 app-shell" data-tool-id="workspace-manager-v2">
@@ -74,7 +73,7 @@ <h2 class="tools-platform-frame__eyebrow">Games-only launch context</h2>
             <span>Workspace JSON</span>
             <span class="workspace-manager-v2__json-header-actions">
               <span class="accordion-v2__icon" aria-hidden="true">+</span>
-              <button id="copyWorkspaceJsonButton" class="workspace-manager-v2__json-copy-button" type="button">Copy</button>
+              <button id="copyWorkspaceJsonButton" class="workspace-manager-v2__json-copy-button" type="button">copy</button>
             </span>
           </div>
           <div id="workspaceJsonContent" class="accordion-v2__content">

tools/workspace-manager-v2/js/WorkspaceManagerV2App.js

@@ -38,9 +38,6 @@ export class WorkspaceManagerV2App {
       onImportManifest: (file) => {
         void this.importWorkspaceManifest(file);
       },
-      onLoadAsteroids: () => {
-        void this.selectGame("Asteroids");
-      },
       onSeedUat: () => {
         void this.seedTemporaryUatManifest();
       }

tools/workspace-manager-v2/js/bootstrap.js

@@ -27,7 +27,6 @@ window.addEventListener("DOMContentLoaded", () => {
       exportButton: requireElement("#exportManifestButton"),
       importButton: requireElement("#importManifestButton"),
       importInput: requireElement("#importManifestInput"),
-      loadAsteroidsButton: requireElement("#loadAsteroidsButton"),
       uatButton: requireElement("#seedUatManifestButton")
     }),
     statusLog: new StatusLogControl({

tools/workspace-manager-v2/js/controls/ManifestMenuControl.js

@@ -3,21 +3,18 @@ export class ManifestMenuControl {
     exportButton,
     importButton,
     importInput,
-    loadAsteroidsButton,
     uatButton
   }) {
     this.exportButton = exportButton;
     this.importButton = importButton;
     this.importInput = importInput;
-    this.loadAsteroidsButton = loadAsteroidsButton;
     this.uatButton = uatButton;
   }
 
   mount({
     isUatMode,
     onExportManifest,
     onImportManifest,
-    onLoadAsteroids,
     onSeedUat
   }) {
     this.importButton.addEventListener("click", () => {
@@ -28,7 +25,6 @@ export class ManifestMenuControl {
       onImportManifest(this.importInput.files?.[0] || null);
     });
     this.exportButton.addEventListener("click", onExportManifest);
-    this.loadAsteroidsButton.addEventListener("click", onLoadAsteroids);
     this.uatButton.addEventListener("click", onSeedUat);
     this.uatButton.hidden = !isUatMode;
   }

tools/workspace-manager-v2/js/controls/StatusLogControl.js

@@ -5,7 +5,9 @@ export class StatusLogControl {
   }
 
   mount() {
-    this.clearButton.addEventListener("click", () => {
+    this.clearButton.addEventListener("click", (event) => {
+      event.preventDefault();
+      event.stopPropagation();
       this.log.value = "";
     });
   }