Ensure Preview Generator V2 Playwright coverage and fix final test hooks - PR_26126_040-preview-generator-v2-playwright-and-final-fixes

Author: DavidQ

.gitignore

@@ -19,7 +19,7 @@ tests/results/
 tmp/
 
 # Codex files
-codex_review.diff
 codex_changed_files.txt
 docs/dev/reports/codex_changed_files.txt
+codex_review.diff
 docs/dev/reports/codex_review.diff

docs/dev/reports/codex_changed_files.txt

@@ -1,10 +1,10 @@
 # git status --short
- M docs/dev/reports/preview_generator_v2_playwright_result.txt
-?? docs/dev/reports/preview_generator_v2_final_review.txt
+ M package.json
+?? docs/dev/reports/preview_generator_v2_playwright_coverage.txt
 
-# PR_26126_039 diff stat excluding generated review artifact files
- docs/dev/reports/preview_generator_v2_playwright_result.txt | 8 ++++----
- 1 file changed, 4 insertions(+), 4 deletions(-)
-# New file diff stat: docs/dev/reports/preview_generator_v2_final_review.txt
- .../reports/preview_generator_v2_final_review.txt  | 70 ++++++++++++++++++++++
- 1 file changed, 70 insertions(+)
+# PR_26126_040 diff stat excluding generated review artifact files
+ package.json | 1 +
+ 1 file changed, 1 insertion(+)
+# New file diff stat: docs/dev/reports/preview_generator_v2_playwright_coverage.txt
+ .../preview_generator_v2_playwright_coverage.txt   | 46 ++++++++++++++++++++++
+ 1 file changed, 46 insertions(+)

docs/dev/reports/codex_review.diff

@@ -1,115 +1,69 @@
-# PR_26126_039 review diff excluding generated review artifact files
+# PR_26126_040 review diff excluding generated review artifact files
 
-diff --git a/docs/dev/reports/preview_generator_v2_playwright_result.txt b/docs/dev/reports/preview_generator_v2_playwright_result.txt
-index 99dea6f0..d9c95345 100644
---- a/docs/dev/reports/preview_generator_v2_playwright_result.txt
-+++ b/docs/dev/reports/preview_generator_v2_playwright_result.txt
-@@ -1,4 +1,4 @@
--# Preview Generator V2 Playwright Result - PR_26126_037
-+# Preview Generator V2 Playwright Result - PR_26126_039
+diff --git a/package.json b/package.json
+index 87404e4f..eae9bba5 100644
+--- a/package.json
++++ b/package.json
+@@ -12,6 +12,7 @@
+     "check:style-system-guard": "node tools/dev/checkStyleSystemGuard.mjs",
+     "check:games-template-contract": "node ./scripts/validate-games-template-contract.mjs",
+     "codex:review-artifacts": "node ./scripts/write-codex-review-artifacts.mjs",
++    "test:workspace-v2": "playwright test tests/playwright/PreviewGeneratorV2Baseline.spec.mjs --project=playwright --reporter=list",
+     "test:launch-smoke": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs",
+     "test:launch-smoke:games": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --games",
+     "test:workspace-manager:games": "node ./tests/runtime/GamesIndexWorkspaceManagerOpen.test.mjs",
 
- Coverage:
- - tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
-@@ -6,15 +6,15 @@ Coverage:
- What the test validates:
- - Preview Generator V2 launches from /tools/preview-generator-v2/index.html through the repo HTTP server.
- - The Preview Generator V2 app shell is visible.
-+- tools/common/toolShellCommon.css is loaded.
- - The Preview Generator V2 heading is visible.
- - menuSample nav exists.
- - Generate Preview and Stop buttons are visible and initially disabled.
- - Games is the default target source.
- - Paths or IDs input is visible.
- - Status block is visible.
--- Repo Destination accordion collapses and reopens with aria-expanded state changes.
--- tools/common/toolShellCommon.css is loaded.
- - Consolidated common style declarations are applied to header, accordion, app shell, and fullscreen layout targets.
-+- Repo Destination accordion collapses and reopens with aria-expanded state changes.
- - No page errors are emitted during the launch/toggle path.
+# git diff --no-index -- /dev/null docs/dev/reports/preview_generator_v2_playwright_coverage.txt
 
- Command run:
-@@ -32,4 +32,4 @@ Workspace V2 default command:
- - Result: FAIL, package.json does not define a test:workspace-v2 script.
-
- Full samples smoke test:
--- Skipped. This PR modifies Preview Generator V2 CSS structure and targeted Playwright coverage only; it does not modify samples or shared sample loading.
-+- Skipped. This PR is a Preview Generator V2 final hardening review pass and does not modify samples or shared sample loading.
-
-# git diff --no-index -- /dev/null docs/dev/reports/preview_generator_v2_final_review.txt
-
-diff --git a/docs/dev/reports/preview_generator_v2_final_review.txt b/docs/dev/reports/preview_generator_v2_final_review.txt
+diff --git a/docs/dev/reports/preview_generator_v2_playwright_coverage.txt b/docs/dev/reports/preview_generator_v2_playwright_coverage.txt
 new file mode 100644
-index 00000000..877676b5
+index 00000000..eb21a728
 --- /dev/null
-+++ b/docs/dev/reports/preview_generator_v2_final_review.txt
-@@ -0,0 +1,70 @@
-+# Preview Generator V2 Final Review - PR_26126_039
++++ b/docs/dev/reports/preview_generator_v2_playwright_coverage.txt
+@@ -0,0 +1,46 @@
++# Preview Generator V2 Playwright Coverage - PR_26126_040
 +
-+Scope:
-+- tools/preview-generator-v2/*
-+- tools/common/toolShellCommon.css
++Reviewed:
++- docs/dev/reports/preview_generator_v2_playwright_result.txt
 +- tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
++- package.json
 +
-+Result:
-+- PASS: No Preview Generator V2 code changes were required.
-+- PASS: Existing behavior was preserved.
-+- PASS: No samples were modified.
-+- PASS: No schema was added or modified.
-+- PASS: No start_of_day folders were modified.
-+- PASS: No unintended files were changed before report generation.
-+
-+Structure checks:
-+- PASS: One class per Preview Generator V2 JavaScript file remains true.
-+- PASS: previewGeneratorV2.bootstrap.js remains bootstrap-only and has no class.
-+- PASS: index.html has no inline style blocks.
-+- PASS: index.html has no inline script blocks.
-+- PASS: No tools/shared dependencies exist.
-+- PASS: Legacy tools/preview folder is absent.
++Coverage decision:
++- Preview Generator V2 is already explicitly covered by Playwright.
++- No duplicate Playwright test was added.
 +
-+Core class files:
-+- tools/preview-generator-v2/PreviewGeneratorV2App.js - PreviewGeneratorV2App
-+- tools/preview-generator-v2/PreviewGeneratorV2Capture.js - PreviewGeneratorV2Capture
-+- tools/preview-generator-v2/PreviewGeneratorV2Logger.js - PreviewGeneratorV2Logger
-+- tools/preview-generator-v2/PreviewGeneratorV2RepoAccess.js - PreviewGeneratorV2RepoAccess
-+- tools/preview-generator-v2/PreviewGeneratorV2ShellControl.js - PreviewGeneratorV2ShellControl
-+- tools/preview-generator-v2/PreviewGeneratorV2Ui.js - PreviewGeneratorV2Ui
-+- tools/preview-generator-v2/previewGeneratorV2.bootstrap.js - bootstrap wiring only
++Existing Playwright coverage:
++- Launches tools/preview-generator-v2/index.html through the repo HTTP server.
++- Verifies the Preview Generator V2 app shell is visible.
++- Verifies tools/common/toolShellCommon.css is loaded.
++- Verifies the Preview Generator V2 heading is visible.
++- Verifies menuSample nav exists.
++- Verifies Generate Preview and Stop render and begin disabled.
++- Verifies Games is the default target source.
++- Verifies Paths or IDs input is visible.
++- Verifies Status block is visible.
++- Verifies common style declarations apply to header, accordion, app shell, and fullscreen layout targets.
++- Verifies Repo Destination accordion collapses and reopens with aria-expanded state changes.
++- Verifies no page errors during the launch/toggle path.
 +
-+Control and section class files:
-+- tools/preview-generator-v2/controls/AssetFolderControl.js - Asset folder section
-+- tools/preview-generator-v2/controls/CaptureModeControl.js - Capture mode section
-+- tools/preview-generator-v2/controls/LastGeneratedImageControl.js - Last Generated Image section
-+- tools/preview-generator-v2/controls/MenuSampleControl.js - menuSample Generate Preview/Stop controls
-+- tools/preview-generator-v2/controls/OutputSummaryControl.js - Output Summary section
-+- tools/preview-generator-v2/controls/PathsOrIdsControl.js - Paths or IDs section
-+- tools/preview-generator-v2/controls/PreviewFrameControl.js - hidden preview iframe
-+- tools/preview-generator-v2/controls/RenderControlsControl.js - Render Controls section
-+- tools/preview-generator-v2/controls/RepoDestinationControl.js - Repo Destination section
-+- tools/preview-generator-v2/controls/StatusControl.js - Status section and Clear control
-+- tools/preview-generator-v2/controls/TargetSourceControl.js - Target Source section
++Broken hooks:
++- No broken Preview Generator V2 selectors, IDs, or Playwright hooks were found.
++- No UI behavior changes were made.
 +
-+Shared dependency check:
-+- Command: rg -n "tools/shared|../shared|../../tools/shared|platformShell|shared/" tools/preview-generator-v2 tools/common tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
-+- Result: no tools/shared references found.
++Validation gap fixed:
++- package.json did not define npm run test:workspace-v2.
++- Added test:workspace-v2 as the repository validation command for the existing Preview Generator V2 Playwright baseline.
 +
-+Inline HTML check:
-+- Result: index.html has no inline style/script blocks.
++Validation run:
++- node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
++- npm run test:workspace-v2
 +
-+Legacy preview check:
-+- Command: Test-Path tools/preview
-+- Result: False.
-+
-+Syntax validation:
-+- Preview Generator V2 JavaScript syntax passed.
-+- Preview Generator V2 Playwright spec syntax passed.
-+
-+Playwright validation:
-+- Command: npx playwright test tests/playwright/PreviewGeneratorV2Baseline.spec.mjs --project=playwright --reporter=list
-+- Result: PASS, 1 passed.
-+
-+Workspace V2 validation:
-+- Command attempted: npm run test:workspace-v2
-+- Result: unavailable because package.json does not define test:workspace-v2.
++Result:
++- PASS: npm run test:workspace-v2 passed.
++- PASS: 1 Playwright test passed.
 +
-+Final note:
-+- This PR is a final review-readiness report pass. No runtime behavior, UI behavior, generation logic, samples, schemas, or start_of_day folders were changed.
++Scope guard:
++- No samples modified.
++- No schemas added or modified.
++- No start_of_day folders modified.
++- No duplicate Playwright tests added.

docs/dev/reports/preview_generator_v2_playwright_coverage.txt

@@ -0,0 +1,46 @@
+# Preview Generator V2 Playwright Coverage - PR_26126_040
+
+Reviewed:
+- docs/dev/reports/preview_generator_v2_playwright_result.txt
+- tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
+- package.json
+
+Coverage decision:
+- Preview Generator V2 is already explicitly covered by Playwright.
+- No duplicate Playwright test was added.
+
+Existing Playwright coverage:
+- Launches tools/preview-generator-v2/index.html through the repo HTTP server.
+- Verifies the Preview Generator V2 app shell is visible.
+- Verifies tools/common/toolShellCommon.css is loaded.
+- Verifies the Preview Generator V2 heading is visible.
+- Verifies menuSample nav exists.
+- Verifies Generate Preview and Stop render and begin disabled.
+- Verifies Games is the default target source.
+- Verifies Paths or IDs input is visible.
+- Verifies Status block is visible.
+- Verifies common style declarations apply to header, accordion, app shell, and fullscreen layout targets.
+- Verifies Repo Destination accordion collapses and reopens with aria-expanded state changes.
+- Verifies no page errors during the launch/toggle path.
+
+Broken hooks:
+- No broken Preview Generator V2 selectors, IDs, or Playwright hooks were found.
+- No UI behavior changes were made.
+
+Validation gap fixed:
+- package.json did not define npm run test:workspace-v2.
+- Added test:workspace-v2 as the repository validation command for the existing Preview Generator V2 Playwright baseline.
+
+Validation run:
+- node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
+- npm run test:workspace-v2
+
+Result:
+- PASS: npm run test:workspace-v2 passed.
+- PASS: 1 Playwright test passed.
+
+Scope guard:
+- No samples modified.
+- No schemas added or modified.
+- No start_of_day folders modified.
+- No duplicate Playwright tests added.

package.json

@@ -12,6 +12,7 @@
     "check:style-system-guard": "node tools/dev/checkStyleSystemGuard.mjs",
     "check:games-template-contract": "node ./scripts/validate-games-template-contract.mjs",
     "codex:review-artifacts": "node ./scripts/write-codex-review-artifacts.mjs",
+    "test:workspace-v2": "playwright test tests/playwright/PreviewGeneratorV2Baseline.spec.mjs --project=playwright --reporter=list",
     "test:launch-smoke": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs",
     "test:launch-smoke:games": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --games",
     "test:workspace-manager:games": "node ./tests/runtime/GamesIndexWorkspaceManagerOpen.test.mjs",