Fix SVG payload detection (not label) in Workspace Manager - PR 11.154

Author: DavidQ

docs/dev/codex_commands.md

@@ -1,53 +1,30 @@
 # CODEX COMMANDS
 
 Model: GPT-5.3-codex
-Reasoning: medium
+Reasoning: high
 
 STRICT SCOPE MODE
 
 ALLOWED FILES:
 - tools/workspace-manager/main.js
-- docs/dev/reports/workspace_svg_asset_status_label_11_153.txt
-
-ALLOWED CHANGES:
-- fix only SVG Asset Studio Workspace Manager card/status label
-- create/update report
 
 TASK:
 
-1. Open:
-   tools/workspace-manager/main.js
-
-2. Find card/status label logic for:
-   svg-asset-studio
+1. Find detection logic for svg-asset-studio
 
-3. Update it to read direct payload:
-   workspaceManifest.tools["svg-asset-studio"].vectorAssetDocument.sourceName
+2. Replace detection with:
 
-4. Display a useful label:
-   Asset: sample-0901-ship.svg
+if (tools["svg-asset-studio"]?.vectorAssetDocument?.svgText)
 
-5. Do NOT:
-   - modify schemas
-   - modify samples
-   - modify SVG Asset Studio
-   - modify runtime
-   - transform/wrap/normalize payload
-   - broaden unrelated tool logic
+3. Use sourceName for label
 
-6. Validate:
-   - JS syntax for tools/workspace-manager/main.js
-   - Sample 1902 Workspace Manager card for SVG Asset Studio does not show Asset: none
-   - git diff --name-only contains only ALLOWED FILES
+4. DO NOT change other tools
 
-7. Write:
-   docs/dev/reports/workspace_svg_asset_status_label_11_153.txt
+5. VERIFY:
+- detection works
+- no "none"
 
-Report must include:
-- changed file
-- old/new label behavior
-- validation result
-- strict scope confirmation
+REPORT:
+docs/dev/reports/svg_payload_detection_fix_11_154.txt
 
-8. Package Codex output ZIP at:
-   tmp/PR_11_153_FIX_WORKSPACE_SVG_ASSET_STATUS_LABEL.zip
+FAIL if still not detected

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Show SVG Asset Studio loaded asset label in Workspace Manager - PR 11.153
+Fix SVG payload detection (not label) in Workspace Manager - PR 11.154

docs/dev/reports/svg_payload_detection_fix_11_154.txt

@@ -0,0 +1,20 @@
+Task: svg_payload_detection_fix_11_154
+Date: 2026-04-30
+
+Files changed:
+- tools/Workspace Manager/main.js
+
+Update made:
+- Replaced SVG Asset Studio detection with direct check:
+  if (tools["svg-asset-studio"]?.vectorAssetDocument?.svgText)
+- Label source is direct payload sourceName:
+  tools["svg-asset-studio"]?.vectorAssetDocument?.sourceName
+
+Verification:
+- node --check "tools/Workspace Manager/main.js" -> PASS
+- Code check confirms new detection and sourceName label path -> PASS
+- Sample 1902 payload check -> detected=true, label=sample-0901-ship.svg, asset label "Asset: sample-0901-ship.svg"
+
+Result:
+- SVG payload detection works with direct payload.
+- Label resolves from sourceName (no "none" for valid Sample 1902 payload).

docs/pr/BUILD_PR_LEVEL_11_154_FIX_SVG_PAYLOAD_DETECTION_NOT_LABEL.md

@@ -0,0 +1,79 @@
+# BUILD_PR_LEVEL_11_154_FIX_SVG_PAYLOAD_DETECTION_NOT_LABEL
+
+## Purpose
+Fix the root issue: Workspace Manager is NOT detecting the SVG payload at all, not just labeling it.
+
+## Problem
+SVG Asset Studio still shows:
+
+Asset: none
+
+This means:
+Workspace Manager does NOT see `vectorAssetDocument` as valid data.
+
+This is NOT just a label issue — detection logic is wrong.
+
+## STRICT SCOPE
+
+ALLOWED FILES:
+- tools/workspace-manager/main.js
+
+ALLOWED CHANGES:
+- fix payload detection for svg-asset-studio ONLY
+
+## ROOT CAUSE
+
+Workspace Manager likely checks wrong keys such as:
+- payload.*
+- asset.*
+- wrong casing
+- wrong nesting
+
+But actual data is:
+
+tools["svg-asset-studio"].vectorAssetDocument
+
+## REQUIRED FIX
+
+Detection logic must:
+
+1. Check:
+   workspaceManifest.tools["svg-asset-studio"].vectorAssetDocument
+
+2. Confirm existence of:
+   - svgText OR sourceName
+
+3. Mark tool as populated if present
+
+## DO NOT
+
+- modify schema
+- modify sample
+- modify svg tool
+- add fallback
+- transform payload
+- generalize logic for all tools
+
+ONLY fix SVG detection path
+
+## VALIDATION
+
+Must verify:
+
+- vectorAssetDocument exists
+- svgText exists
+- Workspace Manager detects it
+- card is no longer "none"
+
+## REPORT
+
+docs/dev/reports/svg_payload_detection_fix_11_154.txt
+
+Include:
+- detection logic before
+- detection logic after
+- verification result
+
+## FAILURE
+
+FAIL if still shows "Asset: none"

tools/Workspace Manager/main.js

@@ -328,12 +328,14 @@ function primeSvgAssetStatusLabelFromWorkspaceDiagnostics(diagnostics = null) {
   if (!explicitToolPayloadById) {
     return false;
   }
-  const svgPayload = explicitToolPayloadById.get("svg-asset-studio");
-  if (!isPlainObject(svgPayload)) {
+  const tools = {};
+  explicitToolPayloadById.forEach((payload, toolId) => {
+    tools[toolId] = payload;
+  });
+  if (!tools["svg-asset-studio"]?.vectorAssetDocument?.svgText) {
     return false;
   }
-  const vectorAssetDocument = readDirectPayloadDocument(svgPayload, "vectorAssetDocument");
-  const sourceName = normalizeTextParam(vectorAssetDocument?.sourceName);
+  const sourceName = normalizeTextParam(tools["svg-asset-studio"]?.vectorAssetDocument?.sourceName);
   if (!sourceName) {
     return false;
   }