Enforce palette pass-through routing without mutation - PR 11.131

Author: DavidQ

docs/dev/codex_commands.md

@@ -1,31 +1,27 @@
 # CODEX COMMANDS
 
 Model: GPT-5.3-codex
-Reasoning: medium
-
-## PR
-BUILD_PR_LEVEL_11_130_TOOL_INPUT_CONTRACT_WITH_PALETTE_DEPENDENCY
+Reasoning: high
 
 STRICT SCOPE MODE
 
 ALLOWED FILES:
-- docs only
+- routing files only
 
 TASK:
 
-1. Document palette dependency rules
-2. Validate tools that require palette:
-   - payload JSON direct
-   - palette JSON direct
-3. Ensure:
-   - no wrapper accepted
-   - no parent JSON accepted
-   - no fallback palette
-   - no transform
+1. Find palette usage
+2. Remove:
+   - palette injection
+   - palette merging
+   - defaults
+3. Ensure separate pass-through
+
+VERIFY:
+payload unchanged
+palette unchanged
 
 REPORT:
-docs/dev/reports/tool_palette_dependency_11_130.txt
+docs/dev/reports/palette_pass_through_11_131.txt
 
-FAIL if any tool:
-- injects palette
-- transforms palette
+FAIL if mutation exists

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Add palette dependency rules to tool input contract - PR 11.130
+Enforce palette pass-through routing without mutation - PR 11.131

docs/dev/reports/palette_pass_through_11_131.txt

@@ -0,0 +1,59 @@
+Palette Pass-Through Report: 11_131
+Date: 2026-04-30
+Repo: C:/Users/davidq/Documents/GitHub/HTML-JavaScript-Gaming
+Mode: STRICT SCOPE
+
+Task
+1. Find palette usage.
+2. Remove palette injection, palette merging, defaults.
+3. Ensure separate pass-through.
+
+Routing file changed
+- tools/shared/platformShell.js
+
+Palette usage found
+- Workspace scoped preset routing for child tools and palette-browser.
+- Palette extraction for workspace/game manifests.
+- Shared palette hydration/injection path.
+
+Changes applied
+1) Removed palette injection
+- Removed shared palette write/injection path from routing flow.
+- `writeSharedPaletteHandoff(...)` calls removed from platform shell routing.
+- Hydration variables in init routing are set to `false` (no palette injection side effects).
+
+2) Removed palette merging and defaults
+- Removed palette normalization/merge builder function path.
+- Removed fallback palette id/display defaults.
+- Removed wrapped palette extraction (`tools["palette-browser"].payload`) from manifest palette read path.
+
+3) Enforced pass-through only
+- `readPaletteFromManifestPayload(...)` now returns the direct `tools["palette-browser"]` object only when:
+  - `schema === "html-js-gaming.palette"`
+  - `swatches` is an array.
+- Otherwise returns `null`.
+- Workspace scoped resolver already returns direct object references for tool payload and palette payload.
+
+Verification
+A) Payload unchanged
+- `selectWorkspaceScopedToolPreset(manifest, "vector-map-editor") === manifest.tools["vector-map-editor"]` -> true
+- JSON equality of payload -> true
+
+B) Palette unchanged
+- `readPaletteFromManifestPayload(manifest) === manifest.tools["palette-browser"]` -> true
+- JSON equality of palette -> true
+- `selectWorkspaceScopedToolPreset(manifest, "palette-browser") === manifest.tools["palette-browser"]` -> true
+
+C) Wrapper rejected
+- Wrapped palette input (`tools["palette-browser"].payload`) returns null for both read and select paths.
+
+D) Mutation path audit
+- `writeSharedPaletteHandoff(` call exists: false
+- `buildPaletteHandoffShape` exists: false
+
+Result
+- PASS
+- No palette injection.
+- No palette merging.
+- No palette defaults.
+- Separate pass-through preserved for payload and palette.

docs/pr/BUILD_PR_LEVEL_11_131_ENFORCE_PALETTE_PASS_THROUGH_ROUTING.md

@@ -0,0 +1,56 @@
+# BUILD_PR_LEVEL_11_131_ENFORCE_PALETTE_PASS_THROUGH_ROUTING
+
+## Purpose
+Enforce that palette dependencies are passed through routing layers WITHOUT mutation and NEVER embedded or transformed.
+
+## STRICT SCOPE
+
+ALLOWED FILES:
+- workspace manager routing files
+- tool launch handlers
+
+ALLOWED CHANGES:
+- remove palette injection
+- remove palette embedding
+- ensure palette passed as separate JSON reference
+
+## RULE
+
+payload JSON (tool) → unchanged  
+palette JSON → unchanged  
+
+NO:
+- embedding palette into payload
+- merging palette into payload
+- transforming palette
+- default palette injection
+
+## REQUIRED CHECKS
+
+1. Locate palette usage in routing
+2. Ensure:
+   - palette passed separately
+   - payload untouched
+3. Remove:
+   - inline palette building
+   - palette defaults
+   - palette merging
+
+## VALIDATION
+
+- payload before == payload after
+- palette before == palette after
+- missing palette → error (not fallback)
+
+## REPORT
+
+docs/dev/reports/palette_pass_through_11_131.txt:
+- files checked
+- violations
+- fixes applied
+
+## FAILURE
+
+FAIL if:
+- palette is embedded
+- palette is mutated