BUILD PR: centralize createResult across exact command-pack batch.

Author: DavidQ

docs/dev/CODEX_COMMANDS.md

@@ -1,10 +1,11 @@
 MODEL: GPT-5.3-codex
 REASONING: high
 COMMAND:
-Execute docs/pr/BUILD_PR_SHARED_EXTRACTION_41_AS_STRING_ARRAY_PRESET_BATCH.md exactly.
+Execute docs/pr/BUILD_PR_SHARED_EXTRACTION_42_CREATE_RESULT_COMMANDPACK_BATCH.md exactly.
 Edit only these files:
-- src/shared/utils/arrayUtils.js (only to add/export asStringArray if missing, or minimum export fix if present)
-- tools/dev/advanced/debugPanelGroupRegistry.js
-- tools/dev/presets/debugPresetRegistry.js
+- tools/dev/commandPacks/commandPackResultUtils.js (new file)
+- tools/dev/commandPacks/groupCommandPack.js
+- tools/dev/commandPacks/macroCommandPack.js
+- tools/dev/commandPacks/toggleCommandPack.js
 Do not expand scope.
-Package the delta output to <project folder>/tmp/BUILD_PR_SHARED_EXTRACTION_41_AS_STRING_ARRAY_PRESET_BATCH_delta.zip
+Package the delta output to <project folder>/tmp/BUILD_PR_SHARED_EXTRACTION_42_CREATE_RESULT_COMMANDPACK_BATCH_delta.zip

docs/dev/COMMIT_COMMENT.txt

@@ -1 +1 @@
-BUILD PR: centralize asStringArray across exact preset/group-registry batch.
+BUILD PR: centralize createResult across exact command-pack batch.

docs/dev/NEXT_COMMAND.txt

@@ -1 +1 @@
-Next: run BUILD_PR_SHARED_EXTRACTION_42_CREATE_RESULT_COMMANDPACK_BATCH after this batch.
+Next: run BUILD_PR_SHARED_EXTRACTION_43_GET_RUNTIME_AND_REGISTRY_BATCH after this batch.

docs/dev/reports/change_summary.txt

@@ -1 +1 @@
-Execution-grade batch for asStringArray using the exact duplicate-report file list.
+Execution-grade batch for createResult using the exact duplicate-report file list.

docs/pr/BUILD_PR_SHARED_EXTRACTION_42_CREATE_RESULT_COMMANDPACK_BATCH.md

@@ -0,0 +1,94 @@
+# BUILD_PR_SHARED_EXTRACTION_42_CREATE_RESULT_COMMANDPACK_BATCH
+
+## Purpose
+Centralize duplicated `createResult(status, title, lines, code, details = {})` implementations across the exact command-pack batch identified in the duplicate report.
+
+## Single PR Purpose
+Normalize ONLY this helper:
+
+- `createResult(status, title, lines, code, details = {})`
+
+## Exact Files Allowed
+
+### New shared file
+1. `tools/dev/commandPacks/commandPackResultUtils.js`
+
+### Consumer files
+2. `tools/dev/commandPacks/groupCommandPack.js`
+3. `tools/dev/commandPacks/macroCommandPack.js`
+4. `tools/dev/commandPacks/toggleCommandPack.js`
+
+Do not edit any other file.
+
+## Source of Truth
+This exact scope comes from the provided duplicate report entry for:
+
+`function createResult(status, title, lines, code, details = {})`
+
+Only the 3 listed consumer files are in scope.
+
+## Exact Shared Helper Creation
+Create:
+
+`tools/dev/commandPacks/commandPackResultUtils.js`
+
+Export exactly:
+
+```js
+export function createResult(status, title, lines, code, details = {}) {
+  // copy one existing implementation exactly
+}
+```
+
+Implementation rules:
+- use ONE existing local implementation as source-of-truth
+- do NOT merge logic
+- do NOT generalize behavior
+- preserve the function signature exactly:
+  - `createResult(status, title, lines, code, details = {})`
+
+## Exact Consumer Changes
+For each of the 3 listed consumer files:
+
+If the file contains a local function definition matching:
+```js
+function createResult(status, title, lines, code, details = {})
+```
+then:
+- remove the local `createResult(...)` function definition
+- import `createResult` from the correct relative path to:
+  - `./commandPackResultUtils.js`
+- if the file already imports from that module, add `createResult` with the minimum safe edit
+- do not duplicate imports
+- do not touch unrelated helpers
+- do not change logic
+
+If a listed file already imports and uses shared `createResult`, leave it unchanged.
+
+## Relative Import Rule
+Use exactly:
+
+`./commandPackResultUtils.js`
+
+Do not use aliases.
+Do not change `.js` extension usage.
+
+## Hard Constraints
+- no engine changes
+- no files outside the 3 listed consumers plus the one new shared file
+- no repo-wide command-pack helper cleanup
+- no behavior changes
+- keep one PR purpose only
+
+## Validation Checklist
+1. Confirm no more than the 4 listed files changed
+2. Confirm `tools/dev/commandPacks/commandPackResultUtils.js` exists and exports `createResult`
+3. Confirm local `function createResult(...)` definitions no longer exist in changed listed consumer files
+4. Confirm changed consumer files import `createResult` from `./commandPackResultUtils.js`
+5. Confirm no unrelated files changed
+6. Confirm no behavior changes were made
+
+## Non-Goals
+- no cleanup of `toResult`
+- no cleanup outside the 3 listed consumer files
+- no refactor beyond this exact duplicate-removal batch

tools/dev/commandPacks/commandPackResultUtils.js

@@ -0,0 +1,9 @@
+export function createResult(status, title, lines, code, details = {}) {
+  return {
+    status: status === "failed" ? "failed" : "ready",
+    title,
+    lines: Array.isArray(lines) ? lines : [],
+    code,
+    details
+  };
+}

tools/dev/commandPacks/groupCommandPack.js

@@ -11,19 +11,10 @@ import {
   requireAtLeastArgs,
   requireNoArgs
 } from "./packUtils.js";
+import { createResult } from "./commandPackResultUtils.js";
 
 import { sanitizeText } from "../../../src/engine/debug/inspectors/shared/inspectorUtils.js";
 
-function createResult(status, title, lines, code, details = {}) {
-  return {
-    status: status === "failed" ? "failed" : "ready",
-    title,
-    lines: Array.isArray(lines) ? lines : [],
-    code,
-    details
-  };
-}
-
 function getRuntimeAndRegistry(context) {
   const runtime = context?.consoleRuntime;
   const panelRegistry = runtime?.panelRegistry;

tools/dev/commandPacks/macroCommandPack.js

@@ -12,19 +12,10 @@ import {
   requireAtLeastArgs,
   requireNoArgs
 } from "./packUtils.js";
+import { createResult } from "./commandPackResultUtils.js";
 
 import { sanitizeText } from "../../../src/engine/debug/inspectors/shared/inspectorUtils.js";
 
-function createResult(status, title, lines, code, details = {}) {
-  return {
-    status: status === "failed" ? "failed" : "ready",
-    title,
-    lines: Array.isArray(lines) ? lines : [],
-    code,
-    details
-  };
-}
-
 const macroRegistry = new DebugMacroRegistry();
 registerStandardDebugMacros(macroRegistry, "standard");
 

tools/dev/commandPacks/toggleCommandPack.js

@@ -8,16 +8,7 @@ toggleCommandPack.js
 import {
   requireNoArgs
 } from "./packUtils.js";
-
-function createResult(status, title, lines, code, details = {}) {
-  return {
-    status: status === "failed" ? "failed" : "ready",
-    title,
-    lines: Array.isArray(lines) ? lines : [],
-    code,
-    details
-  };
-}
+import { createResult } from "./commandPackResultUtils.js";
 
 function executePresetToggle(context, presetId) {
   if (typeof context?.executeConsoleCommand !== "function") {