Normalize Session Inspector V2 tool objects into workspace data and dirty sections - PR_26128_020-session-inspector-v2-data-dirty-model

DavidQ · DavidQ · commit 178fc296f434 · 2026-05-08T16:57:12.000-04:00
diff --git a/docs/dev/reports/playwright_session_inspector_v2_data_dirty_model.md b/docs/dev/reports/playwright_session_inspector_v2_data_dirty_model.md
@@ -0,0 +1,24 @@
+# Playwright Session Inspector V2 Data Dirty Model
+
+## Command
+`npm run test:workspace-v2`
+
+## Result
+- Passed: 15/15
+- Runtime: about 1.4 minutes
+
+## Targeted Coverage
+- Workspace Manager V2 writes normalized tool sessions with `schema`, `workspace`, `data`, and `dirty`.
+- Repeated workspace/repo/game context lives under `workspace`.
+- Actual tool payload lives under `data`.
+- Dirty tracking defaults to the clean object.
+- Session Inspector V2 shows JSON, Data, and Dirty views.
+- Session Inspector V2 State and Schema labels/controls are absent.
+- JSON shows the full selected object.
+- Data shows only selected `data`.
+- Dirty shows only selected `dirty`.
+- JSON, Data, Dirty, Controls, Filters, Entries, and Status accordions all open and close.
+- Split `workspace.tools.<tool-id>.schema` and `workspace.tools.<tool-id>.state` keys are not recreated.
+
+## Skipped
+- Full samples smoke test was skipped by request. The changed surface is covered by `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`.
diff --git a/docs/dev/reports/session_inspector_v2_data_dirty_model.md b/docs/dev/reports/session_inspector_v2_data_dirty_model.md
@@ -0,0 +1,49 @@
+# Session Inspector V2 Data Dirty Model
+
+## Scope
+- Replaced the normalized tool object model with:
+  - `schema`
+  - `workspace`
+  - `data`
+  - `dirty`
+- Moved repeated workspace/repo/game context into `workspace`.
+- Moved actual tool payload data into `data`.
+- Added clean dirty tracking defaults:
+  - `isDirty: false`
+  - `reason: null`
+  - `changedAt: null`
+  - `changedKeys: []`
+- Removed Session Inspector V2 State UI.
+- Kept Schema out of the Session Inspector V2 UI.
+- Added Session Inspector V2 views:
+  - JSON: full stored object
+  - Data: selected item `data`
+  - Dirty: selected item `dirty`
+- Removed the Workspace Manager V2 Session Inspector tile subtitle `Session storage inspector`.
+
+## Implementation Notes
+- Workspace Manager V2 still writes one session key per tool: `workspace.tools.<tool-id>`.
+- Workspace Manager V2 still preserves `workspace.repo.reference`.
+- Preview Generator V2 reads workspace session context from `workspace.tools.preview-generator-v2.workspace`.
+- Preview Generator V2 image generation behavior was not changed.
+- Data and Dirty views show actionable empty states when the selected storage item has no matching section.
+- Per-tile Delete and Delete All behavior were preserved.
+
+## Guardrails
+- No cross-tool communication was added.
+- No `.schema` or `.state` split keys were recreated.
+- No sample JSON was modified.
+- No roadmap content was modified.
+
+## Validation
+- Passed `npm run test:workspace-v2` with 15/15 tests.
+- Verified normalized tool objects use `schema`, `workspace`, `data`, and `dirty`.
+- Verified repeated workspace context is not stored under `state`.
+- Verified actual tool payload is stored under `data`.
+- Verified dirty defaults to clean.
+- Verified Session Inspector V2 has JSON, Data, and Dirty views.
+- Verified State and Schema controls are absent from Session Inspector V2 UI.
+- Verified JSON/Data/Dirty accordion behavior does not conflict with other accordions.
+
+## Skipped
+- Full samples smoke test was skipped because this PR is scoped to Workspace Manager V2 session hydration and Session Inspector V2 display of normalized browser storage. The requested Workspace V2 Playwright suite covers the changed behavior.
diff --git a/tests/playwright/tools/WorkspaceManagerV2.spec.mjs b/tests/playwright/tools/WorkspaceManagerV2.spec.mjs
diff --git a/tools/preview-generator-v2/PreviewGeneratorV2App.js b/tools/preview-generator-v2/PreviewGeneratorV2App.js
@@ -126,31 +126,31 @@ function readWorkspaceRepoReference() {
   return { ok: true, reference: { ...reference, displayName } };
 }
 
-function readWorkspacePreviewGeneratorState(manifest) {
+function readWorkspacePreviewGeneratorWorkspace(manifest) {
   const result = readSessionJson(WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY);
   if (!result.ok) {
     return result;
   }
-  if (!isPlainObject(result.value.state)) {
-    return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.state must contain a JSON object.` };
+  if (!isPlainObject(result.value.workspace)) {
+    return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.workspace must contain a JSON object.` };
   }
-  const state = result.value.state;
-  if (state.source !== "workspace-manager-v2") {
-    return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.state.source must be workspace-manager-v2.` };
+  const workspace = result.value.workspace;
+  if (workspace.source !== "workspace-manager-v2") {
+    return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.workspace.source must be workspace-manager-v2.` };
   }
-  if (state.toolId !== PREVIEW_GENERATOR_V2_TOOL_KEY) {
-    return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.state.toolId must be ${PREVIEW_GENERATOR_V2_TOOL_KEY}.` };
+  if (workspace.toolId !== PREVIEW_GENERATOR_V2_TOOL_KEY) {
+    return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.workspace.toolId must be ${PREVIEW_GENERATOR_V2_TOOL_KEY}.` };
   }
-  if (state.repoReferenceKey !== WORKSPACE_REPO_REFERENCE_SESSION_KEY) {
-    return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.state.repoReferenceKey must be ${WORKSPACE_REPO_REFERENCE_SESSION_KEY}.` };
+  if (workspace.repoReferenceKey !== WORKSPACE_REPO_REFERENCE_SESSION_KEY) {
+    return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.workspace.repoReferenceKey must be ${WORKSPACE_REPO_REFERENCE_SESSION_KEY}.` };
   }
-  if (state.gameId !== manifest.gameId) {
-    return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.state.gameId must match manifest.gameId ${manifest.gameId}.` };
+  if (workspace.gameId !== manifest.gameId) {
+    return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.workspace.gameId must match manifest.gameId ${manifest.gameId}.` };
   }
-  if (state.gameRoot !== manifest.gameRoot || state.assetsPath !== manifest.assetsPath) {
-    return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.state gameRoot/assetsPath must match the workspace manifest.` };
+  if (workspace.gameRoot !== manifest.gameRoot || workspace.assetsPath !== manifest.assetsPath) {
+    return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.workspace gameRoot/assetsPath must match the workspace manifest.` };
   }
-  return { ok: true, state };
+  return { ok: true, workspace };
 }
 
 function isWorkspaceManifest(value) {
@@ -902,9 +902,9 @@ class PreviewGeneratorV2App {
     if (!repoReferenceResult.ok) {
       return { ok: false, message: repoReferenceResult.message };
     }
-    const stateResult = readWorkspacePreviewGeneratorState(manifest);
-    if (!stateResult.ok) {
-      return { ok: false, message: stateResult.message };
+    const workspaceResult = readWorkspacePreviewGeneratorWorkspace(manifest);
+    if (!workspaceResult.ok) {
+      return { ok: false, message: workspaceResult.message };
     }
     const repoReference = repoReferenceResult.reference;
     if (!repoRootNameMatches(repoReference.displayName, manifest.repoRoot)) {
@@ -922,7 +922,7 @@ class PreviewGeneratorV2App {
     if (!repoValidation.ok) {
       return repoValidation;
     }
-    return { ok: true, handle, repoReference, state: stateResult.state };
+    return { ok: true, handle, repoReference, workspace: workspaceResult.workspace };
   }
 
   async handleExecute() {
@@ -1118,7 +1118,7 @@ class PreviewGeneratorV2App {
     ui.setRepoDestinationDisplayName(repoDisplayName);
     workspaceLaunchHydrated = true;
     logger.log(`OK Workspace repo session reference loaded from ${WORKSPACE_REPO_REFERENCE_SESSION_KEY} for ${repoDisplayName}.`);
-    logger.log(`OK Workspace tool session state loaded from ${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.`);
+    logger.log(`OK Workspace tool session workspace context loaded from ${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.`);
     logger.log("Workspace launch repo context resolved from session storage; independent repo selection is not required.");
     this.syncGeneratePreviewButton();
   }
diff --git a/tools/session-inspector-v2/README.md b/tools/session-inspector-v2/README.md
@@ -13,5 +13,6 @@ Session Inspector V2 is a first-class tool for inspecting and clearing current-o
 - Seed a storage key in the current origin.
 - Refresh the tool and verify the key appears in the Entries list.
 - Select an entry and confirm the JSON panel shows the full stored value.
-- Select a normalized workspace tool entry and confirm the State panel shows only its state section.
+- Select a normalized workspace tool entry and confirm the Data panel shows only its data section.
+- Select a normalized workspace tool entry and confirm the Dirty panel shows only its dirty-tracking section.
 - Use per-entry Delete or Delete All and verify the Entries list and status log update immediately.
diff --git a/tools/session-inspector-v2/index.html b/tools/session-inspector-v2/index.html
@@ -95,7 +95,7 @@ <h2 class="tools-platform-frame__eyebrow">Session storage visibility</h2>
         </section>
       </section>
 
-      <aside class="session-inspector-v2__panel session-inspector-v2__panel--right tool-shell-common__fullscreen-panel tool-shell-common__fullscreen-side-panel tool-shell-common__fullscreen-panel-right" aria-label="Session JSON and state">
+      <aside class="session-inspector-v2__panel session-inspector-v2__panel--right tool-shell-common__fullscreen-panel tool-shell-common__fullscreen-side-panel tool-shell-common__fullscreen-panel-right" aria-label="Session JSON, data, and dirty tracking">
         <section class="accordion-v2 session-inspector-v2__accordion session-inspector-v2__accordion--fill is-open" data-accordion-v2-open="true">
           <div class="accordion-v2__header session-inspector-v2__json-accordion-header" role="button" tabindex="0" aria-expanded="true" aria-controls="sessionInspectorV2JsonContent">
             <span>JSON</span>
@@ -110,12 +110,22 @@ <h2 class="tools-platform-frame__eyebrow">Session storage visibility</h2>
         </section>
 
         <section class="accordion-v2 session-inspector-v2__accordion session-inspector-v2__accordion--fill is-open" data-accordion-v2-open="true">
-          <div class="accordion-v2__header session-inspector-v2__state-accordion-header" role="button" tabindex="0" aria-expanded="true" aria-controls="sessionInspectorV2StateContent">
-            <span>State</span>
+          <div class="accordion-v2__header session-inspector-v2__data-accordion-header" role="button" tabindex="0" aria-expanded="true" aria-controls="sessionInspectorV2DataContent">
+            <span>Data</span>
             <span class="accordion-v2__icon" aria-hidden="true">+</span>
           </div>
-          <div id="sessionInspectorV2StateContent" class="accordion-v2__content">
-            <pre id="sessionInspectorV2StateOutput" class="session-inspector-v2__output">Select a normalized tool entry with a top-level state section.</pre>
+          <div id="sessionInspectorV2DataContent" class="accordion-v2__content">
+            <pre id="sessionInspectorV2DataOutput" class="session-inspector-v2__output">Select a normalized tool entry with a top-level data section.</pre>
+          </div>
+        </section>
+
+        <section class="accordion-v2 session-inspector-v2__accordion session-inspector-v2__accordion--fill is-open" data-accordion-v2-open="true">
+          <div class="accordion-v2__header session-inspector-v2__dirty-accordion-header" role="button" tabindex="0" aria-expanded="true" aria-controls="sessionInspectorV2DirtyContent">
+            <span>Dirty</span>
+            <span class="accordion-v2__icon" aria-hidden="true">+</span>
+          </div>
+          <div id="sessionInspectorV2DirtyContent" class="accordion-v2__content">
+            <pre id="sessionInspectorV2DirtyOutput" class="session-inspector-v2__output">Select a normalized tool entry with a top-level dirty section.</pre>
           </div>
         </section>
 
diff --git a/tools/session-inspector-v2/js/SessionInspectorV2App.js b/tools/session-inspector-v2/js/SessionInspectorV2App.js
@@ -2,29 +2,31 @@ export class SessionInspectorV2App {
   constructor({
     accordions,
     copyJsonButton,
+    data,
     deleteAllButton,
+    dirty,
     entryList,
     filters,
     json,
     refreshButton,
     returnToWorkspaceButton,
     runtimeContract,
-    state,
     statusLog,
     storageService,
     windowRef = window
   }) {
     this.accordions = accordions;
     this.copyJsonButton = copyJsonButton;
+    this.data = data;
     this.deleteAllButton = deleteAllButton;
+    this.dirty = dirty;
     this.entries = [];
     this.entryList = entryList;
     this.filters = filters;
     this.json = json;
     this.refreshButton = refreshButton;
     this.returnToWorkspaceButton = returnToWorkspaceButton;
     this.runtimeContract = runtimeContract || { storageAccess: "read-only" };
-    this.state = state;
     this.statusLog = statusLog;
     this.storageService = storageService;
     this.selectedId = "";
@@ -66,7 +68,8 @@ export class SessionInspectorV2App {
     this.entryList.render(this.entries, this.selectedId);
     const selectedEntry = this.entries.find((entry) => entry.id === this.selectedId);
     this.json.render(selectedEntry);
-    this.state.render(selectedEntry);
+    this.data.render(selectedEntry);
+    this.dirty.render(selectedEntry);
     this.filters.setSummary(this.summaryCounts());
     if (!silent) {
       this.statusLog.ok(`Loaded ${this.entries.length} matching storage entries.`);
@@ -85,7 +88,8 @@ export class SessionInspectorV2App {
     this.entryList.render(this.entries, this.selectedId);
     const entry = this.entries.find((candidate) => candidate.id === entryId);
     this.json.render(entry);
-    this.state.render(entry);
+    this.data.render(entry);
+    this.dirty.render(entry);
     if (entry) {
       this.statusLog.info(`Selected ${entry.storageType}:${entry.key}.`);
     }
diff --git a/tools/session-inspector-v2/js/bootstrap.js b/tools/session-inspector-v2/js/bootstrap.js
@@ -1,9 +1,10 @@
 import { SessionInspectorV2App } from "./SessionInspectorV2App.js";
 import { AccordionSection } from "./controls/AccordionSection.js";
+import { DataControl } from "./controls/DataControl.js";
+import { DirtyControl } from "./controls/DirtyControl.js";
 import { EntryListControl } from "./controls/EntryListControl.js";
 import { FilterControl } from "./controls/FilterControl.js";
 import { JsonControl } from "./controls/JsonControl.js";
-import { StateControl } from "./controls/StateControl.js";
 import { StatusLogControl } from "./controls/StatusLogControl.js";
 import { sessionInspectorV2RuntimeContract } from "./services/SessionInspectorV2RuntimeContract.js";
 import { SessionInspectorV2StorageService } from "./services/SessionInspectorV2StorageService.js";
@@ -20,9 +21,15 @@ window.addEventListener("DOMContentLoaded", () => {
   const app = new SessionInspectorV2App({
     accordions: Array.from(document.querySelectorAll(".accordion-v2"), (section) => new AccordionSection(section)),
     copyJsonButton: requireElement("#copySessionInspectorV2JsonButton"),
+    data: new DataControl({
+      output: requireElement("#sessionInspectorV2DataOutput")
+    }),
     json: new JsonControl({
       output: requireElement("#sessionInspectorV2JsonOutput")
     }),
+    dirty: new DirtyControl({
+      output: requireElement("#sessionInspectorV2DirtyOutput")
+    }),
     deleteAllButton: requireElement("#deleteAllSessionInspectorV2Button"),
     entryList: new EntryListControl({
       container: requireElement("#sessionInspectorV2EntryList")
@@ -35,9 +42,6 @@ window.addEventListener("DOMContentLoaded", () => {
     refreshButton: requireElement("#refreshSessionInspectorV2Button"),
     returnToWorkspaceButton: requireElement("#returnToWorkspaceButton"),
     runtimeContract: sessionInspectorV2RuntimeContract(),
-    state: new StateControl({
-      output: requireElement("#sessionInspectorV2StateOutput")
-    }),
     statusLog: new StatusLogControl({
       clearButton: requireElement("#clearSessionInspectorV2StatusButton"),
       output: requireElement("#statusLog")
diff --git a/tools/session-inspector-v2/js/controls/DataControl.js b/tools/session-inspector-v2/js/controls/DataControl.js
@@ -0,0 +1,22 @@
+export class DataControl {
+  constructor({ output }) {
+    this.output = output;
+  }
+
+  clear() {
+    this.output.textContent = "Select a normalized tool entry with a top-level data section.";
+  }
+
+  render(entry) {
+    if (!entry) {
+      this.clear();
+      return;
+    }
+    const value = entry.parseOk ? entry.parsedValue : null;
+    if (!value || typeof value !== "object" || Array.isArray(value) || !Object.prototype.hasOwnProperty.call(value, "data")) {
+      this.output.textContent = `No data section is present for ${entry.storageType}:${entry.key}. Select a normalized tool entry with a top-level data section.`;
+      return;
+    }
+    this.output.textContent = JSON.stringify(value.data, null, 2);
+  }
+}
diff --git a/tools/session-inspector-v2/js/controls/DirtyControl.js b/tools/session-inspector-v2/js/controls/DirtyControl.js
@@ -1,10 +1,10 @@
-export class StateControl {
+export class DirtyControl {
   constructor({ output }) {
     this.output = output;
   }
 
   clear() {
-    this.output.textContent = "Select a normalized tool entry with a top-level state section.";
+    this.output.textContent = "Select a normalized tool entry with a top-level dirty section.";
   }
 
   render(entry) {
@@ -13,10 +13,10 @@ export class StateControl {
       return;
     }
     const value = entry.parseOk ? entry.parsedValue : null;
-    if (!value || typeof value !== "object" || Array.isArray(value) || !Object.prototype.hasOwnProperty.call(value, "state")) {
-      this.output.textContent = `No state section is present for ${entry.storageType}:${entry.key}. Select a normalized tool entry with a top-level state section.`;
+    if (!value || typeof value !== "object" || Array.isArray(value) || !Object.prototype.hasOwnProperty.call(value, "dirty")) {
+      this.output.textContent = `No dirty section is present for ${entry.storageType}:${entry.key}. Select a normalized tool entry with a top-level dirty section.`;
       return;
     }
-    this.output.textContent = JSON.stringify(value.state, null, 2);
+    this.output.textContent = JSON.stringify(value.dirty, null, 2);
   }
 }
diff --git a/tools/workspace-manager-v2/js/controls/ToolTilesControl.js b/tools/workspace-manager-v2/js/controls/ToolTilesControl.js
@@ -48,7 +48,7 @@ export class ToolTilesControl {
       return `${paletteSwatchCount} palette swatches`;
     }
     if (tool.id === "session-inspector-v2") {
-      return "Session storage inspector";
+      return "";
     }
     return manifestStatus;
   }
@@ -98,9 +98,7 @@ export class ToolTilesControl {
     state.className = "workspace-manager-v2__tool-tile-state";
     state.textContent = canLaunch ? "Ready to launch" : "Waiting for manifest";
 
-    const detail = document.createElement("span");
-    detail.className = "workspace-manager-v2__tool-tile-detail";
-    detail.textContent = this.detailForTool(tool, { assetCount, manifestStatus, paletteSwatchCount });
+    const detailText = this.detailForTool(tool, { assetCount, manifestStatus, paletteSwatchCount });
 
     const actions = document.createElement("span");
     actions.className = "workspace-manager-v2__tool-tile-actions";
@@ -111,7 +109,14 @@ export class ToolTilesControl {
       actions.append(action);
     });
 
-    button.append(name, state, detail, actions);
+    button.append(name, state);
+    if (detailText) {
+      const detail = document.createElement("span");
+      detail.className = "workspace-manager-v2__tool-tile-detail";
+      detail.textContent = detailText;
+      button.append(detail);
+    }
+    button.append(actions);
     return button;
   }
 }
diff --git a/tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js b/tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js

Original file line number	Diff line number	Diff line change
`@@ -126,31 +126,31 @@ function readWorkspaceRepoReference() {`
`126`	`126`	`return { ok: true, reference: { ...reference, displayName } };`
`127`	`127`	`}`
`128`	`128`
`129`		`-function readWorkspacePreviewGeneratorState(manifest) {`
	`129`	`+function readWorkspacePreviewGeneratorWorkspace(manifest) {`
`130`	`130`	`const result = readSessionJson(WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY);`
`131`	`131`	`if (!result.ok) {`
`132`	`132`	`return result;`
`133`	`133`	`}`
`134`		`- if (!isPlainObject(result.value.state)) {`
`135`		- return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.state must contain a JSON object.` };
	`134`	`+ if (!isPlainObject(result.value.workspace)) {`
	`135`	+ return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.workspace must contain a JSON object.` };
`136`	`136`	`}`
`137`		`- const state = result.value.state;`
`138`		`- if (state.source !== "workspace-manager-v2") {`
`139`		- return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.state.source must be workspace-manager-v2.` };
	`137`	`+ const workspace = result.value.workspace;`
	`138`	`+ if (workspace.source !== "workspace-manager-v2") {`
	`139`	+ return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.workspace.source must be workspace-manager-v2.` };
`140`	`140`	`}`
`141`		`- if (state.toolId !== PREVIEW_GENERATOR_V2_TOOL_KEY) {`
`142`		- return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.state.toolId must be ${PREVIEW_GENERATOR_V2_TOOL_KEY}.` };
	`141`	`+ if (workspace.toolId !== PREVIEW_GENERATOR_V2_TOOL_KEY) {`
	`142`	+ return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.workspace.toolId must be ${PREVIEW_GENERATOR_V2_TOOL_KEY}.` };
`143`	`143`	`}`
`144`		`- if (state.repoReferenceKey !== WORKSPACE_REPO_REFERENCE_SESSION_KEY) {`
`145`		- return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.state.repoReferenceKey must be ${WORKSPACE_REPO_REFERENCE_SESSION_KEY}.` };
	`144`	`+ if (workspace.repoReferenceKey !== WORKSPACE_REPO_REFERENCE_SESSION_KEY) {`
	`145`	+ return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.workspace.repoReferenceKey must be ${WORKSPACE_REPO_REFERENCE_SESSION_KEY}.` };
`146`	`146`	`}`
`147`		`- if (state.gameId !== manifest.gameId) {`
`148`		- return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.state.gameId must match manifest.gameId ${manifest.gameId}.` };
	`147`	`+ if (workspace.gameId !== manifest.gameId) {`
	`148`	+ return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.workspace.gameId must match manifest.gameId ${manifest.gameId}.` };
`149`	`149`	`}`
`150`		`- if (state.gameRoot !== manifest.gameRoot \|\| state.assetsPath !== manifest.assetsPath) {`
`151`		- return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.state gameRoot/assetsPath must match the workspace manifest.` };
	`150`	`+ if (workspace.gameRoot !== manifest.gameRoot \|\| workspace.assetsPath !== manifest.assetsPath) {`
	`151`	+ return { ok: false, message: `${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.workspace gameRoot/assetsPath must match the workspace manifest.` };
`152`	`152`	`}`
`153`		`- return { ok: true, state };`
	`153`	`+ return { ok: true, workspace };`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`function isWorkspaceManifest(value) {`
`@@ -902,9 +902,9 @@ class PreviewGeneratorV2App {`
`902`	`902`	`if (!repoReferenceResult.ok) {`
`903`	`903`	`return { ok: false, message: repoReferenceResult.message };`
`904`	`904`	`}`
`905`		`- const stateResult = readWorkspacePreviewGeneratorState(manifest);`
`906`		`- if (!stateResult.ok) {`
`907`		`- return { ok: false, message: stateResult.message };`
	`905`	`+ const workspaceResult = readWorkspacePreviewGeneratorWorkspace(manifest);`
	`906`	`+ if (!workspaceResult.ok) {`
	`907`	`+ return { ok: false, message: workspaceResult.message };`
`908`	`908`	`}`
`909`	`909`	`const repoReference = repoReferenceResult.reference;`
`910`	`910`	`if (!repoRootNameMatches(repoReference.displayName, manifest.repoRoot)) {`
`@@ -922,7 +922,7 @@ class PreviewGeneratorV2App {`
`922`	`922`	`if (!repoValidation.ok) {`
`923`	`923`	`return repoValidation;`
`924`	`924`	`}`
`925`		`- return { ok: true, handle, repoReference, state: stateResult.state };`
	`925`	`+ return { ok: true, handle, repoReference, workspace: workspaceResult.workspace };`
`926`	`926`	`}`
`927`	`927`
`928`	`928`	`async handleExecute() {`
`@@ -1118,7 +1118,7 @@ class PreviewGeneratorV2App {`
`1118`	`1118`	`ui.setRepoDestinationDisplayName(repoDisplayName);`
`1119`	`1119`	`workspaceLaunchHydrated = true;`
`1120`	`1120`	logger.log(`OK Workspace repo session reference loaded from ${WORKSPACE_REPO_REFERENCE_SESSION_KEY} for ${repoDisplayName}.`);
`1121`		- logger.log(`OK Workspace tool session state loaded from ${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.`);
	`1121`	+ logger.log(`OK Workspace tool session workspace context loaded from ${WORKSPACE_PREVIEW_GENERATOR_SESSION_KEY}.`);
`1122`	`1122`	`logger.log("Workspace launch repo context resolved from session storage; independent repo selection is not required.");`
`1123`	`1123`	`this.syncGeneratePreviewButton();`
`1124`	`1124`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,10 @@`
`1`		`-export class StateControl {`
	`1`	`+export class DirtyControl {`
`2`	`2`	`constructor({ output }) {`
`3`	`3`	`this.output = output;`
`4`	`4`	`}`
`5`	`5`
`6`	`6`	`clear() {`
`7`		`- this.output.textContent = "Select a normalized tool entry with a top-level state section.";`
	`7`	`+ this.output.textContent = "Select a normalized tool entry with a top-level dirty section.";`
`8`	`8`	`}`
`9`	`9`
`10`	`10`	`render(entry) {`
`@@ -13,10 +13,10 @@ export class StateControl {`
`13`	`13`	`return;`
`14`	`14`	`}`
`15`	`15`	`const value = entry.parseOk ? entry.parsedValue : null;`
`16`		`- if (!value \|\| typeof value !== "object" \|\| Array.isArray(value) \|\| !Object.prototype.hasOwnProperty.call(value, "state")) {`
`17`		- this.output.textContent = `No state section is present for ${entry.storageType}:${entry.key}. Select a normalized tool entry with a top-level state section.`;
	`16`	`+ if (!value \|\| typeof value !== "object" \|\| Array.isArray(value) \|\| !Object.prototype.hasOwnProperty.call(value, "dirty")) {`
	`17`	+ this.output.textContent = `No dirty section is present for ${entry.storageType}:${entry.key}. Select a normalized tool entry with a top-level dirty section.`;
`18`	`18`	`return;`
`19`	`19`	`}`
`20`		`- this.output.textContent = JSON.stringify(value.state, null, 2);`
	`20`	`+ this.output.textContent = JSON.stringify(value.dirty, null, 2);`
`21`	`21`	`}`
`22`	`22`	`}`