Skip to content

Commit 0bff14b

Browse files
author
DavidQ
committed
Refine Palette Manager V2 tag clear controls and preserve source pin scroll - PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll
1 parent 2266e27 commit 0bff14b

13 files changed

Lines changed: 1829 additions & 756 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,30 @@
1-
# Codex Commands - PR_26124_060-palette-manager-undo-redo-and-multi-tag-select
1+
# Codex Commands - PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll
22

33
## Workflow
44
- Read `docs/dev/PROJECT_INSTRUCTIONS.md`.
55
- Used `.codex/skills/repo-build/SKILL.md`.
66
- Checked git status before implementation.
7-
- Searched `src/` for undo/history/command stack classes and found no suitable reusable stack for Palette Manager V2 user palette mutations.
8-
- Created `docs/pr/PR_26124_060-palette-manager-undo-redo-and-multi-tag-select/PLAN_PR.md`.
9-
- Created `docs/pr/PR_26124_060-palette-manager-undo-redo-and-multi-tag-select/BUILD_PR.md`.
7+
- Created `docs/pr/PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll/PLAN_PR.md`.
8+
- Created `docs/pr/PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll/BUILD_PR.md`.
109
- Read the active BUILD doc before changing runtime files.
1110
- Updated Palette Manager V2 only.
12-
- Created `docs/pr/PR_26124_060-palette-manager-undo-redo-and-multi-tag-select/APPLY_PR.md`.
11+
- Created `docs/pr/PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll/APPLY_PR.md`.
1312

1413
## Validation Commands
1514
- `node --check tools/palette-manager-v2/modules/PaletteManagerApp.js`
16-
- `node --check tools/palette-manager-v2/modules/PaletteHistoryStack.js`
17-
- `node --check tools/palette-manager-v2/modules/SwatchRow.js`
1815
- `node --check tools/palette-manager-v2/controls/PaletteEditorControl.js`
1916
- `node --check tools/palette-manager-v2/controls/UserPaletteControl.js`
20-
- Targeted served-browser Palette Manager V2 undo/redo, multi-select, batch tag, and source pin validation using Playwright from Node.
17+
- `node --check tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js`
18+
- Targeted served-browser Palette Manager V2 selection clear, heading action placement, tag add, and source scroll preservation validation using Playwright from Node.
2119
- `git diff --check`
2220
- `npm run test:workspace-v2`
2321
- `git diff --cached --check`
2422
- `npm run codex:review-artifacts`
25-
- Python `zipfile` packaging for `tmp/PR_26124_060-palette-manager-undo-redo-and-multi-tag-select_delta.zip`
23+
- Python `zipfile` packaging for `tmp/PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll_delta.zip`
2624

2725
## Validation Outcome
2826
- JavaScript syntax checks: PASS.
29-
- Targeted served-browser Palette Manager V2 undo/redo, multi-select, batch tag, and source pin check: PASS.
27+
- Targeted served-browser Palette Manager V2 selection clear, heading action placement, tag add, and source scroll preservation check: PASS.
3028
- `git diff --check`: PASS with Git LF-to-CRLF warnings for changed Palette Manager files.
3129
- `git diff --cached --check`: PASS.
3230
- `npm run test:workspace-v2`: FAILED because the script is missing from `package.json`.

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Add Palette Manager undo redo history and batch tag selection - PR_26124_060-palette-manager-undo-redo-and-multi-tag-select
1+
Add Palette Manager heading controls and preserve source pin scroll - PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll
Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
# PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll Report
2+
3+
## Summary
4+
Palette Manager V2 now supports heading action controls, clearing User Palette checkbox selections, and preserving Sample Palette scroll position while source pins render.
5+
6+
## Files Changed
7+
- `docs/pr/PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll/PLAN_PR.md`
8+
- `docs/pr/PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll/BUILD_PR.md`
9+
- `docs/pr/PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll/APPLY_PR.md`
10+
- `docs/dev/codex_commands.md`
11+
- `docs/dev/commit_comment.txt`
12+
- `docs/dev/reports/PR_26124_061_report.md`
13+
- `tools/palette-manager-v2/index.html`
14+
- `tools/palette-manager-v2/modules/PaletteManagerApp.js`
15+
- `tools/palette-manager-v2/controls/PaletteEditorControl.js`
16+
- `tools/palette-manager-v2/controls/UserPaletteControl.js`
17+
- `tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js`
18+
- `tools/palette-manager-v2/paletteManagerV2.css`
19+
20+
## Validation
21+
- JavaScript syntax checks: PASS.
22+
- Targeted served-browser Palette Manager V2 selection clear, heading action placement, tag add, and source scroll preservation validation: PASS.
23+
- `git diff --check`: PASS with Git LF-to-CRLF warnings for changed Palette Manager files.
24+
- `npm run test:workspace-v2`: FAIL because the script is missing from `package.json`.
25+
- Full samples smoke test: skipped by instruction.
26+
27+
## Targeted Browser Coverage
28+
- `Undo` and `Redo` no longer appear in `menuSample`.
29+
- `Undo` and `Redo` appear in the User Palette accordion heading area.
30+
- `Source palette` and `Pin All` appear in the Sample Palette Swatch accordion heading area.
31+
- Normal Add Tag still adds a lowercase-normalized tag to the selected swatch.
32+
- Normal Add Tag applies a lowercase-normalized tag to checked User Palette swatches.
33+
- User Palette `Clear` clears checked swatch checkboxes.
34+
- Individual Sample Palette pin preserves the Sample Palette grid scroll position.
35+
- Pin All preserves the Sample Palette grid scroll position.
36+
37+
## Manual Test
38+
1. Open Palette Manager V2 through a local server.
39+
2. Confirm `Undo` and `Redo` are in the User Palette accordion heading area.
40+
3. Confirm `menuSample` contains only `Import JSON`, `Copy JSON`, and `Export JSON`.
41+
4. Confirm `Source palette` and `Pin All` are in the Sample Palette Swatch accordion heading area.
42+
5. Add a user swatch and add a mixed-case tag.
43+
6. Check two User Palette swatches and confirm the selected count updates.
44+
7. Click the User Palette `Clear` button and confirm both checkboxes clear.
45+
8. Add a tag and confirm tag Add behavior still applies to the selected swatch or checked swatches.
46+
9. Scroll the Sample Palette grid down and click an individual pin button.
47+
10. Confirm the Sample Palette grid does not jump back to the top.
48+
11. Scroll the Sample Palette grid down and click `Pin All`.
49+
12. Confirm the Sample Palette grid does not jump back to the top.
Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,19 @@
11
# git status --short
22
M docs/dev/codex_commands.md
33
M docs/dev/commit_comment.txt
4-
A docs/dev/reports/PR_26124_060_report.md
5-
M docs/dev/reports/codex_changed_files.txt
6-
M docs/dev/reports/codex_review.diff
7-
A docs/pr/PR_26124_060-palette-manager-undo-redo-and-multi-tag-select/APPLY_PR.md
8-
A docs/pr/PR_26124_060-palette-manager-undo-redo-and-multi-tag-select/BUILD_PR.md
9-
A docs/pr/PR_26124_060-palette-manager-undo-redo-and-multi-tag-select/PLAN_PR.md
10-
M tools/palette-manager-v2/controls/PaletteEditorControl.js
4+
A docs/dev/reports/PR_26124_061_report.md
5+
MM docs/dev/reports/codex_changed_files.txt
6+
MM docs/dev/reports/codex_review.diff
7+
A docs/pr/PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll/APPLY_PR.md
8+
A docs/pr/PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll/BUILD_PR.md
9+
A docs/pr/PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll/PLAN_PR.md
10+
M tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js
1111
M tools/palette-manager-v2/controls/UserPaletteControl.js
1212
M tools/palette-manager-v2/index.html
13-
A tools/palette-manager-v2/modules/PaletteHistoryStack.js
1413
M tools/palette-manager-v2/modules/PaletteManagerApp.js
15-
M tools/palette-manager-v2/modules/SwatchRow.js
1614
M tools/palette-manager-v2/paletteManagerV2.css
1715

1816
# git diff --stat
19-
docs/dev/reports/codex_changed_files.txt | 15 +-
20-
docs/dev/reports/codex_review.diff | 962 +++++++++++++++++++++++--------
21-
2 files changed, 737 insertions(+), 240 deletions(-)
17+
docs/dev/reports/codex_changed_files.txt | 8 +-
18+
docs/dev/reports/codex_review.diff | 1231 +++++++++++++++++++++++++++++-
19+
2 files changed, 1232 insertions(+), 7 deletions(-)

0 commit comments

Comments
 (0)