Skip to content

Commit 0683090

Browse files
author
DavidQ
committed
Fix Asset Manager V2 missing file tile state and keyboard navigation - PR_26126_102-asset-manager-v2-missing-file-tile-and-keyboard-fix
1 parent 7fdafef commit 0683090

11 files changed

Lines changed: 577 additions & 351 deletions

‎docs/dev/reports/PR_26126_102_asset_manager_v2_keyboard_navigation_notes.md‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# PR_26126_102 Asset Manager V2 Keyboard Navigation Notes
2+
3+
## Navigation Model
4+
- The Assets list is focusable.
5+
- The selected asset tile container is focusable.
6+
- Tile buttons remain focusable and clickable.
7+
- All handled keyboard navigation prevents default scrolling.
8+
9+
## Keys
10+
- ArrowLeft and ArrowUp select the previous rendered tile.
11+
- ArrowRight and ArrowDown select the next rendered tile.
12+
- PageUp selects the previous rendered tile.
13+
- PageDown selects the next rendered tile.
14+
- Home selects the first rendered tile.
15+
- End selects the last rendered tile.
16+
- Enter focuses/selects the current selected tile when the Assets list is focused.
17+
18+
## Selection Updates
19+
- Keyboard selection uses the same render path as mouse selection.
20+
- Selected tile styling, Selected Asset Detail, preview, and focus update together.
21+
22+
## Validation
23+
- Playwright validates arrow navigation from a tile button and from the Assets list.
24+
- Playwright validates Home from the selected tile container.
25+
- Playwright validates PageUp/PageDown prevent page scroll while changing selection.
26+
- Playwright validates Enter from the Assets list restores focus to the selected tile.

‎docs/dev/reports/PR_26126_102_asset_manager_v2_manual_validation_notes.md‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# PR_26126_102 Asset Manager V2 Manual Validation Notes
2+
3+
## Commands
4+
- `node --check tools/asset-manager-v2/js/controls/AssetCatalogControl.js`
5+
- `node --check tools/asset-manager-v2/js/AssetManagerV2App.js`
6+
- `node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs`
7+
- `git diff --check`
8+
- `npm run test:workspace-v2`
9+
10+
## Results
11+
- JavaScript syntax checks passed for changed runtime and Playwright files.
12+
- Required workspace-v2 Playwright gate passed: 12 tests passed.
13+
- `git diff --check` passed with no whitespace errors.
14+
- `docs/dev/reports/playwright_v8_coverage_report.txt` was regenerated by the required workspace-v2 validation run.
15+
16+
## Manual Checks Covered By Tests
17+
- Missing referenced files remain Status warnings with asset ID and path.
18+
- Missing referenced files do not fail otherwise valid imported JSON.
19+
- Missing file asset tiles render red `type:role` text.
20+
- Arrow keys work from a focused tile button and the Assets list.
21+
- Home, End, PageUp, PageDown, and Enter fallback navigation works where appropriate.
22+
- Keyboard selection updates selected tile styling, Selected Asset Detail, preview, and focus.
23+
- Sample JSON files were not modified.

‎docs/dev/reports/PR_26126_102_asset_manager_v2_missing_file_tile_notes.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# PR_26126_102 Asset Manager V2 Missing File Tile Notes
2+
3+
## Missing File State
4+
- Asset Manager V2 keeps a session-level set of asset IDs whose referenced files are unavailable.
5+
- Missing-file detection still runs after valid Workspace V2 asset load and NAV Import JSON.
6+
- Missing-file detection continues to log Status warnings with asset ID and original path.
7+
- Valid schema payloads are not rejected solely because a referenced file is unavailable.
8+
9+
## Tile Display
10+
- Missing file asset tiles receive `is-missing-file`.
11+
- The tile `type:role` text uses `--asset-manager-danger`, rendering as red.
12+
- Tile ID text, tooltip details, Selected Asset Detail, and Output Summary remain unchanged.
13+
14+
## Validation
15+
- Playwright validates imported missing file assets log Status warnings.
16+
- Playwright validates imported missing file asset tiles render red `type:role` text.

‎docs/dev/reports/codex_changed_files.txt‎

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,21 @@ M docs/dev/reports/coverage_changed_js_guardrail.txt
44
M tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
55
M tools/asset-manager-v2/js/AssetManagerV2App.js
66
M tools/asset-manager-v2/js/controls/AssetCatalogControl.js
7-
M tools/asset-manager-v2/js/controls/AssetFormControl.js
87
M tools/asset-manager-v2/styles/assetManager.css
9-
?? docs/dev/reports/PR_26126_101_asset_manager_v2_keyboard_navigation_notes.md
10-
?? docs/dev/reports/PR_26126_101_asset_manager_v2_manual_validation_notes.md
11-
?? docs/dev/reports/PR_26126_101_asset_manager_v2_missing_file_logging_notes.md
12-
?? docs/dev/reports/PR_26126_101_asset_manager_v2_selected_swatch_notes.md
8+
?? docs/dev/reports/PR_26126_102_asset_manager_v2_keyboard_navigation_notes.md
9+
?? docs/dev/reports/PR_26126_102_asset_manager_v2_manual_validation_notes.md
10+
?? docs/dev/reports/PR_26126_102_asset_manager_v2_missing_file_tile_notes.md
1311

1412
# git ls-files --others --exclude-standard
15-
docs/dev/reports/PR_26126_101_asset_manager_v2_keyboard_navigation_notes.md
16-
docs/dev/reports/PR_26126_101_asset_manager_v2_manual_validation_notes.md
17-
docs/dev/reports/PR_26126_101_asset_manager_v2_missing_file_logging_notes.md
18-
docs/dev/reports/PR_26126_101_asset_manager_v2_selected_swatch_notes.md
13+
docs/dev/reports/PR_26126_102_asset_manager_v2_keyboard_navigation_notes.md
14+
docs/dev/reports/PR_26126_102_asset_manager_v2_manual_validation_notes.md
15+
docs/dev/reports/PR_26126_102_asset_manager_v2_missing_file_tile_notes.md
1916

2017
# git diff --stat
21-
docs/dev/reports/coverage_changed_js_guardrail.txt | 4 ++-
22-
docs/dev/reports/playwright_v8_coverage_report.txt | 12 +++++---
23-
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 25 ++++++++++++++++
24-
tools/asset-manager-v2/js/AssetManagerV2App.js | 33 ++++++++++++++++++--
25-
.../js/controls/AssetCatalogControl.js | 35 ++++++++++++++++++++++
26-
.../js/controls/AssetFormControl.js | 4 ++-
27-
tools/asset-manager-v2/styles/assetManager.css | 9 ++++++
28-
7 files changed, 114 insertions(+), 8 deletions(-)
18+
docs/dev/reports/coverage_changed_js_guardrail.txt | 7 +-
19+
docs/dev/reports/playwright_v8_coverage_report.txt | 16 ++--
20+
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 43 ++++++++++
21+
tools/asset-manager-v2/js/AssetManagerV2App.js | 20 ++++-
22+
.../js/controls/AssetCatalogControl.js | 93 ++++++++++++++++------
23+
tools/asset-manager-v2/styles/assetManager.css | 4 +
24+
6 files changed, 138 insertions(+), 45 deletions(-)

0 commit comments

Comments
 (0)