Skip to content

Commit 0138f65

Browse files
author
DavidQ
committed
standardize phase-13 sample network imports against normalized network structure — BUILD_PR_LEVEL_12_9_NETWORK_USAGE_SAMPLE_STANDARDIZATION
1 parent 1e55f4b commit 0138f65

5 files changed

Lines changed: 150 additions & 7 deletions

docs/dev/CODEX_COMMANDS.md

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,17 @@
1-
MODEL: GPT-5.3-codex
1+
MODEL: GPT-5.4
22
REASONING: high
33
COMMAND:
4-
Prepare sample standardization plan using normalized network structure.
5-
No feature expansion.
4+
Implement BUILD_PR_LEVEL_12_9_NETWORK_USAGE_SAMPLE_STANDARDIZATION exactly as defined.
5+
Standardize the targeted phase-13 sample scenes so they consume the network API via src/engine/network/index.js only.
6+
Remove deep or legacy flat network-path usage in the targeted sample set where present.
7+
Do not change sample behavior, controls, timing, outputs, or runtime logic.
8+
If needed, update src/engine/network/index.js export coverage so sample behavior stays unchanged.
9+
Run real validation:
10+
- import/path resolution for all targeted samples
11+
- network runtime smoke boot
12+
- transport/session lifecycle smoke
13+
- authoritative runtime boot smoke
14+
- replication/apply smoke
15+
- focused 2D regression smoke
16+
Update docs/dev/roadmaps/MASTER_ROADMAP_HIGH_LEVEL.md by changing status markers only.
17+
Do not modify roadmap wording, structure, add content, or delete content.

docs/dev/COMMIT_COMMENT.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
define canonical network validation sample — PLAN_PR_LEVEL_12_9_NETWORK_USAGE_SAMPLE_STANDARDIZATION
1+
standardize phase-13 sample network imports against normalized network structure — BUILD_PR_LEVEL_12_9_NETWORK_USAGE_SAMPLE_STANDARDIZATION
Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1-
- canonical sample defined
2-
- scope controlled
3-
- aligned with normalized structure
1+
- target sample set locked
2+
- import policy locked to src/engine/network/index.js
3+
- no feature expansion allowed
4+
- testable validation requirements included
5+
- roadmap updates constrained to marker-only progression
Lines changed: 88 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,88 @@
1+
# BUILD_PR_LEVEL_12_9_NETWORK_USAGE_SAMPLE_STANDARDIZATION
2+
3+
## Build Scope
4+
Standardize network-usage sample imports against the normalized network structure while keeping sample behavior unchanged.
5+
6+
## One PR Purpose Only
7+
Network usage sample standardization only.
8+
9+
## Source Standard
10+
Use the normalized network structure as the standard:
11+
- `src/engine/network/transport/`
12+
- `src/engine/network/session/`
13+
- `src/engine/network/server/`
14+
- `src/engine/network/client/`
15+
- `src/engine/network/replication/`
16+
- `src/engine/network/bootstrap/`
17+
- `src/engine/network/debug/`
18+
19+
## Import Policy
20+
All targeted sample scenes must consume the network API through:
21+
- `src/engine/network/index.js`
22+
23+
Do not import network internals through deep sample-facing paths unless `index.js` already re-exports them.
24+
If required, update `src/engine/network/index.js` export coverage to preserve sample behavior without changing sample runtime logic.
25+
26+
## Targets
27+
- `samples/phase-13/1301/NetworkingLayerScene.js`
28+
- `samples/phase-13/1302/StateSyncReplicationScene.js`
29+
- `samples/phase-13/1304/ClientPredictionReconciliationScene.js`
30+
- `samples/phase-13/1305/SerializationSystemScene.js`
31+
- `samples/phase-13/1306/NetworkDebugOverlayScene.js`
32+
- `samples/phase-13/1307/RemoteEntityInterpolationScene.js`
33+
- `samples/phase-13/1308/LobbySessionSystemScene.js`
34+
- `samples/phase-13/1310/HostServerBootstrapScene.js`
35+
- `samples/phase-13/1311/InterestManagementScene.js`
36+
- `samples/phase-13/1312/LagPacketLossSimulationScene.js`
37+
- `samples/phase-13/1314/ChatPresenceLayerScene.js`
38+
- `samples/phase-13/1315/RollbackReplayDiagnosticsScene.js`
39+
40+
## Required Implementation Rules
41+
1. Lock sample network imports to `src/engine/network/index.js`
42+
2. Remove deep or legacy flat-path usage where present
43+
3. Keep scene behavior, controls, timing, outputs, and runtime logic exactly as-is
44+
4. Normalize sample metadata/docs path references only where needed for structural accuracy
45+
5. Do not expand features
46+
6. Do not rewrite scene logic beyond import/path normalization
47+
48+
## Testable PR Requirement
49+
This PR must remain testable and must not be commit-only.
50+
51+
## Validation Plan
52+
### Import / Path Resolution
53+
- confirm all target sample files resolve network imports through `src/engine/network/index.js`
54+
- confirm no stale deep/legacy flat imports remain in the targeted sample set
55+
56+
### Runtime Smoke
57+
- network runtime smoke boot
58+
- transport/session lifecycle smoke
59+
- authoritative runtime boot smoke
60+
- replication/apply smoke
61+
62+
### Regression Protection
63+
- focused 2D regression smoke
64+
- no sample behavior drift in targeted phase-13 scenes
65+
66+
## Roadmap Rule
67+
Update:
68+
`docs/dev/roadmaps/MASTER_ROADMAP_HIGH_LEVEL.md`
69+
70+
Allowed:
71+
- status markers only: `[ ]` `[.]` `[x]`
72+
73+
Forbidden:
74+
- wording edits
75+
- structure edits
76+
- additions
77+
- deletions
78+
79+
## Marker Progress
80+
- planning step: no marker change
81+
- BUILD/APPLY: marker-only updates based strictly on execution-backed evidence
82+
83+
## Acceptance Criteria
84+
- all targeted samples use the standardized network import policy
85+
- no targeted sample behavior changes
86+
- runtime smoke validations pass
87+
- focused 2D regression smoke passes
88+
- roadmap updated by marker only if execution-backed validation succeeds
Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
# BUILD_PR_LEVEL_12_9_NETWORK_USAGE_SAMPLE_STANDARDIZATION_EVIDENCE
2+
3+
## Scope Result
4+
- Standardization target set validated against normalized network usage policy.
5+
- No feature or runtime logic changes were introduced.
6+
- No targeted sample scene code changes were required because all targeted files were already compliant.
7+
8+
## Targeted Sample Import Policy Validation
9+
- Timestamp (UTC): `2026-04-15T15:03:49.299Z`
10+
- Target files checked: `12`
11+
- Policy required: network imports must use `/src/engine/network/index.js` only.
12+
- Result:
13+
- `allPolicyCompliant=true`
14+
- `12/12` targeted files imported network API via `/src/engine/network/index.js`
15+
- `badNetworkImports=[]` for all targeted files
16+
- Module resolution:
17+
- `allPassed=true`
18+
- `12/12` targeted sample modules imported successfully with repo alias resolution enabled
19+
20+
## Runtime Smoke Validation
21+
- Timestamp (UTC): `2026-04-15T15:04:13.434Z`
22+
- Result: `allPassed=true` (`4/4`)
23+
- Checks:
24+
- `network_runtime_smoke_boot`: pass (`receivedCount=1`)
25+
- `transport_session_lifecycle_smoke`: pass
26+
- `authoritative_runtime_boot_smoke`: pass (`ticksAdvanced=2`)
27+
- `replication_apply_smoke`: pass (`entities=1`)
28+
29+
## Focused 2D Regression Smoke
30+
- Result:
31+
- `PASS Engine2DCapabilityCombinedFoundation`
32+
- `PASS EngineCoreBoundaryBaseline`
33+
- `PASS AsteroidsValidation`
34+
35+
## Export Surface Note
36+
- `src/engine/network/index.js` export coverage was sufficient for the targeted sample set.
37+
- No `index.js` export changes were required to preserve behavior.
38+
39+
## Roadmap Marker Handling
40+
- Marker-only rule respected.
41+
- No marker change was required for this BUILD because relevant network/sample normalization markers were already at `[x]`.

0 commit comments

Comments
 (0)