Recovery audit from 20.1 baseline

PR Details:
- Uses 3f7e9df / BUILD_PR_LEVEL_20_1_PHASE20_TOOL_PRESET_INTEGRATION as the last known assistant-produced baseline.
- Audits all later changes.
- Documents anti-patterns and junk code.
- Produces reset-vs-surgical-cleanup decision.
- Forbids destructive reset in this PR.

Author: DavidQ

docs/dev/codex_rules.md

@@ -1,94 +1,59 @@
 # Codex Rules (MANDATORY — HARD CONSTRAINTS)
 
-These rules OVERRIDE all other task instructions except correctness and explicit user safety constraints.
+These rules OVERRIDE all other instructions.
 If any rule is violated, the output is incorrect.
 
 Codex must prefer the existing repo pattern over any new pattern, unless the PR explicitly says otherwise.
 
-## Core Principles
-- Follow the requested task exactly.
-- One PR purpose only.
-- Smallest scoped valid change.
-- No repo-wide rewrites unless explicitly required by the task.
-- Do not introduce behavior that was not explicitly requested.
-- Do not modify `start_of_day` folders.
+## Baseline
+
+The last known assistant-produced baseline is:
+
+- commit: `3f7e9df`
+- PR: `BUILD_PR_LEVEL_20_1_PHASE20_TOOL_PRESET_INTEGRATION`
+
+All recovery analysis must compare current repo state against this baseline.
+
+## Recovery Safety
+
+- Do NOT run destructive git commands.
+- Do NOT run `git reset --hard`.
+- Do NOT delete files.
+- Do NOT modify implementation files in this PR.
+- Do NOT rewrite roadmap text.
+- Do NOT modify `start_of_day` folders.
+- Do NOT invent fallback/default behavior.
+- Do NOT preserve junk code silently.
+
+## Anti-Patterns Strictly Forbidden
+
+- variable aliasing: one concept renamed into another variable
+- pass-through variables
+- duplicate state
+- stored derived state
+- vague names such as data, temp, obj, item, thing, value
+- hidden fallback behavior
+- default behavior where explicit routing is required
+- broad truthy/falsy checks that alter behavior
+- magic strings or magic numbers
+- duplicate event listeners
+- globals
+- new managers/factories/service layers unless explicitly requested
+- route/URL/ID/label changes unless explicitly requested
+- public API changes unless explicitly requested
+- unrelated cleanup
+- unrelated refactoring
+- scope expansion
+- duplicated launch paths
+- sample/game launch bypasses
+- workspace launch memory carryover from external entry
+
+## Validation
 
-## Naming / Data Flow
-- One concept = one name.
-- Do not create alias variables or name remapping chains.
-- Do not copy variables into new variables unless data is transformed.
-- Do not rename the same concept across files.
-- Do not use vague names such as `data`, `temp`, `obj`, `item`, `thing`, `value`, or `result` unless the scope is tiny and obvious.
-- Do not introduce adapter names unless the PR explicitly requires adapters.
-- Do not create duplicate state for the same value.
-- Do not store derived state when it can be computed directly.
-
-## Variables
-- No temporary pass-through variables.
-- No `a -> b -> c` assignment chains.
-- Only introduce variables when they transform data, clarify a complex expression, or are required for control flow.
-
-## Scope Creep
-- Do not fix unrelated bugs.
-- Do not clean up unrelated files.
-- Do not modernize code unless requested.
-- Do not change public APIs unless the PR explicitly requires it.
-- Do not change folder structure unless the PR explicitly requires it.
-
-## Control Flow
-- Do not add hidden fallback behavior.
-- Do not swallow errors silently.
-- Do not replace explicit checks with broad truthy/falsy checks when behavior could change.
-- Do not add global flags to control local behavior.
-- Do not introduce magic strings or magic numbers.
-- Do not add defaults/fallbacks for tool launch data; missing required SSoT data must fail validation visibly.
-
-## Architecture
-- Do not add a new framework, library, dependency, build tool, or pattern.
-- Do not introduce service layers, registries, managers, factories, or abstractions unless explicitly requested.
-- Do not create future-proof extension points.
-- Do not split files only for style.
-
-## UI / Navigation
-- Do not change existing tile behavior unless the PR is specifically about that tile.
-- Do not change route names, URLs, IDs, labels, or menu text unless requested.
-- Do not create duplicate launch paths for the same tool.
-- Do not bypass existing navigation conventions.
-- Samples must launch tools through `tools/<tool>/index.html`.
-- Games must launch Workspace Manager through `tools/Workspace Manager/index.html`.
-- External launches from samples or games must clear prior tool/workspace memory before loading the requested tool or workspace.
-
-## Testing / Validation
-- Do not mark work complete without a concrete test path.
-- Do not claim browser-tested behavior unless actually tested.
-- Do not remove existing tests or validation hooks.
-- Do not weaken tests to make changes pass.
-
-## Repo Safety
-- Do not modify `start_of_day` folders.
-- Do not delete legacy folders unless explicitly instructed.
-- Do not touch roadmap text except status markers `[ ]`, `[.]`, `[x]`.
-- Do not rewrite documentation outside the PR scope.
-
-## JavaScript-Specific
-- Do not use `var`.
-- Do not create globals.
-- Do not mutate imported/shared config objects.
-- Do not rely on implicit type coercion.
-- Do not use loose equality `==` or `!=`.
-- Do not add async behavior unless needed.
-- Do not mix DOM querying and business logic if existing code separates them.
-- Do not duplicate event listeners.
-- Do not attach handlers repeatedly inside render/update loops.
-
-## Validation Required Before Finish
 Before completing, verify:
-- No alias variables exist.
-- No unnecessary variables were introduced.
-- No scope expansion occurred.
-- Code matches existing repo patterns.
-- Only requested changes were made.
-- Launch data comes from a single source of truth.
-- No default/fallback launch entries remain for tools.
 
-If any violation exists, fix it before returning output.
+- no implementation files changed
+- no destructive command used
+- all required reports exist
+- reset recommendation is explicit
+- all identified anti-patterns include file paths

docs/dev/reports/recovery_antipattern_audit_from_20_1.md

@@ -0,0 +1,78 @@
+# Placeholder
+
+Codex must replace this file during execution.
+# Recovery Anti-Pattern Audit From 20.1 Baseline
+
+## Audit Basis
+- Baseline: `3f7e9df`
+- HEAD: `5e5e5f12`
+- Rules source: `docs/dev/codex_rules.md`
+- Evidence sources: `git log`, `git diff --stat`, `git diff --name-status`, targeted file inspection
+
+## Findings (Ordered by Severity)
+
+### High - Scope Expansion Beyond Recovery Lane
+- Evidence:
+  - `125` commits after baseline
+  - `488` files changed
+  - `35,818` insertions / `4,946` deletions
+  - Cross-domain impact includes `docs`, `samples`, `tools`, `games`, `src`, and `tests`
+- Why this is an anti-pattern:
+  - Violates smallest-scoped recovery objective.
+  - Introduces high uncertainty for root-cause recovery and validation.
+
+### High - Start-of-Day Boundary Touched
+- File:
+  - `docs/dev/start_of_day/codex/PROJECT_INSTRUCTIONS.lnk` (`A` after baseline)
+- Why this is an anti-pattern:
+  - Recovery rules explicitly protect `start_of_day` content from unrelated edits.
+
+### High - Broad Unrelated Deletion/Rename Churn
+- Evidence:
+  - `54` deletions and `8` renames in baseline diff.
+  - Large deletion set under `samples/phase-20/*/index.html`.
+  - Tool identity rename path:
+    - `tools/3D Map Editor/*` to `tools/3D JSON Payload Normalizer/*`
+- Why this is an anti-pattern:
+  - Recovery lane is launch-path stabilization, not broad content pruning or feature renaming.
+
+### High - Duplicate Source-of-Truth Vocabulary
+- Evidence:
+  - `samples/index.render.js` still consumes `toolHints`.
+  - `games/index.render.js` consumes `toolsUsed`.
+  - `tools/Workspace Manager/main.js` consumes `toolsUsed`.
+- Why this is an anti-pattern:
+  - Introduces dual metadata semantics for tool launch eligibility.
+  - Increases risk of mismatch between games and samples launch routing.
+
+### Medium - Launch Path Complexity Drift
+- Evidence in UAT core files:
+  - `games/index.render.js` expanded launch behavior and click routing logic.
+  - `samples/index.render.js` expanded roundtrip link construction and launch/error handling.
+  - `tools/Workspace Manager/main.js` includes extensive forwarded query handling and host-mode branching.
+- Why this is an anti-pattern:
+  - Recovery lane requires clarity and deterministic launch routing.
+  - Complexity growth increases likelihood of hidden fallback behavior and regressions.
+
+### Medium - Roadmap Surface Proliferation Outside Master Engine File
+- Evidence:
+  - Added `docs/dev/roadmaps/MASTER_ROADMAP_SAMPLES2TOOLS.md` after baseline.
+  - Engine roadmap file is unchanged in this delta, but additional roadmap surface introduces governance drift.
+- Why this is an anti-pattern:
+  - Recovery efforts benefit from a single authoritative roadmap surface.
+
+### Low - Diff Hygiene Issues
+- Evidence from `git diff --check`:
+  - New blank line at EOF in:
+    - `docs/dev/reports/BUILD_PR_LEVEL_20_2_WORKSPACE_MANAGER_GAMES_TILE_UAT_RECOVERY_uat_report.md`
+    - `docs/dev/reports/tool_launch_ssot_external_memory_reset_validation.md`
+    - `samples/phase-12/1208/data/toolFormattedTileMap.js`
+    - `tools/shared/toolLaunchSSoT.js`
+- Why this matters:
+  - Not functionally critical, but indicates review hygiene inconsistency.
+
+## Anti-Pattern Summary
+- Recovery lane contamination is substantial.
+- UAT launch-path changes are not isolated.
+- Multiple independent feature/doc/structure lanes were combined post-baseline.
+- Overall profile strongly favors reset-first recovery over surgical edits on current HEAD.

docs/dev/reports/recovery_change_audit_from_20_1.md

@@ -0,0 +1,121 @@
+# Placeholder
+
+Codex must replace this file during execution.
+# Recovery Change Audit From 20.1 Baseline
+
+## Scope
+- Baseline commit: `3f7e9df`
+- Baseline PR: `BUILD_PR_LEVEL_20_1_PHASE20_TOOL_PRESET_INTEGRATION`
+- Current HEAD: `5e5e5f12575f9576745cf57827e6f40abc98812b`
+- Branch: `main`
+- Audit mode: reports only (no implementation edits, no reset, no deletions)
+
+## Required Command Capture
+
+### 1) `git status --short`
+```text
+ M docs/dev/codex_rules.md
+ M docs/operations/dev/codex_commands.md
+ M docs/operations/dev/commit_comment.txt
+?? docs/dev/reports/recovery_antipattern_audit_from_20_1.md
+?? docs/dev/reports/recovery_change_audit_from_20_1.md
+?? docs/dev/reports/recovery_file_risk_list_from_20_1.md
+?? docs/dev/reports/recovery_reset_decision_from_20_1.md
+?? docs/pr/BUILD_PR_LEVEL_20_5_RECOVERY_AUDIT_FROM_20_1_BASELINE.md
+```
+
+### 2) `git branch --show-current`
+```text
+main
+```
+
+### 3) `git rev-parse HEAD`
+```text
+5e5e5f12575f9576745cf57827e6f40abc98812b
+```
+
+### 4) `git log 3f7e9df..HEAD --oneline --decorate --name-status`
+```text
+Captured. Output is large (1000+ lines) and confirms a broad multi-lane change stream after baseline.
+Top commit: 5e5e5f12 (HEAD -> main) Normalize tool and workspace tile launch routing through SSoT
+Includes many unrelated lanes (samples2tools, skin editor, 3D rename, docs/roadmaps, tool UX, metadata rewrites).
+```
+
+### 5) `git diff --stat 3f7e9df..HEAD`
+```text
+488 files changed, 35818 insertions(+), 4946 deletions(-)
+```
+
+### 6) `git diff --name-status 3f7e9df..HEAD`
+```text
+Captured. Mix of large additions, modifications, renames, and deletions.
+Status totals:
+- M: 167
+- A: 259
+- R: 8
+- D: 54
+```
+
+### 7) `git diff --check 3f7e9df..HEAD`
+```text
+docs/dev/reports/BUILD_PR_LEVEL_20_2_WORKSPACE_MANAGER_GAMES_TILE_UAT_RECOVERY_uat_report.md:44: new blank line at EOF.
+docs/dev/reports/tool_launch_ssot_external_memory_reset_validation.md:69: new blank line at EOF.
+samples/phase-12/1208/data/toolFormattedTileMap.js:4116: new blank line at EOF.
+tools/shared/toolLaunchSSoT.js:140: new blank line at EOF.
+```
+
+### 8) `git ls-files --others --exclude-standard`
+```text
+docs/dev/reports/recovery_antipattern_audit_from_20_1.md
+docs/dev/reports/recovery_change_audit_from_20_1.md
+docs/dev/reports/recovery_file_risk_list_from_20_1.md
+docs/dev/reports/recovery_reset_decision_from_20_1.md
+docs/pr/BUILD_PR_LEVEL_20_5_RECOVERY_AUDIT_FROM_20_1_BASELINE.md
+```
+
+## Aggregate Metrics
+- Commits after baseline: `125`
+- File churn: `488 files`
+- Insertions/deletions: `+35,818 / -4,946`
+- Top-level area impact count:
+  - `docs`: 162
+  - `samples`: 162
+  - `tools`: 84
+  - `games`: 61
+  - `src`: 10
+  - `tests`: 4
+
+## UAT-Relevant File Inspection
+
+### Direct files requested
+- `games/index.html`: present and modified vs baseline (`M`)
+- `samples/index.html`: present and modified vs baseline (`M`)
+- `tools/Workspace Manager/index.html`: present, no baseline diff (`unchanged`)
+- `docs/dev/roadmaps/MASTER_ROADMAP_ENGINE.md`: present, no baseline diff (`unchanged`)
+
+### `tools/*/index.html` inspection
+- Enumerated 19 tool index files under `tools/`
+- Baseline deltas for tool index files:
+  - `R078 tools/3D Map Editor/index.html -> tools/3D JSON Payload Normalizer/index.html`
+  - `M tools/Asset Pipeline Tool/index.html`
+  - `M tools/Palette Browser/index.html`
+  - `M tools/Parallax Scene Studio/index.html`
+  - `A tools/Skin Editor/index.html`
+  - `M tools/Sprite Editor/index.html`
+  - `M tools/Tilemap Studio/index.html`
+  - `M tools/Vector Map Editor/index.html`
+
+## UAT Path Delta Snapshot
+```text
+games/index.html                |  32 +--
+games/index.render.js           | 214 +++++++++++++++++--
+samples/index.html              |  33 ++-
+samples/index.render.js         | 224 ++++++++++++++++++-
+tools/Workspace Manager/main.js | 460 +++++++++++++++++++++++++++++++++++-----
+5 files changed, 843 insertions(+), 120 deletions(-)
+```
+
+## Initial Audit Conclusion
+- Change volume and blast radius are substantially beyond a narrow recovery lane.
+- UAT-relevant launch paths are embedded within large parallel changes across tools, samples, docs, and metadata.
+- A reset-first recovery path is likely safer than surgical cleanup from current HEAD.