Skip to content

test: cover ARM fee collection after market recovery#239

Open
m0n3r0 wants to merge 1 commit into
OriginProtocol:mainfrom
m0n3r0:hermes/arm-fee-recovery-temporal-test-20260523
Open

test: cover ARM fee collection after market recovery#239
m0n3r0 wants to merge 1 commit into
OriginProtocol:mainfrom
m0n3r0:hermes/arm-fee-recovery-temporal-test-20260523

Conversation

@m0n3r0
Copy link
Copy Markdown

@m0n3r0 m0n3r0 commented May 22, 2026

Summary

This PR adds regression coverage for ARM fee accounting after a withdrawal request is haircut by a market loss and the market later recovers.

Changes

  • Adds a unit test for requestRedeem -> market loss -> haircut claim -> new deposit -> market recovery -> collectFees.
  • Verifies recovery accrues a positive bounded fee, collection advances the fee baseline, and the already-claimed request remains closed.
  • Verifies fee collection does not reopen or perturb withdrawal-queue accounting.

Testing

  • forge test --match-path test/unit/OriginARM/ClaimRedeem.sol --match-test test_ClaimRedeem_WithFee_AfterMarketRecoveryCollectsOnlyRecoveryGain -vv
  • forge test --match-path 'test/unit/OriginARM/*.sol' -vv

Notes

Defensive regression coverage only; no sensitive vulnerability details are included.

@m0n3r0 m0n3r0 force-pushed the hermes/arm-fee-recovery-temporal-test-20260523 branch from 1c2a1c6 to e13a193 Compare May 22, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant