From 625d2c0e0aa72a3b980ee200910687deed011589 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 19 May 2026 10:41:37 +0000 Subject: [PATCH] fix(docker): drop stale ARG GITHUB_TOKEN reintroduced by template merge MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The setup-build-system stage declared ARG GITHUB_TOKEN at the top, even though the token is only used in run-app (gh release download). Since CI passes a per-run secrets.GITHUB_TOKEN via --build-arg and that value changes every workflow run, the ARG invalidated every layer downstream in setup-build-system and compile-openms — apt-get update and all package installs re-ran from scratch on every PR/push. This is the same fix as 859e481 ("fix(docker): stop cache-busting on GITHUB_TOKEN"); the merge in a723fb5 left both copies of the ARG in place (the redundant one at line 34 and the one actually needed in run-app at line 217). Keep only the run-app declaration. Applies to both Dockerfile and Dockerfile.arm. --- Dockerfile | 2 -- Dockerfile.arm | 2 -- 2 files changed, 4 deletions(-) diff --git a/Dockerfile b/Dockerfile index dc7fe2f..48de566 100644 --- a/Dockerfile +++ b/Dockerfile @@ -30,8 +30,6 @@ COPY --from=js-build openms-streamlit-vue-component/dist /app/js-component/dist ARG OPENMS_REPO=https://github.com/t0mdavid-m/OpenMS.git ARG OPENMS_BRANCH=FVdeploy ARG PORT=8501 -# GitHub token to download latest OpenMS executable for Windows from Github action artifact. -ARG GITHUB_TOKEN # Streamlit app Gihub user name (to download artifact from). ARG GITHUB_USER=OpenMS # Streamlit app Gihub repository name (to download artifact from). diff --git a/Dockerfile.arm b/Dockerfile.arm index 92c9c84..21de038 100644 --- a/Dockerfile.arm +++ b/Dockerfile.arm @@ -30,8 +30,6 @@ COPY --from=js-build openms-streamlit-vue-component/dist /app/js-component/dist ARG OPENMS_REPO=https://github.com/t0mdavid-m/OpenMS.git ARG OPENMS_BRANCH=FVdeploy ARG PORT=8501 -# GitHub token to download latest OpenMS executable for Windows from Github action artifact. -ARG GITHUB_TOKEN # Streamlit app Gihub user name (to download artifact from). ARG GITHUB_USER=OpenMS # Streamlit app Gihub repository name (to download artifact from).