From 59205b85d66cb12dd503e7fce3e45da2654adec0 Mon Sep 17 00:00:00 2001 From: Brian Shand Date: Tue, 21 Oct 2025 22:33:57 +0100 Subject: [PATCH 1/2] Support Ruby 3.4. Drop support for Rails 7.0, Ruby 3.1 --- .github/workflows/test.yml | 4 ++-- CHANGELOG.md | 3 ++- gemfiles/Gemfile.rails70 | 5 ----- ndr_lookup.gemspec | 4 ++-- 4 files changed, 6 insertions(+), 10 deletions(-) delete mode 100644 gemfiles/Gemfile.rails70 diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ab6dc19..40a9d3b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -5,13 +5,13 @@ on: [push] jobs: test: strategy: + fail-fast: false matrix: ruby-version: - - '3.1' - '3.2' - '3.3' + - '3.4' gemfile: - - gemfiles/Gemfile.rails70 - gemfiles/Gemfile.rails71 - gemfiles/Gemfile.rails72 - gemfiles/Gemfile.rails80 diff --git a/CHANGELOG.md b/CHANGELOG.md index 91a2fc2..969242e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ ## [Unreleased] -* no unreleased changes +### Fixed +* Support Ruby 3.4. Drop support for Rails 7.0, Ruby 3.1 ## 0.1.4 / 2025-09-19 ### Added diff --git a/gemfiles/Gemfile.rails70 b/gemfiles/Gemfile.rails70 deleted file mode 100644 index 759f44a..0000000 --- a/gemfiles/Gemfile.rails70 +++ /dev/null @@ -1,5 +0,0 @@ -source 'https://rubygems.org' - -gemspec path: '..' - -gem 'activesupport', '~> 7.0.0' diff --git a/ndr_lookup.gemspec b/ndr_lookup.gemspec index 15d6d4c..1ec20b6 100644 --- a/ndr_lookup.gemspec +++ b/ndr_lookup.gemspec @@ -22,7 +22,7 @@ Gem::Specification.new do |spec| spec.require_paths = ['lib'] spec.add_dependency 'activeresource', '>= 6.0', '< 7' - spec.add_dependency 'activesupport', '>= 7.0', '< 8.1' + spec.add_dependency 'activesupport', '>= 7.1', '< 8.1' spec.add_dependency 'httpi', '~> 4.0' spec.add_dependency 'rubyntlm', '~> 0.6' @@ -32,5 +32,5 @@ Gem::Specification.new do |spec| spec.add_development_dependency 'rake', '>= 12.3.3' spec.add_development_dependency 'webmock' - spec.required_ruby_version = '>= 3.0' + spec.required_ruby_version = '>= 3.2' end From 507e11b6d73585b27bcd48863dab58577881d9f8 Mon Sep 17 00:00:00 2001 From: Brian Shand Date: Wed, 22 Oct 2025 10:14:02 +0100 Subject: [PATCH 2/2] Support ruby 3.4 --- .github/workflows/lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 81c7841..4380a00 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -15,7 +15,7 @@ jobs: - name: Set up Ruby uses: ruby/setup-ruby@v1 with: - ruby-version: 3.0 + ruby-version: 3.4 - name: Install dependencies run: bundle install - name: Run RuboCop against BASE..HEAD changes