From 31cd2e41f8d604dd288077902574f557993b7dcf Mon Sep 17 00:00:00 2001 From: Rikki Date: Wed, 24 Sep 2025 16:36:12 +0100 Subject: [PATCH 1/2] Fix Organisation.all test for lazy evaluation in ActiveResource --- test/nhsd_ods/organisation_test.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/nhsd_ods/organisation_test.rb b/test/nhsd_ods/organisation_test.rb index e3c4686..c16f777 100644 --- a/test/nhsd_ods/organisation_test.rb +++ b/test/nhsd_ods/organisation_test.rb @@ -20,7 +20,7 @@ def test_should_raise_error_if_not_valid_find_method stub_request(:get, url).to_return(file) assert_raises do - NdrLookup::NhsdOds::Organisation.all + NdrLookup::NhsdOds::Organisation.any? end end end From 2b3e47230e7f873baf03e8f100ae6606add2924b Mon Sep 17 00:00:00 2001 From: Rikki Date: Wed, 24 Sep 2025 16:41:09 +0100 Subject: [PATCH 2/2] Rubocop on fix --- test/nhsd_ods/organisation_test.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/nhsd_ods/organisation_test.rb b/test/nhsd_ods/organisation_test.rb index c16f777..d49d96c 100644 --- a/test/nhsd_ods/organisation_test.rb +++ b/test/nhsd_ods/organisation_test.rb @@ -6,8 +6,8 @@ module NhsdOds # The orgaisation class tests class OrganisationTest < Minitest::Test def test_organisation_should_have_model_like_behaviour - url = ODS_ENDPOINT + 'organisations/X26' - file = File.new(RESPONSES_DIR + '/nhsd_ods/organisation_find_success_response.txt') + url = "#{ODS_ENDPOINT}organisations/X26" + file = File.new("#{RESPONSES_DIR}/nhsd_ods/organisation_find_success_response.txt") stub_request(:get, url).to_return(file) org = NdrLookup::NhsdOds::Organisation.find('X26') @@ -15,8 +15,8 @@ def test_organisation_should_have_model_like_behaviour end def test_should_raise_error_if_not_valid_find_method - url = ODS_ENDPOINT + 'organisations' - file = File.new(RESPONSES_DIR + '/nhsd_ods/organisation_all_not_acceptable_response.txt') + url = "#{ODS_ENDPOINT}organisations" + file = File.new("#{RESPONSES_DIR}/nhsd_ods/organisation_all_not_acceptable_response.txt") stub_request(:get, url).to_return(file) assert_raises do