Skip to content

[codex] fix effect v4 review findings#43

Open
Makisuo wants to merge 2 commits into
mainfrom
codex/run-effect-v4-review
Open

[codex] fix effect v4 review findings#43
Makisuo wants to merge 2 commits into
mainfrom
codex/run-effect-v4-review

Conversation

@Makisuo
Copy link
Copy Markdown
Owner

@Makisuo Makisuo commented May 16, 2026

Summary

Applies the whole-repo Effect v4 review fixes across Maple product code.

  • Updates Effect service/layer wiring to prefer .layer and keeps local runtime composition aligned across API and alerting workers.
  • Tightens Effect v4 conventions around Effect.fn, generator failures, Clock.currentTimeMillis, tagged errors, structured log annotations, and flattened Cause.pretty handling.
  • Migrates schema request shapes toward v4 APIs with Schema.optionalKey, branded Hazel/trace/span IDs, and explicit frontend decode boundaries.
  • Improves observability conventions, including dual-emitting deployment.environment and deployment.environment.name plus stable annotated log messages.
  • Fixes Effect Atom/UI findings by avoiding render-time Atom.make and surfacing explicit Result failure states in settings/install flows.
  • Adds local TypeScript path mappings for SDK source subpaths so workspace typechecking does not require prebuilt SDK dist output.

Impact

This should reduce Effect v4 migration risk, make schema/API boundaries more precise, and keep telemetry/logging behavior aligned with Maple conventions without changing public runtime behavior intentionally.

Validation

  • bun run typecheck
  • git diff --check

@Makisuo Makisuo marked this pull request as ready for review May 17, 2026 11:42
@pullfrog
Copy link
Copy Markdown

pullfrog Bot commented May 17, 2026

This run croaked 😵

The workflow encountered an error before any progress could be reported. Please check the link below for details.

Pullfrog  | Rerun failed job ➔View workflow run | via Pullfrog𝕏

…eview

# Conflicts:
#	apps/alerting/src/worker.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant