Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

common.wrapError being used incorrectly? #21

@davewasmer

Description

@davewasmer

Looks like common.wrapError is being used incorrectly in notification_bus around line 170:

    this.dataClient.on('taskError', function (evt) {
      common.wrapError(evt);
    });
    this.pubClient.on('taskError', function (evt) {
      common.wrapError(evt);
    });
    this.subClient.on('taskError', function (evt) {
      common.wrapError(evt);
    });

common.wrapError returns a function, so these listeners won't do anything. It seems like wrapError is designed to "pipe" an error event from one emitter to another, and I don't know which emitter these listeners are attempting to pipe to.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions