Skip to content

Commit fc59cdc

Browse files
authored
Document unobvious plugin call trigger/await decisions (#703)
Side quest of OCTRL-1085.
1 parent f9486e9 commit fc59cdc

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

workflows/readout-dataflow.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1855,7 +1855,7 @@ roles:
18551855
- name: pfr
18561856
call:
18571857
func: dcs.PrepareForRun()
1858-
trigger: before_CONFIGURE
1858+
trigger: before_CONFIGURE # PFR cannot be moved earlier because it would increase unreasonably deployment failures timeouts. To be revisited if/when we have a way to abort DCS PFR executions.
18591859
await: after_CONFIGURE-1
18601860
timeout: "{{ dcs_pfr_timeout }}"
18611861
critical: false
@@ -1889,7 +1889,7 @@ roles:
18891889
- name: initialize
18901890
call:
18911891
func: ddsched.PartitionInitialize()
1892-
trigger: before_CONFIGURE
1892+
trigger: before_CONFIGURE # this has to run in parallel with STFSenders CONFIGURE
18931893
await: after_CONFIGURE-1
18941894
timeout: "{{ ddsched_initialize_timeout }}"
18951895
critical: true
@@ -1929,7 +1929,7 @@ roles:
19291929
- name: configure
19301930
call:
19311931
func: odc.Configure()
1932-
trigger: after_CONFIGURE-1
1932+
trigger: after_CONFIGURE-1 # it's started only once stfsenders are in CONFIGURED, so TFBuilder does not produce errors when connecting to STFSenders. However, TFBuilder would eventually connect anyway, so there is no strong justification for delaying this. See OCTRL-607.
19331933
await: after_CONFIGURE-1
19341934
timeout: "{{ odc_configure_timeout }}"
19351935
critical: true

0 commit comments

Comments
 (0)